# Possibility to categorize / group scenes

**URL:** <https://community.gladysassistant.com/t/possibilite-de-categoriser-grouper-les-scenes/7081>\
**Category:** Demandes livrées\
**Tags:** scene, feature-core, regroupement\
**Created:** [March 20, 2022, 11:48am UTC](https://community.gladysassistant.com/t/possibilite-de-categoriser-grouper-les-scenes/7081 "2022-03-20T11:48:12Z")\
**Posts on this page:** 14\
**Page:** 4

<div class="post-metadata">

**Author:** ![Lokkye](https://gladys-assistant-community.b-cdn.net/user_avatar/community.gladysassistant.com/lokkye/32/5881_2.png) [@Lokkye](https://community.gladysassistant.com/u/Lokkye)\
**Post date:** [November 7, 2023, 8:25am UTC](https://community.gladysassistant.com/t/possibilite-de-categoriser-grouper-les-scenes/7081/61 "2023-11-07T08:25:06Z")

</div>

@pierre-gilles : I just fixed all the feedback

---

<div class="post-metadata">

**Author:** ![pierre-gilles](https://gladys-assistant-community.b-cdn.net/user_avatar/community.gladysassistant.com/pierre-gilles/32/5886_2.png) [@pierre-gilles](https://community.gladysassistant.com/u/pierre-gilles)\
**Post date:** [November 10, 2023, 1:22pm UTC](https://community.gladysassistant.com/t/possibilite-de-categoriser-grouper-les-scenes/7081/62 "2023-11-10T13:22:23Z")

</div>

Thanks for the feedback, it’s much better!

I have some UX feedback and a technical one, nothing too serious 🙂

> <https://github.com/GladysAssistant/Gladys/pull/1900#pullrequestreview-1724762190>
>
> \### Pull Request check-list
> 
> To ensure your Pull Request can be accepted as fa…st as possible, make sure to review and check all of these items:
> 
> \- \[x\] If your changes affects code, did your write the tests?
> \- \[x\] Are tests passing? (\`npm test\` on both front/server)
> \- \[x\] Is the linter passing? (\`npm run eslint\` on both front/server)
> \- \[x\] Did you run prettier? (\`npm run prettier\` on both front/server)
> \- \[x\] If you are adding a new features/services, did you run integration comparator? (\`npm run compare-translations\` on front)
> \- \[x\] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (\[french forum\](https://community.gladysassistant.com/)/\[english forum\](https://en-community.gladysassistant.com/)) for testing before merging.
> 
> NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
> 
> \### Description of change
> \<img width="529" alt="Screenshot 2023-09-26 at 08 32 48" src="https://github.com/GladysAssistant/Gladys/assets/11317212/48d81a5b-9417-4ebb-a2b0-9fe959d6771b"\>
> \<img width="705" alt="Screenshot 2023-09-25 at 11 38 03" src="https://github.com/GladysAssistant/Gladys/assets/11317212/da82323d-0067-445a-9db0-879945648b8e"\>

We’re on the right track, I think this can be merged soon!

---

<div class="post-metadata">

**Author:** ![Lokkye](https://gladys-assistant-community.b-cdn.net/user_avatar/community.gladysassistant.com/lokkye/32/5881_2.png) [@Lokkye](https://community.gladysassistant.com/u/Lokkye)\
**Post date:** [November 13, 2023, 7:44am UTC](https://community.gladysassistant.com/t/possibilite-de-categoriser-grouper-les-scenes/7081/63 "2023-11-13T07:44:46Z")

</div>

I’ve just corrected your latest feedback 🙂

---

<div class="post-metadata">

**Author:** ![pierre-gilles](https://gladys-assistant-community.b-cdn.net/user_avatar/community.gladysassistant.com/pierre-gilles/32/5886_2.png) [@pierre-gilles](https://community.gladysassistant.com/u/pierre-gilles)\
**Post date:** [November 13, 2023, 10:03am UTC](https://community.gladysassistant.com/t/possibilite-de-categoriser-grouper-les-scenes/7081/64 "2023-11-13T10:03:34Z")

</div>

Thanks for the feedback 🙂

I still have a few review comments on small details 🙂 : [https://github.com/GladysAssistant/Gladys/pull/1900#pullrequestreview-1726960919](https://github.com/GladysAssistant/Gladys/pull/1900#pullrequestreview-1726960919)

---

<div class="post-metadata">

**Author:** ![Lokkye](https://gladys-assistant-community.b-cdn.net/user_avatar/community.gladysassistant.com/lokkye/32/5881_2.png) [@Lokkye](https://community.gladysassistant.com/u/Lokkye)\
**Post date:** [November 13, 2023, 2:39pm UTC](https://community.gladysassistant.com/t/possibilite-de-categoriser-grouper-les-scenes/7081/65 "2023-11-13T14:39:48Z")

</div>

Thanks for the review 🙂

I’ve made the changes except for the «&nbsp;deselect all&nbsp;» button. I’m not sure that’s useful. We’ll see depending on how everyone uses it. What do you think?

---

<div class="post-metadata">

**Author:** ![Will\_71](https://gladys-assistant-community.b-cdn.net/user_avatar/community.gladysassistant.com/will_71/32/9582_2.png) [@Will\_71](https://community.gladysassistant.com/u/Will_71)\
**Post date:** [November 13, 2023, 3:49pm UTC](https://community.gladysassistant.com/t/possibilite-de-categoriser-grouper-les-scenes/7081/66 "2023-11-13T15:49:43Z")

</div>

> [@Lokkye](#):
>
> button «&nbsp;deselect all&nbsp;». I’m not sure that this is useful

It all depends on the number of tags added.

---

<div class="post-metadata">

**Author:** ![pierre-gilles](https://gladys-assistant-community.b-cdn.net/user_avatar/community.gladysassistant.com/pierre-gilles/32/5886_2.png) [@pierre-gilles](https://community.gladysassistant.com/u/pierre-gilles)\
**Post date:** [November 15, 2023, 8:19am UTC](https://community.gladysassistant.com/t/possibilite-de-categoriser-grouper-les-scenes/7081/67 "2023-11-15T08:19:40Z")

</div>

> [@Lokkye](#):
>
> I’ve given feedback except for the «&nbsp;deselect all&nbsp;» button. I’m not sure that’s useful. It depends on each user’s usage. What do you think?

Ok, I’m happy to see it in real use, but in my opinion the request will come quickly! When I tested I found it inconvenient

---

<div class="post-metadata">

**Author:** ![pierre-gilles](https://gladys-assistant-community.b-cdn.net/user_avatar/community.gladysassistant.com/pierre-gilles/32/5886_2.png) [@pierre-gilles](https://community.gladysassistant.com/u/pierre-gilles)\
**Post date:** [November 16, 2023, 9:10am UTC](https://community.gladysassistant.com/t/possibilite-de-categoriser-grouper-les-scenes/7081/68 "2023-11-16T09:10:27Z")

</div>

It’s all good for me @Lokkye, there’s just ESLint yelling on your last push 😛

And I just have one question about the Cypress tests:

> <https://github.com/GladysAssistant/Gladys/pull/1900#pullrequestreview-1733864268>
>
> \### Pull Request check-list
> 
> To ensure your Pull Request can be accepted as fa…st as possible, make sure to review and check all of these items:
> 
> \- \[x\] If your changes affects code, did your write the tests?
> \- \[x\] Are tests passing? (\`npm test\` on both front/server)
> \- \[x\] Is the linter passing? (\`npm run eslint\` on both front/server)
> \- \[x\] Did you run prettier? (\`npm run prettier\` on both front/server)
> \- \[x\] If you are adding a new features/services, did you run integration comparator? (\`npm run compare-translations\` on front)
> \- \[x\] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (\[french forum\](https://community.gladysassistant.com/)/\[english forum\](https://en-community.gladysassistant.com/)) for testing before merging.
> 
> NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
> 
> \### Description of change
> \<img width="529" alt="Screenshot 2023-09-26 at 08 32 48" src="https://github.com/GladysAssistant/Gladys/assets/11317212/48d81a5b-9417-4ebb-a2b0-9fe959d6771b"\>
> \<img width="705" alt="Screenshot 2023-09-25 at 11 38 03" src="https://github.com/GladysAssistant/Gladys/assets/11317212/da82323d-0067-445a-9db0-879945648b8e"\>

After these two little things, it’s good for me to merge! Can’t wait to publish this 🙂

Edit: Ah wait, small regression on the «&nbsp;New scene&nbsp;» view:

Before:

 ![Screenshot 2023-11-16 at 10.10.55](https://gladys-assistant-community.b-cdn.net/uploads/default/original/2X/8/886f8536048088ad1c5348b92707872d47e969e5.png)

After:

 ![Screenshot 2023-11-16 at 10.10.49](https://gladys-assistant-community.b-cdn.net/uploads/default/original/2X/6/66d3a8f15f80439417550f729e66b74e80815ad2.png)

It looked cleaner before, didn’t it?

---

<div class="post-metadata">

**Author:** ![Hizo](https://gladys-assistant-community.b-cdn.net/letter_avatar_proxy/v4/letter/h/51bf81/32.png) [@Hizo](https://community.gladysassistant.com/u/Hizo)\
**Post date:** [November 16, 2023, 1:51pm UTC](https://community.gladysassistant.com/t/possibilite-de-categoriser-grouper-les-scenes/7081/69 "2023-11-16T13:51:11Z")

</div>

Yes it’s better with the button at the bottom

---

<div class="post-metadata">

**Author:** ![lmilcent](https://gladys-assistant-community.b-cdn.net/user_avatar/community.gladysassistant.com/lmilcent/32/7023_2.png) [@lmilcent](https://community.gladysassistant.com/u/lmilcent)\
**Post date:** [November 17, 2023, 8:19am UTC](https://community.gladysassistant.com/t/possibilite-de-categoriser-grouper-les-scenes/7081/70 "2023-11-17T08:19:23Z")

</div>

It doesn’t visually bother me, but the button at the bottom makes much more sense.  
The flow is Name \> Icon \> Confirm.

---

<div class="post-metadata">

**Author:** ![Lokkye](https://gladys-assistant-community.b-cdn.net/user_avatar/community.gladysassistant.com/lokkye/32/5881_2.png) [@Lokkye](https://community.gladysassistant.com/u/Lokkye)\
**Post date:** [November 17, 2023, 1:39pm UTC](https://community.gladysassistant.com/t/possibilite-de-categoriser-grouper-les-scenes/7081/71 "2023-11-17T13:39:25Z")

</div>

@pierre-gilles @Hizo @lmilcent : Yes I agree with you. I still wonder how I managed to swap those two components when I wasn’t supposed to touch that code 🙂

@pierre-gilles : I just made the fixes on the PR and rebased onto master so you can easily merge it

---

<div class="post-metadata">

**Author:** ![pierre-gilles](https://gladys-assistant-community.b-cdn.net/user_avatar/community.gladysassistant.com/pierre-gilles/32/5886_2.png) [@pierre-gilles](https://community.gladysassistant.com/u/pierre-gilles)\
**Post date:** [November 20, 2023, 2:09pm UTC](https://community.gladysassistant.com/t/possibilite-de-categoriser-grouper-les-scenes/7081/72 "2023-11-20T14:09:15Z")

</div>

It’s good for me @Lokkye, thanks for the fixes 👏

It’s merged into master and will be included in the next Gladys release 🙂

I just have a few small notes that weren’t blocking for the review that I noticed:

- With Preact, there’s no need to rename `class=` to `className=`. className is a React-specific thing that doesn’t apply to Preact; it’s even recommended to stick with `class=` 🙂 (but className still works)
- To hide content on small screens, you can use built-in Bootstrap classes, which avoids re-writing CSS ( [Display property · Bootstrap](https://getbootstrap.com/docs/4.0/utilities/display/#hiding-elements) )

---

<div class="post-metadata">

**Author:** ![pierre-gilles](https://gladys-assistant-community.b-cdn.net/user_avatar/community.gladysassistant.com/pierre-gilles/32/5886_2.png) [@pierre-gilles](https://community.gladysassistant.com/u/pierre-gilles)\
**Post date:** [November 20, 2023, 4:27pm UTC](https://community.gladysassistant.com/t/possibilite-de-categoriser-grouper-les-scenes/7081/73 "2023-11-20T16:27:48Z")

</div>

This feature is available in Gladys Assistant 4.31! 🚀

> [@Gladys Assistant 4.31 : Filtre par tag & MQTT dans les scènes](https://community.gladysassistant.com/t/gladys-assistant-4-31-filtre-par-tag-mqtt-dans-les-scenes/8511):
>
> Salut à tous ! Après Gladys Assistant 4.30 et sa fameuse alarme, voilà une nouvelle version de Gladys avec pas mal de fonctionnalités sympa slight_smile A découvrir ci-dessus ! Merci à @Lokkye et @cicoub13 pour leurs contributions clapclap Edit: Je profite de ce post pour dire que je recherche de l’aide ici pour écrire du contenu sur le blog Gladys !

I’m closing this thread to free up the votes — feel free to create a new thread if you encounter any bugs with this feature 🙂

---

<div class="post-metadata">

**Author:** ![pierre-gilles](https://gladys-assistant-community.b-cdn.net/user_avatar/community.gladysassistant.com/pierre-gilles/32/5886_2.png) [@pierre-gilles](https://community.gladysassistant.com/u/pierre-gilles)\
**Post date:** [November 20, 2023, 4:27pm UTC](https://community.gladysassistant.com/t/possibilite-de-categoriser-grouper-les-scenes/7081/74 "2023-11-20T16:27:52Z")

</div>



[Previous page](https://community.gladysassistant.com/t/possibilite-de-categoriser-grouper-les-scenes/7081.md?page=3)