# Service Netatmo **URL:** \ **Category:** Développement\ **Tags:** netatmo\ **Created:** [May 8, 2020, 5:54pm UTC](https://community.gladysassistant.com/t/service-netatmo/5910 "2020-05-08T17:54:28Z")\ **Posts on this page:** 20\ **Page:** 14
**Author:** ![Terdious](https://gladys-assistant-community.b-cdn.net/user_avatar/community.gladysassistant.com/terdious/32/6316_2.png) [@Terdious](https://community.gladysassistant.com/u/Terdious)\ **Post date:** [December 30, 2023, 6:51pm UTC](https://community.gladysassistant.com/t/service-netatmo/5910/262 "2023-12-30T18:51:45Z")
Documentation finished!! [Add Netatmo integration doc by Terdious · Pull Request #238 · GladysAssistant/v4-website · GitHub](https://github.com/GladysAssistant/v4-website/pull/238) Is there anyone who can tell me if everything is clear? Airtable ‹ en › and ‹ fr › updated ([Airtable - Netatmo NATherm1](https://airtable.com/apptqzQKsqMkRQ8GL/tblH2SteqMo805rG7/viwWFXnmSp8f5LxkB/rechgt0wKoH7s27sT?blocks=hide)). However I don’t see how to integrate it into the documentation, since the documentation ID ‹ netatmo › doesn’t exist and I don’t see how to add it: ![image](https://gladys-assistant-community.b-cdn.net/uploads/default/original/2X/e/e2f11504924bde00d7e23d4eb2623d8975785dbf.png) For info, I added to the Amazon links `\u0026tag=gladproj-21`. The redirect works but I’m not really sure the affiliation is being taken into account (‹ 21 › = year 2021? Do we have to change it every year?) ---
**Author:** ![pierre-gilles](https://gladys-assistant-community.b-cdn.net/user_avatar/community.gladysassistant.com/pierre-gilles/32/5886_2.png) [@pierre-gilles](https://community.gladysassistant.com/u/pierre-gilles)\ **Post date:** [January 5, 2024, 1:34pm UTC](https://community.gladysassistant.com/t/service-netatmo/5910/263 "2024-01-05T13:34:24Z")
> [@Terdious](#): > > Documentation completed!! [Add Netatmo integration doc by Terdious · Pull Request #238 · GladysAssistant/v4-website · GitHub](https://github.com/GladysAssistant/v4-website/pull/238) Thanks for the documentation! It’s very comprehensive and clean. For the title, can you put a longer title that clearly explains what this tutorial allows you to do? Example: Connect your Netatmo thermostats to your home automation system This helps get found on Google for those kinds of keywords with a catchy title not tied to Gladys (do not mention Gladys in the title) For the roadmap section, I’d suggest removing all dates — we never commit to dates on Gladys otherwise it just creates disappointment 🙂 Priorities change, and it’s impossible to commit… Just put a list of things you want to do! > [@Terdious](#): > > For info, I added to the Amazon links `\u0026tag=gladproj-21`. The redirect works but I’m not really sure the affiliation is taken into account (‹ 21 › = year 2021 ? Should we change it every year ?) That’s kind, but there’s no need to add affiliate links, they are added automatically! And no, 21 is just a number generated once by Amazon a long time ago 😉 Regarding the integration, how far along are you and who managed to test it in the end? ---
**Author:** ![Terdious](https://gladys-assistant-community.b-cdn.net/user_avatar/community.gladysassistant.com/terdious/32/6316_2.png) [@Terdious](https://community.gladysassistant.com/u/Terdious)\ **Post date:** [January 5, 2024, 1:41pm UTC](https://community.gladysassistant.com/t/service-netatmo/5910/264 "2024-01-05T13:41:10Z")
Hi @pierre-gilles !! Welcome back, best wishes for 2024 to you. Ok, I’ll make the changes for the doc ^^ > [@pierre-gilles](#): > > Example: Connect your Netatmo thermostats to your home automation setup For this I followed Sonos for the ending: **« Connect your Netatmo thermostats to your connected home »** Sorry I understand the thread is very long to go through ^^ So as said above, the integration PR is ready, I sent you a review request. Tested by @_Will_71 (test with his thermostat) and by @Tlse-vins (test without compatible devices + tests with my instance with a thermostat). Apart from the display bug of the setpoint (not related to this PR) everything should be fine. Has been running on my setup for almost 3 weeks. The advantage is that it can be tested by anyone; I just need to share my instance. If you’re up for it… tell me. Let me know. ---
**Author:** ![Terdious](https://gladys-assistant-community.b-cdn.net/user_avatar/community.gladysassistant.com/terdious/32/6316_2.png) [@Terdious](https://community.gladysassistant.com/u/Terdious)\ **Post date:** [January 5, 2024, 1:56pm UTC](https://community.gladysassistant.com/t/service-netatmo/5910/265 "2024-01-05T13:56:09Z")
All good, it’s done for the documentation and for Airtable. [quote=« Terdious, post:262, topic:5910 »] However I don’t see how to integrate it into the documentation ---
**Author:** ![pierre-gilles](https://gladys-assistant-community.b-cdn.net/user_avatar/community.gladysassistant.com/pierre-gilles/32/5886_2.png) [@pierre-gilles](https://community.gladysassistant.com/u/pierre-gilles)\ **Post date:** [January 5, 2024, 4:39pm UTC](https://community.gladysassistant.com/t/service-netatmo/5910/266 "2024-01-05T16:39:37Z")
> [@Terdious](#): > > For this one I copied Sonos for the ending: **« Connect your Netatmo thermostats to your connected home »** perfect! > [@Terdious](#): > > I’ve sent you a review request. Ok I’ll take a look next week, I have quite a lot to catch up on first 🙂 > [@Terdious](#): > > So for this part? Should I leave it like this and you’ll take care of it? Can’t you create an option in Airtable? If you type « netatmo » doesn’t it offer you to create it? ---
**Author:** ![Terdious](https://gladys-assistant-community.b-cdn.net/user_avatar/community.gladysassistant.com/terdious/32/6316_2.png) [@Terdious](https://community.gladysassistant.com/u/Terdious)\ **Post date:** [January 5, 2024, 5:39pm UTC](https://community.gladysassistant.com/t/service-netatmo/5910/267 "2024-01-05T17:39:06Z")
[quote="pierre-gilles, post:266, ---
**Author:** ![Tlse-vins](https://gladys-assistant-community.b-cdn.net/user_avatar/community.gladysassistant.com/tlse-vins/32/6054_2.png) [@Tlse-vins](https://community.gladysassistant.com/u/Tlse-vins)\ **Post date:** [January 6, 2024, 9:56am UTC](https://community.gladysassistant.com/t/service-netatmo/5910/268 "2024-01-06T09:56:05Z")
I didn’t have time to look at everything, but I noted this: - In the Sonos docs we added the link to the Android and Apple apps; do the same for Netatmo. - I put all the clickable buttons in Gladys as preformatted text (`Intégration -> Netatmo`) with the small arrow as well. - Add at the end: I invite you to post a message on the forum ---
**Author:** ![Terdious](https://gladys-assistant-community.b-cdn.net/user_avatar/community.gladysassistant.com/terdious/32/6316_2.png) [@Terdious](https://community.gladysassistant.com/u/Terdious)\ **Post date:** [January 6, 2024, 10:51am UTC](https://community.gladysassistant.com/t/service-netatmo/5910/269 "2024-01-06T10:51:00Z")
Hi @Tlse-vins, > [@Tlse-vins](#): > > In the Sonos doc we added links to the Android and Apple apps, do the same for Netatmo. It’s already done! > [@Tlse-vins](#): > > I put all the clickable buttons in Gladys as preformatted ( `Integration -> Netatmo` ) with the little arrow too. It’s fixed: - Before ![image](https://gladys-assistant-community.b-cdn.net/uploads/default/original/2X/4/4a97d81a8bc060ab42a0c48aaf1651850a8e0bac.png) ![image](https://gladys-assistant-community.b-cdn.net/uploads/default/original/2X/d/d27a14678fc362f7b55101a78a32bb7c99ed5297.png) …etc… - After ![image](https://gladys-assistant-community.b-cdn.net/uploads/default/original/2X/0/00cbd990f9e89893469e977e9d56c83036322921.png) ![image](https://gladys-assistant-community.b-cdn.net/uploads/default/original/2X/1/1dfd691c3c3dc78c452a676137979ffe8b7bd500.png) …etc… > [@Tlse-vins](#): > > Add at the end: I invite you to post a message on the forum if you ever need help. Done, I also added access to the « Dashboard » and « Scenes » documentation: ![image](https://gladys-assistant-community.b-cdn.net/uploads/default/original/2X/9/91d6335773fa16d992a03978a426ccc125e77e65.png) Everything is live. Thanks for your feedback. Edit : > [@Terdious](#): > > > [@Tlse-vins](#): > > > > In the Sonos doc we added links to the Android and Apple apps, do the same for Netatmo. > > It’s already done! My bad… Apple was missing ^^ =\> It’s done! ---
**Author:** ![Terdious](https://gladys-assistant-community.b-cdn.net/user_avatar/community.gladysassistant.com/terdious/32/6316_2.png) [@Terdious](https://community.gladysassistant.com/u/Terdious)\ **Post date:** [January 10, 2024, 10:10am UTC](https://community.gladysassistant.com/t/service-netatmo/5910/270 "2024-01-10T10:10:49Z")
@pierre-gilles please, I need help, A quick question, which I initially asked you on the Netatmo integration pull request (PR), but I think you haven’t been paying attention to it: After the release of v4.34.0 I updated the branch, but as often happens there was a failure on the Codecov report. In your live coding video, you answered my question about re-running the PR tests: ![image](https://gladys-assistant-community.b-cdn.net/uploads/default/original/2X/9/963e026ef73025273446d6070a921cb20a8cb435.jpeg) However on my side, I don’t have the « Re-run jobs » option at all 😭 — wouldn’t you need to grant some permissions so I can perform this action? ![image](https://gladys-assistant-community.b-cdn.net/uploads/default/original/2X/9/9e489db6b22f06e711a820f04c118873964a33a3.png) Thanks in advance, I’d be disappointed if you passed over the ---
**Author:** ![pierre-gilles](https://gladys-assistant-community.b-cdn.net/user_avatar/community.gladysassistant.com/pierre-gilles/32/5886_2.png) [@pierre-gilles](https://community.gladysassistant.com/u/pierre-gilles)\ **Post date:** [January 10, 2024, 4:20pm UTC](https://community.gladysassistant.com/t/service-netatmo/5910/271 "2024-01-10T16:20:51Z")
Ah, it often happens that codecov breaks, it’s super unstable ^^ [quote="Terdious, post ---
**Author:** ![Terdious](https://gladys-assistant-community.b-cdn.net/user_avatar/community.gladysassistant.com/terdious/32/6316_2.png) [@Terdious](https://community.gladysassistant.com/u/Terdious)\ **Post date:** [January 10, 2024, 8:28pm UTC](https://community.gladysassistant.com/t/service-netatmo/5910/272 "2024-01-10T20:28:56Z")
Yep, I checked too… nothing… maybe an option on my end then!! ---
**Author:** ![pierre-gilles](https://gladys-assistant-community.b-cdn.net/user_avatar/community.gladysassistant.com/pierre-gilles/32/5886_2.png) [@pierre-gilles](https://community.gladysassistant.com/u/pierre-gilles)\ **Post date:** [January 11, 2024, 9:14am UTC](https://community.gladysassistant.com/t/service-netatmo/5910/273 "2024-01-11T09:14:35Z")
Weird, well I re-ran it myself but it’s really not great if a developer from a fork can’t re-run the tests of their own PR! ^^ I left you a first review of this PR: [Netatmo integration by Terdious · Pull Request #1951 · GladysAssistant/Gladys · GitHub](https://github.com/GladysAssistant/Gladys/pull/1951#pullrequestreview-1814951634) I’m a bit surprised, the PR doesn’t look at all like what I saw when I went to look at your code after the live coding… The code is quite far from what I show in the live coding, I think! I’ve pointed out quite a few things to fix. Spend time on the PR and try to read through it entirely to apply these changes everywhere 🙂 In terms of code quantity, we’re back to a pretty large PR so I’m really glad we limited ourselves to the thermostat, it’s already a big chunk to review Thanks again for the work done on this PR 🙏 ---
**Author:** ![Terdious](https://gladys-assistant-community.b-cdn.net/user_avatar/community.gladysassistant.com/terdious/32/6316_2.png) [@Terdious](https://community.gladysassistant.com/u/Terdious)\ **Post date:** [January 11, 2024, 9:45am UTC](https://community.gladysassistant.com/t/service-netatmo/5910/274 "2024-01-11T09:45:59Z")
Hello @pierre-gilles, Thank you very much for your review. I’ll get to it today. I’ll spend whatever time is needed. > [@pierre-gilles](#): > > The code is quite far from what I show in live coding, I find! It’s true, but does that seem normal to you because we’re not using an external module like for sonos, or do you think that’s really not normal? Otherwise, it might not be worth fixing, but rather rewriting the code entirely… About the « netatmoHandler » passed everywhere… I suppose it’s a misunderstanding/configuration issue with my VS Code. The « this. » is reported as an eslint error everywhere in my VS Code interface, so I was passing the ‹ netatmoHandler › for that reason only. > [@pierre-gilles](#): > > In terms of code volume, we’re back to a rather fat PR so I’m really happy we limited ourselves to the thermostat, it’s already a big piece to review Do we agree that it’s because we’re managing the whole code ourselves and not going through a node\_module « netatmo »? Or for you is it related to bad code? I’m asking these questions because I spend a lot of time on this (with pleasure, of course) but if it’s going to make you waste a lot of time and me too, we shouldn’t continue. If, however, with the fixes you point out and the time you spend we’re « sure » to succeed, then I’ll give everything 😅 Thanks again for the review! ---
**Author:** ![pierre-gilles](https://gladys-assistant-community.b-cdn.net/user_avatar/community.gladysassistant.com/pierre-gilles/32/5886_2.png) [@pierre-gilles](https://community.gladysassistant.com/u/pierre-gilles)\ **Post date:** [January 11, 2024, 4:50pm UTC](https://community.gladysassistant.com/t/service-netatmo/5910/275 "2024-01-11T16:50:45Z")
No no, don’t worry, the spirit of the PR and the overall way of doing things is good 🙂 ---
**Author:** ![Terdious](https://gladys-assistant-community.b-cdn.net/user_avatar/community.gladysassistant.com/terdious/32/6316_2.png) [@Terdious](https://community.gladysassistant.com/u/Terdious)\ **Post date:** [January 15, 2024, 6:56pm UTC](https://community.gladysassistant.com/t/service-netatmo/5910/276 "2024-01-15T18:56:55Z")
Hi @pierre-gilles, I’ve finished the requested changes (I’ve checked everything and reread your comments three times, I hope I didn’t forget anything, otherwise I’m really bad) and updated the tests; everything should be fixed. As I mentioned in the PR, however, I don’t understand the issue you had > Blockquote > **On the functional side** > > When I first open the integration, here is what I see: > > There is an error message immediately (I didn’t do anything), which is a bit weird for the user. > > ![image](https://gladys-assistant-community.b-cdn.net/uploads/default/original/2X/7/7e63a3ec09bd267ff4b9df482b6d2a967a9c859a.png) I tried to reproduce it but I can’t even reproduce your first connection error… Apparently none of the two testers encountered it and I’ve just retried with a new installation on WSL, I don’t have this problem…, my first-connection state: ![image](https://gladys-assistant-community.b-cdn.net/uploads/default/original/2X/9/9396d5b9f82985125b756d337d3fce57c3ef5434.png) I also tested via the Docker image and my first-connection state with an empty DB is also: ![image](https://gladys-assistant-community.b-cdn.net/uploads/default/original/2X/7/710184889b7c2ebe1bf3c913d152a95af355f222.png) Could you check on your side to guide me if you encounter the issue again? Logs, browser inspector? I should point out that the visuals are from before the fixes. Thanks in advance for the next review. ---
**Author:** ![Terdious](https://gladys-assistant-community.b-cdn.net/user_avatar/community.gladysassistant.com/terdious/32/6316_2.png) [@Terdious](https://community.gladysassistant.com/u/Terdious)\ **Post date:** [January 17, 2024, 10:51am UTC](https://community.gladysassistant.com/t/service-netatmo/5910/277 "2024-01-17T10:51:10Z")
For info, after a few final changes, here is what I have on my 3 service pages for the states : - Before the 1st login after account creation : - After the 1st login : - Once logged in : - During a refresh of devices on the discovery page : - After refreshing devices on the discovery page : - After adding devices in Gladys : - If we go back to the pages after adding devices, during the retrieval of values on the 2-minute poll (I added the phrase « : » - On logout : ---
**Author:** ![pierre-gilles](https://gladys-assistant-community.b-cdn.net/user_avatar/community.gladysassistant.com/pierre-gilles/32/5886_2.png) [@pierre-gilles](https://community.gladysassistant.com/u/pierre-gilles)\ **Post date:** [January 18, 2024, 10:47am UTC](https://community.gladysassistant.com/t/service-netatmo/5910/278 "2024-01-18T10:47:51Z")
Thanks @Terdious for the fixes !! 🙂 It’s very nice. > [@Terdious](#): > > I tried to reproduce it but I can’t even reproduce your first connection error… I think it was just a local server connection issue during my tests, I don’t think it’s related to the PR! I’ll re-test and I’ll keep you posted 🙂 ---
**Author:** ![Terdious](https://gladys-assistant-community.b-cdn.net/user_avatar/community.gladysassistant.com/terdious/32/6316_2.png) [@Terdious](https://community.gladysassistant.com/u/Terdious)\ **Post date:** [January 18, 2024, 11:00am UTC](https://community.gladysassistant.com/t/service-netatmo/5910/279 "2024-01-18T11:00:58Z")
Don’t hesitate to ask if you want access to view the devices live and to do real testing, it can be better, and it shouldn’t be complicated! I just tested with another email address, it works well even without owning Netatmo equipment. ---
**Author:** ![Terdious](https://gladys-assistant-community.b-cdn.net/user_avatar/community.gladysassistant.com/terdious/32/6316_2.png) [@Terdious](https://community.gladysassistant.com/u/Terdious)\ **Post date:** [January 20, 2024, 8:55am UTC](https://community.gladysassistant.com/t/service-netatmo/5910/280 "2024-01-20T08:55:45Z")
@pierre-gilles , Since I’m waiting on this PR, can I start a PR based on this first PR? Knowing that it won’t be wasted work, it will be easy to recover the work even if big changes are requested during the new review. But it allows me to stay involved and save time overall. My question is mainly: for you, what impact? Will it be constraining or problematic once the first PR is merged? ---
**Author:** ![pierre-gilles](https://gladys-assistant-community.b-cdn.net/user_avatar/community.gladysassistant.com/pierre-gilles/32/5886_2.png) [@pierre-gilles](https://community.gladysassistant.com/u/pierre-gilles)\ **Post date:** [January 23, 2024, 9:20am UTC](https://community.gladysassistant.com/t/service-netatmo/5910/281 "2024-01-23T09:20:41Z")
No, it’s not a problem as long as you separate the two PRs properly [Previous page](https://community.gladysassistant.com/t/service-netatmo/5910.md?page=13) [Next page](https://community.gladysassistant.com/t/service-netatmo/5910.md?page=15)