Goulby
20. Februar 2021 um 15:53
1
Hallo,
Was die Boxen angeht, dachte ich, dass es interessant sein könnte, eine zur Verfügung zu haben, um To-Do-Listen, Einkaufslisten usw. zu erstellen. Ich glaube, das wäre nicht unbedingt kompliziert umzusetzen.
Und warum nicht, wenn man eine To-Do-Liste hat, die Möglichkeit hinzufügen, ein Erinnerungsdatum einzutragen (falls es nicht redundant mit dem Kalender ist) und die Möglichkeit, eine Rückmeldung im Chat zu erhalten. (« Gib mir die Einkaufsliste », « Was muss ich heute tun? »)
VonOx
20. Februar 2021 um 17:17
2
Für Info gibt es einen PR für die Todoist-Integration
master ← callemand:tasks.todoist
ouvert 01:36PM - 11 Feb 21 UTC
### Pull Request check-list
To ensure your Pull Request can be accepted as fa… st as possible, make sure to review and check all of these items:
- [x] If your changes affects code, did your write the tests?
- [x] Are tests passing? (`npm test` on both front/server)
- [X] Is the linter passing? (`npm run eslint` on both front/server)
- [X] Did you run prettier? (`npm run prettier` on both front/server)
- [X] If you are adding a new features/services, did you run integration comparator? (`npm run compare-translations` on front)
- [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
- [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See [the GitHub repo](https://github.com/GladysAssistant/v4-website) and the [website](https://gladysassistant.com).
- [X] Did you add fake requests data for the demo mode (`front/src/config/demo.json`) so that the demo website is working without a backend? (if needed) See [https://demo.gladysassistant.com](https://demo.gladysassistant.com).
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
### Description of change
Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!
It's a fork on https://github.com/GladysAssistant/Gladys/pull/960
It's just to add the tests and to do some graphic adjustment
Für Info gibt es einen neuen PR für die Todoist-Integration, entwickelt von @Lokkye !
master ← callemand:tasks.todoist
ouvert 12:00PM - 01 Jan 23 UTC
### Pull Request check-list
To ensure your Pull Request can be accepted as fa… st as possible, make sure to review and check all of these items:
- [X] If your changes affects code, did your write the tests?
- [X] Are tests passing? (`npm test` on both front/server)
- [X] Is the linter passing? (`npm run eslint` on both front/server)
- [X] Did you run prettier? (`npm run prettier` on both front/server)
- [X] If you are adding a new features/services, did you run integration comparator? (`npm run compare-translations` on front)
- [X] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to [the community](https://community.gladysassistant.com/) for testing before merging.
- [X] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
- [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See [the GitHub repo](https://github.com/GladysAssistant/v4-website) and the [website](https://gladysassistant.com).
- [ ] Did you add fake requests data for the demo mode (`front/src/config/demo.js`) so that the demo website is working without a backend? (if needed) See [https://demo.gladysassistant.com](https://demo.gladysassistant.com).
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
### Description of change
I have made some adjustment from this PR : https://github.com/GladysAssistant/Gladys/pull/1073
Adding todolist box on the dashboard. for the moment it's connected to Todoist. But my goal is to connect Google Tasks and some other tools from google :)
@Lokkye du hast eine Review von @AlexTrovato bekommen
Falls nach der Behebung des PRs funktionale Tests (auf einem RPI4) benötigt werden, kann ich
Ich habe mich nicht an diese Anfrage erinnert und hätte sie fast gestellt.
Zögere nicht, jetzt schon Tests durchzuführen
Lokkye
20. Januar 2023 um 14:10
7
Die Rezension hatte ich nicht gesehen. Danke. Das schau ich mir heute Abend an.
Lokkye
20. Januar 2023 um 20:00
8
@AlexTrovato @pierre-gilles : Ich habe die Korrekturen/Antworten im PR gemacht
@Lokkye Ich hatte gestern auf das PR geantwortet, ich weiß nicht, ob du es gesehen hast
Ich denke, wir sollten uns überlegen, wie wir diese Integration kategorisieren, und meiner Meinung nach sollten wir ein Datenmodell für Gladys definieren und nicht das Modell von Todoist wiederverwenden
Hallo @Lokkye , ich weiß nicht, ob du meine Kommentare zur PR gesehen hast?
