PR-Review - Ich brauche euch!

pierre-gilles · 22. Januar 2021 um 16:14

Hop, ein neues PR, das Feedback braucht, die Netatmo-PR von @damalgos und @Terdious!

Hier testen:

github.com/GladysAssistant/Gladys

Service Netatmo (#1015)

master ← thibautmery:netatmo

ouvert 05:57PM - 17 Dec 20 UTC

thibautmery

+11540 -161

### Pull Request check-list To ensure your Pull Request can be accepted as fa…st as possible, make sure to review and check all of these items: - [ ] If your changes affects code, did your write the tests? - [ ] Are tests passing? (`npm test` on both front/server) - [ ] Is the linter passing? (`npm run eslint` on both front/server) - [ ] Did you run prettier? (`npm run prettier` on both front/server) - [ ] If you are adding a new features/services, did you run integration comparator? (`npm run compare-translations` on front) - [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code) - [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See [the GitHub repo](https://github.com/GladysAssistant/v4-website) and the [website](https://gladysassistant.com). - [ ] Did you add fake requests data for the demo mode (`front/src/config/demo.json`) so that the demo website is working without a backend? (if needed) See [https://demo.gladysassistant.com](https://demo.gladysassistant.com). NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open. ### Description of change Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

Thema		Antworten	Aufrufe
[TOPIC UNIQUE] Unités de mesures Développement	29	1776	4. Mai 2022
Point PR janvier 2023 Développement	19	915	20. Januar 2023
Plusieurs erreurs/manques pour Tasmota POW-R2 Développement node-red	59	2337	3. Juli 2023
Analyse: Priorisation des développements: Core / intégrations? Actualités	43	2040	5. September 2022
[V4] Dev service Withings Développement feature-integration , withings	139	5520	2. Dezember 2024

PR-Review - Ich brauche euch!

Verwandte Themen