Hi developers
A German Gladys user submitted a PR to add German to Gladys:
master ← patrickschoebel:master
ouvert 11:42AM - 05 Jan 24 UTC
### Pull Request check-list
To ensure your Pull Request can be accepted as fa… st as possible, make sure to review and check all of these items:
- [ ] If your changes affects code, did your write the tests?
- [ ] Are tests passing? (`npm test` on both front/server)
- [x] Is the linter passing? (`npm run eslint` on both front/server)
- [x] Did you run prettier? (`npm run prettier` on both front/server)
- [x] If you are adding a new features/services, did you run integration comparator? (`npm run compare-translations` on front)
- [x] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community ([french forum](https://community.gladysassistant.com/)/[english forum](https://en-community.gladysassistant.com/)) for testing before merging.
- [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
- [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See [the GitHub repo](https://github.com/GladysAssistant/v4-website) and the [website](https://gladysassistant.com).
- [ ] Did you add fake requests data for the demo mode (`front/src/config/demo.js`) so that the demo website is working without a backend? (if needed) See [https://demo.gladysassistant.com](https://demo.gladysassistant.com).
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
### Description of change
This PR includes a complete German translation. Also, the language in local account creation is now been set based on `getDefaultState().user.language`.
The PR works perfectly, and Germany is a country I had in mind for the future:
It’s the country with the most open-source home automation users in Europe (Source: HA stats).
Gladys Plus servers are in Germany so commercially it makes a lot of sense to be present there.
I merged the PR, but it means one thing: from now on, new PRs will also need to be translated into German.
I suggest DeepL Translate: The world's most accurate translator for that, or ChatGPT.
If this becomes too burdensome, we can consider other solutions than JSON for translations. It could be online translation software as is often the case in companies.
For now, we’ll stay like this and see
3 Likes
That works for me, especially if ChatGPT is as effective in German as in English; I don’t think it’s really a burden!! Honestly, it doesn’t take long in English, it won’t take much longer in German. And we’ll count on the community to report any mistakes!!^^
Then the documentation will also have to be translated!
1 Like
Definitely for the future, but right now that seems a bit premature ^^
Let’s first try to get 10 German users
