Goulby
February 20, 2021, 3:53pm
1
Bonjour,
Au niveau des boxes, je me disais qu’en avoir une à disposition pour faire des to-do list, liste de course… pourrais être intéressant et pas forcément compliqué à mettre en place je pense.
Et pourquoi pas, si on a une to-do list, inclure la possibilité de rajouter une date de rappel (si c’est pas redondant avec le calendrier) et la possibilité d’avoir un retour dans le chat. (« Donne moi la liste de course », « Que dois-je faire aujourd’hui ? »)
VonOx
February 20, 2021, 5:17pm
2
Pour info il y’a une PR pour l’intégration todoist
https://github.com/GladysAssistant/Gladys/pull/1073
FYI, there is a new PR for the Todoist integration, developed by @Lokkye !
master ← callemand:tasks.todoist
ouvert 12:00PM - 01 Jan 23 UTC
### Pull Request check-list
To ensure your Pull Request can be accepted as fa… st as possible, make sure to review and check all of these items:
- [X] If your changes affects code, did your write the tests?
- [X] Are tests passing? (`npm test` on both front/server)
- [X] Is the linter passing? (`npm run eslint` on both front/server)
- [X] Did you run prettier? (`npm run prettier` on both front/server)
- [X] If you are adding a new features/services, did you run integration comparator? (`npm run compare-translations` on front)
- [X] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to [the community](https://community.gladysassistant.com/) for testing before merging.
- [X] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
- [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See [the GitHub repo](https://github.com/GladysAssistant/v4-website) and the [website](https://gladysassistant.com).
- [ ] Did you add fake requests data for the demo mode (`front/src/config/demo.js`) so that the demo website is working without a backend? (if needed) See [https://demo.gladysassistant.com](https://demo.gladysassistant.com).
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
### Description of change
I have made some adjustment from this PR : https://github.com/GladysAssistant/Gladys/pull/1073
Adding todolist box on the dashboard. for the moment it's connected to Todoist. But my goal is to connect Google Tasks and some other tools from google :)
@Lokkye you got a review from @AlexTrovato
If functional tests (on an RPI4) are needed after the PR is corrected, I can
I didn’t remember this request; I almost did it.
Don’t hesitate to run tests right away
Lokkye
January 20, 2023, 2:10pm
7
I hadn’t seen the review. Thanks. I’ll check that tonight.
Lokkye
January 20, 2023, 8:00pm
8
@AlexTrovato @pierre-gilles : I’ve made the corrections/responses on the PR
@Lokkye I replied to the PR yesterday, not sure if you saw it
There’s a small point to consider, in my opinion, about how we categorize this integration, and I think we should define a Gladys-specific data model and not reuse Todoist’s model
Hi @Lokkye , I don’t know if you had seen my comments on the PR?
