VonOx
September 4, 2021, 9:03am
1
Bonjour à vous,
après quelques temps d’utilisation, voici quelques retours et demandes en vrac, ce ne sont que des retours, aucune obligation ou mécontentement de ma part.
Le travail déjà réalisé est génial !
Scènes
Permettre la modification de l’icône des scènes une fois créées (on peut les renommer mais pas changer l’icône).
Permettre de dupliquer des scènes afin de pas tout recréer de 0 lorsqu’on fait des scènes très proches.
Préciser le matériel ayant déclencher la scène lorsqu’il y a p…
The title speaks for itself, the need is to have a box that allows displaying the features of the devices independently of the room. Example, we could group all the device battery features to have at a glance the battery level of our peripherals.
I also think of @Terdious , the box could have an optional filter on the type of feature (temperature / battery etc…) because with a large installation the list will probably be as long as an arm.
The goal is to avoid this:
or this:
I love it a lot! And thank you for the kind thought @VonOx
Hizo
March 7, 2022, 11:04am
4
Hello everyone,
I wanted to know if the proposal was selected and if you had been able to make progress on it
Thank you very much
Hello @Hizo As far as I know, no one has started this development.
For my part, I usually follow the order of votes. Last month, I worked on using the calendar in scenes , a request that had 17 votes This request only has 10 votes, so either it needs more votes, or we have to wait until all requests with more votes are developed
Hizo
March 7, 2022, 2:46pm
6
Oh, I think that would be very useful.
Maybe this little update will bring in more votes
Thanks again for all your hard work!
Hello everyone, I’ve started working on the feature. I have good results so far. I have 2-3 things left to finish and need to do the unit tests. I think I’ll have a PR by the end of the week.
The little PR that does the trick:
master ← callemand:BoxDevices
ouvert 06:53AM - 31 May 23 UTC
### Pull Request check-list
To ensure your Pull Request can be accepted as fa… st as possible, make sure to review and check all of these items:
- [x] If your changes affects code, did your write the tests?
- [x] Are tests passing? (`npm test` on both front/server)
- [x] Is the linter passing? (`npm run eslint` on both front/server)
- [x] Did you run prettier? (`npm run prettier` on both front/server)
- [x] If you are adding a new features/services, did you run integration comparator? (`npm run compare-translations` on front)
- [x] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to [the community](https://community.gladysassistant.com/) for testing before merging.
- [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
- [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See [the GitHub repo](https://github.com/GladysAssistant/v4-website) and the [website](https://gladysassistant.com).
- [ ] Did you add fake requests data for the demo mode (`front/src/config/demo.js`) so that the demo website is working without a backend? (if needed) See [https://demo.gladysassistant.com](https://demo.gladysassistant.com)._
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
### Description of change
Add a new box for the dashboard who can display a list of devices (like Device in room but without room)
<img width="1102" alt="Screenshot 2023-05-31 at 09 18 11" src="https://github.com/GladysAssistant/Gladys/assets/11317212/ae961e8b-62b0-4116-86e8-2e5cdee4eab1">
<img width="1233" alt="Screenshot 2023-05-31 at 09 17 58" src="https://github.com/GladysAssistant/Gladys/assets/11317212/e54c14a3-5ac6-44ed-99a1-3a8da5e880d2">
Hizo
May 31, 2023, 9:10pm
10
Quick question, why limit the types of equipment compatible with this feature?
Thanks! I’ll look tomorrow and keep you posted
We only display what we’re able to show in this box; some features are not meant to be displayed here, for example: cameras!
Lokkye
June 2, 2023, 1:48pm
13
@pierre-gilles : I left feedback on your review
So cool I’ll check that out on Monday!
I just left you a review!
Lokkye
June 7, 2023, 4:39pm
16
Thanks for the review. I’ve made the corrections accordingly
Thanks for your fixes, it’s working on my side now
I have some feedback but nothing very serious. Regarding the translations I suggest this :
(I think it’s currently an oversight, the text is duplicated twice)
You will find the full review here : https://github.com/GladysAssistant/Gladys/pull/1803#pullrequestreview-1471210131
Thanks again for the dev work
Lokkye
June 12, 2023, 9:53am
18
@pierre-gilles : Normally, I have fixed all the « problems » you reported.
Could you do a quick review again?
Thanks for the feedback — for the translations, could you use the same ones as in my screenshot (placeholder and title)?
I’m trying to promote the use of the term « widget » in the front
Lokkye
June 12, 2023, 11:44am
20
It’s true that widget is clearer than box. I’ve made the changes