Dadurch wird das Dropdown-Menü, das beim Klicken auf Ihren Namen zum Navigieren zu den Einstellungen geöffnet wird, geschlossen, wenn Sie außerhalb klicken.
Brisou
11. Dezember 2023 um 02:15
2
Je ne pense pas que ça avait été traité donc PR envoyé, voici le lien :
GladysAssistant:master ← jbrisavoine:user-dropdown-clickoutside
ouvert 02:12AM - 11 Dec 23 UTC
### Pull Request check-list
To ensure your Pull Request can be accepted as fa… st as possible, make sure to review and check all of these items:
- [ ] If your changes affects code, did your write the tests?
- [x] Are tests passing? (`npm test` on both front/server)
- [x] Is the linter passing? (`npm run eslint` on both front/server)
- [x] Did you run prettier? (`npm run prettier` on both front/server)
- [x] If you are adding a new features/services, did you run integration comparator? (`npm run compare-translations` on front)
- [ ] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community ([french forum](https://community.gladysassistant.com/)/[english forum](https://en-community.gladysassistant.com/)) for testing before merging.
- [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
- [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See [the GitHub repo](https://github.com/GladysAssistant/v4-website) and the [website](https://gladysassistant.com).
- [ ] Did you add fake requests data for the demo mode (`front/src/config/demo.js`) so that the demo website is working without a backend? (if needed) See [https://demo.gladysassistant.com](https://demo.gladysassistant.com).
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
### Description of change
Following the request: https://community.gladysassistant.com/t/menu-deroulant-de-licone-utilisateur/7942
Close the User dropdown Menu on external click (not only on the avatar).
Before:
https://github.com/GladysAssistant/Gladys/assets/138247436/59dbff9b-3f53-4c30-88ff-54196016af55
After:
https://github.com/GladysAssistant/Gladys/assets/138247436/b8bb2ab2-dac6-4973-9dec-436e90d4b213
https://github.com/GladysAssistant/Gladys/assets/138247436/7c8a27c0-a26a-4a07-bed6-16af30619854
Merci @Brisou je suis retombé sur ma demande ce week-ends, je l’avais oublié.
Brisou
11. Dezember 2023 um 09:11
4
Je t’en prie @Tlse-vins et je t’avoue, je suis tombé dessus par hasard aussi ce weekend
@Brisou Je ne sais pas si tu avais vu ma review de ta PR en décembre dernier ?
GladysAssistant:master ← jbrisavoine:user-dropdown-clickoutside
opened 02:12AM - 11 Dec 23 UTC
### Pull Request check-list
To ensure your Pull Request can be accepted as fa… st as possible, make sure to review and check all of these items:
- [ ] If your changes affects code, did your write the tests?
- [x] Are tests passing? (`npm test` on both front/server)
- [x] Is the linter passing? (`npm run eslint` on both front/server)
- [x] Did you run prettier? (`npm run prettier` on both front/server)
- [x] If you are adding a new features/services, did you run integration comparator? (`npm run compare-translations` on front)
- [ ] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community ([french forum](https://community.gladysassistant.com/)/[english forum](https://en-community.gladysassistant.com/)) for testing before merging.
- [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
- [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See [the GitHub repo](https://github.com/GladysAssistant/v4-website) and the [website](https://gladysassistant.com).
- [ ] Did you add fake requests data for the demo mode (`front/src/config/demo.js`) so that the demo website is working without a backend? (if needed) See [https://demo.gladysassistant.com](https://demo.gladysassistant.com).
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
### Description of change
Following the request: https://community.gladysassistant.com/t/menu-deroulant-de-licone-utilisateur/7942
Close the User dropdown Menu on external click (not only on the avatar).
Before:
https://github.com/GladysAssistant/Gladys/assets/138247436/59dbff9b-3f53-4c30-88ff-54196016af55
After:
https://github.com/GladysAssistant/Gladys/assets/138247436/b8bb2ab2-dac6-4973-9dec-436e90d4b213
https://github.com/GladysAssistant/Gladys/assets/138247436/7c8a27c0-a26a-4a07-bed6-16af30619854
N’hésite pas si tu as des questions
Brisou
15. Februar 2024 um 08:54
6
Hello,
Si j’ai vu, je m’en occupe, merci.
J’ai repris le sujet vu que j’ai pas eu de nouvelles depuis
Ma PR :
GladysAssistant:master ← GladysAssistant:close-profile-dropdown-when-clicking-outside
opened 04:17PM - 31 Jan 25 UTC
### Pull Request check-list
To ensure your Pull Request can be accepted as fa… st as possible, make sure to review and check all of these items:
- [x] If your changes affects code, did your write the tests?
- [x] Are tests passing? (`npm test` on both front/server)
- [x] Is the linter passing? (`npm run eslint` on both front/server)
- [x] Did you run prettier? (`npm run prettier` on both front/server)
- [x] If you are adding a new features/services, did you run integration comparator? (`npm run compare-translations` on front)
- [x] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community ([french forum](https://community.gladysassistant.com/)/[english forum](https://en-community.gladysassistant.com/)) for testing before merging.
### Description of change
https://community.gladysassistant.com/t/menu-deroulant-de-licone-utilisateur/7942
C’est mergé et ça partira dans la prochaine release de Gladys !
In Gladys Assistant 4.53.0 behoben:
Salut à tous,
Les améliorations UX continuent d’affluer dans cette nouvelle version !
