Dadurch wird das Dropdown-Menü, das beim Klicken auf Ihren Namen zum Navigieren zu den Einstellungen geöffnet wird, geschlossen, wenn Sie außerhalb klicken.
Brisou
11. Dezember 2023 um 02:15
2
Ich denke nicht, dass das behandelt wurde, also habe ich einen PR geschickt, hier ist der Link:
master ← jbrisavoine:user-dropdown-clickoutside
ouvert 02:12AM - 11 Dec 23 UTC
### Pull Request check-list
To ensure your Pull Request can be accepted as fa… st as possible, make sure to review and check all of these items:
- [ ] If your changes affects code, did your write the tests?
- [x] Are tests passing? (`npm test` on both front/server)
- [x] Is the linter passing? (`npm run eslint` on both front/server)
- [x] Did you run prettier? (`npm run prettier` on both front/server)
- [x] If you are adding a new features/services, did you run integration comparator? (`npm run compare-translations` on front)
- [ ] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community ([french forum](https://community.gladysassistant.com/)/[english forum](https://en-community.gladysassistant.com/)) for testing before merging.
- [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
- [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See [the GitHub repo](https://github.com/GladysAssistant/v4-website) and the [website](https://gladysassistant.com).
- [ ] Did you add fake requests data for the demo mode (`front/src/config/demo.js`) so that the demo website is working without a backend? (if needed) See [https://demo.gladysassistant.com](https://demo.gladysassistant.com).
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
### Description of change
Following the request: https://community.gladysassistant.com/t/menu-deroulant-de-licone-utilisateur/7942
Close the User dropdown Menu on external click (not only on the avatar).
Before:
https://github.com/GladysAssistant/Gladys/assets/138247436/59dbff9b-3f53-4c30-88ff-54196016af55
After:
https://github.com/GladysAssistant/Gladys/assets/138247436/b8bb2ab2-dac6-4973-9dec-436e90d4b213
https://github.com/GladysAssistant/Gladys/assets/138247436/7c8a27c0-a26a-4a07-bed6-16af30619854
Danke @Brisou , ich bin am Wochenende wieder auf meine Anfrage gestoßen, ich hatte sie vergessen.
Brisou
11. Dezember 2023 um 09:11
4
Gern geschehen @Tlse-vins und ich gebe zu, ich bin auch zufällig darauf gestoßen dieses Wochenende
@Brisou Hast du meine Review deiner PR im letzten Dezember gesehen?
master ← jbrisavoine:user-dropdown-clickoutside
ouvert 02:12AM - 11 Dec 23 UTC
### Pull Request check-list
To ensure your Pull Request can be accepted as fa… st as possible, make sure to review and check all of these items:
- [ ] If your changes affects code, did your write the tests?
- [x] Are tests passing? (`npm test` on both front/server)
- [x] Is the linter passing? (`npm run eslint` on both front/server)
- [x] Did you run prettier? (`npm run prettier` on both front/server)
- [x] If you are adding a new features/services, did you run integration comparator? (`npm run compare-translations` on front)
- [ ] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community ([french forum](https://community.gladysassistant.com/)/[english forum](https://en-community.gladysassistant.com/)) for testing before merging.
- [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
- [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See [the GitHub repo](https://github.com/GladysAssistant/v4-website) and the [website](https://gladysassistant.com).
- [ ] Did you add fake requests data for the demo mode (`front/src/config/demo.js`) so that the demo website is working without a backend? (if needed) See [https://demo.gladysassistant.com](https://demo.gladysassistant.com).
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
### Description of change
Following the request: https://community.gladysassistant.com/t/menu-deroulant-de-licone-utilisateur/7942
Close the User dropdown Menu on external click (not only on the avatar).
Before:
https://github.com/GladysAssistant/Gladys/assets/138247436/59dbff9b-3f53-4c30-88ff-54196016af55
After:
https://github.com/GladysAssistant/Gladys/assets/138247436/b8bb2ab2-dac6-4973-9dec-436e90d4b213
https://github.com/GladysAssistant/Gladys/assets/138247436/7c8a27c0-a26a-4a07-bed6-16af30619854
Zögere nicht, wenn du Fragen hast
Brisou
15. Februar 2024 um 08:54
6
Hallo,
Falls ich es gesehen habe, kümmere ich mich darum, danke.
Ich habe das Thema wieder aufgenommen, weil ich keine Neuigkeiten mehr hatte
Mein PR:
master ← close-profile-dropdown-when-clicking-outside
ouvert 04:17PM - 31 Jan 25 UTC
### Pull Request check-list
To ensure your Pull Request can be accepted as fa… st as possible, make sure to review and check all of these items:
- [x] If your changes affects code, did your write the tests?
- [x] Are tests passing? (`npm test` on both front/server)
- [x] Is the linter passing? (`npm run eslint` on both front/server)
- [x] Did you run prettier? (`npm run prettier` on both front/server)
- [x] If you are adding a new features/services, did you run integration comparator? (`npm run compare-translations` on front)
- [x] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community ([french forum](https://community.gladysassistant.com/)/[english forum](https://en-community.gladysassistant.com/)) for testing before merging.
### Description of change
https://community.gladysassistant.com/t/menu-deroulant-de-licone-utilisateur/7942
Alles klar bei mir auf dem Handy
Es ist gemerged und wird in der nächsten Gladys-Release veröffentlicht!
In Gladys Assistant 4.53.0 behoben:
Salut à tous,
Les améliorations UX continuent d’affluer dans cette nouvelle version !
