Excellent, do you think this can go to production as is, or do you think something needs to be added?
From a technical point of view regarding the scenarios I described the gap is filled: it is possible to retrieve the information of a device that communicates via MQTT without needing to implement adapters in Node-RED
Where I lack perspective is on the user experience: is it relevant to reserve these new fields for an « advanced » mode and keep the previous form as the default?
Finally I think it could be nice to have an auto mode for « external IDs » — personally what I did for the test is mqtt:\u003cpiéce\u003e:\u003cnom_appareil\u003e for the device and `mqtt:\u003cpiéce\u003e:\u003cappareil\u003e:\
Ok thanks for your feedback
I think it can stay there, they’re optional fields anyway!
Totally! I think that will be in a separate PR though
I just merged the PR on custom topics, so this feature will be included in the next version of Gladys
master ← mqtt-custom-topic
ouvert 09:49AM - 03 May 24 UTC
### Pull Request check-list
To ensure your Pull Request can be accepted as fa… st as possible, make sure to review and check all of these items:
- [x] If your changes affects code, did your write the tests?
- [x] Are tests passing? (`npm test` on both front/server)
- [x] Is the linter passing? (`npm run eslint` on both front/server)
- [x] Did you run prettier? (`npm run prettier` on both front/server)
- [x] If you are adding a new features/services, did you run integration comparator? (`npm run compare-translations` on front)
- [x] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community ([french forum](https://community.gladysassistant.com/)/[english forum](https://en-community.gladysassistant.com/)) for testing before merging.
- [x] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
- [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See [the GitHub repo](https://github.com/GladysAssistant/v4-website) and the [website](https://gladysassistant.com).
- [ ] Did you add fake requests data for the demo mode (`front/src/config/demo.js`) so that the demo website is working without a backend? (if needed) See [https://demo.gladysassistant.com](https://demo.gladysassistant.com).
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
### Description of change

3 Likes