Airtable ‹ en › and ‹ fr › updated (Airtable - Netatmo NATherm1).
However I don’t see how to integrate it into the documentation, since the documentation ID ‹ netatmo › doesn’t exist and I don’t see how to add it:
For info, I added to the Amazon links \u0026tag=gladproj-21. The redirect works but I’m not really sure the affiliation is being taken into account (‹ 21 › = year 2021? Do we have to change it every year?)
Thanks for the documentation! It’s very comprehensive and clean.
For the title, can you put a longer title that clearly explains what this tutorial allows you to do?
Example: Connect your Netatmo thermostats to your home automation system
This helps get found on Google for those kinds of keywords with a catchy title not tied to Gladys (do not mention Gladys in the title)
For the roadmap section, I’d suggest removing all dates — we never commit to dates on Gladys otherwise it just creates disappointment Priorities change, and it’s impossible to commit… Just put a list of things you want to do!
That’s kind, but there’s no need to add affiliate links, they are added automatically! And no, 21 is just a number generated once by Amazon a long time ago
Regarding the integration, how far along are you and who managed to test it in the end?
Hi @pierre-gilles !!
Welcome back, best wishes for 2024 to you.
Ok, I’ll make the changes for the doc ^^
For this I followed Sonos for the ending: « Connect your Netatmo thermostats to your connected home »
Sorry I understand the thread is very long to go through ^^
So as said above, the integration PR is ready,
I sent you a review request.
Tested by @_Will_71 (test with his thermostat) and by @Tlse-vins (test without compatible devices + tests with my instance with a thermostat). Apart from the display bug of the setpoint (not related to this PR) everything should be fine. Has been running on my setup for almost 3 weeks.
The advantage is that it can be tested by anyone; I just need to share my instance. If you’re up for it… tell me.
A quick question, which I initially asked you on the Netatmo integration pull request (PR), but I think you haven’t been paying attention to it:
After the release of v4.34.0 I updated the branch, but as often happens there was a failure on the Codecov report. In your live coding video, you answered my question about re-running the PR tests:
I’m a bit surprised, the PR doesn’t look at all like what I saw when I went to look at your code after the live coding… The code is quite far from what I show in the live coding, I think!
I’ve pointed out quite a few things to fix. Spend time on the PR and try to read through it entirely to apply these changes everywhere
In terms of code quantity, we’re back to a pretty large PR so I’m really glad we limited ourselves to the thermostat, it’s already a big chunk to review
Thank you very much for your review. I’ll get to it today. I’ll spend whatever time is needed.
It’s true, but does that seem normal to you because we’re not using an external module like for sonos, or do you think that’s really not normal? Otherwise, it might not be worth fixing, but rather rewriting the code entirely…
About the « netatmoHandler » passed everywhere… I suppose it’s a misunderstanding/configuration issue with my VS Code. The « this. » is reported as an eslint error everywhere in my VS Code interface, so I was passing the ‹ netatmoHandler › for that reason only.
Do we agree that it’s because we’re managing the whole code ourselves and not going through a node_module « netatmo »? Or for you is it related to bad code?
I’m asking these questions because I spend a lot of time on this (with pleasure, of course) but if it’s going to make you waste a lot of time and me too, we shouldn’t continue. If, however, with the fixes you point out and the time you spend we’re « sure » to succeed, then I’ll give everything
I’ve finished the requested changes (I’ve checked everything and reread your comments three times, I hope I didn’t forget anything, otherwise I’m really bad) and updated the tests; everything should be fixed.
As I mentioned in the PR, however, I don’t understand the issue you had
Blockquote On the functional side
When I first open the integration, here is what I see:
There is an error message immediately (I didn’t do anything), which is a bit weird for the user.
I tried to reproduce it but I can’t even reproduce your first connection error… Apparently none of the two testers encountered it and I’ve just retried with a new installation on WSL, I don’t have this problem…, my first-connection state:
Don’t hesitate to ask if you want access to view the devices live and to do real testing, it can be better, and it shouldn’t be complicated! I just tested with another email address, it works well even without owning Netatmo equipment.
Since I’m waiting on this PR, can I start a PR based on this first PR? Knowing that it won’t be wasted work, it will be easy to recover the work even if big changes are requested during the new review. But it allows me to stay involved and save time overall.
My question is mainly: for you, what impact? Will it be constraining or problematic once the first PR is merged?
Priorities change, and it’s impossible to commit… Just put a list of things you want to do!
— wouldn’t you need to grant some permissions so I can perform this action?
