18:00 is perfect. We’ll do it like this. I’ll let you call me through the means you prefer. We’ll set it up and if you want, we can review it together, or I’ll let you do it and we’ll catch up later ^^
I’ll send you a Google Meet link! See you later 
Hello !!
@pierre-gilles, following our call/review at the beginning of last week, I have almost finished the modifications/corrections to be made:
-
Netatmo Global View, correction of spelling and logic of menu terms as well as redundant icons
-
Settings View, Creation of a logout function as well as the associated command in the front-end
-
Settings View, Loading message during connection
-
Settings View, Clearly display whether Gladys is connected or not to the API: Message displayed permanently for one and the other case
-
Settings View, take back the « placeholder »
Object Objectof the fields to fill in the settings view -
Discovery View, add a message if nothing to display because not connected or if no information received or if not configured
-
Discovery View,
-
Dashboard View: in progress, detach the lines specific to Netatmo from the common boxes (Done). Signal and gray out the information returns that will later also be commands (comments in « title » added)
-
Dashboard View: Gray out and signal the lines when Netatmo is disconnected.
In Image
-
Dashboard View: take back the category/type that was
undefinedand modify the icons that were not clear enough.
Here, the service seems ready on our side. @pierre-gilles, what would be the next steps to be able to release this as soon as possible?
@Tlse-vins, would it be possible for you to do a new test this time with the docker image? docker pull damalgos/gladys-netatmo:netatmo
It’s clean what you’ve done!
Like everyone else, I need to find a bit of time to test.
But I’ll get back to you as soon as possible.
Great! I’m working on Gladys tomorrow, I’ll take a more technical look at the code if you want.
Next, ideally, we would need a few testers to get some « functional » feedback.
Once the technical review and testing are done, we can merge it
With great pleasure!!
More complicated. We have 2 fully tested installations. @Tlse-vins will test again as soon as he has some time, and @spenceur doesn’t have much time at the moment. So far, we haven’t found anyone else with a Netatmo…!!
Top
Thanks a lot for your answers
I was looking a bit this weekend between my work for the future baby’s room.
I will try to provide feedback as soon as possible if it can help you move forward.
Good luck 
, is this the first one?
Yes ^^
In itself, for now, it’s Madame who needs courage 
After that, for the rest, the CD will help me xD
You upvoted @VonOx, no discouragement here, right
Are you really sure about that? I remember the mood swings as if it were yesterday 
I’ll stop the off-topic…
You’ll see it changes your life 
In real life, I’m really lucky (it’s been 5 months and apart from these nausea, she hasn’t had any other changes [she already had a big personality 
but shh I didn’t say anything ])
:whistling…
All the best for you in the future
Hello everyone!
I did a review of the PR this morning. (My review)
Functionally, it’s cool as we saw @Terdious, it does the job. I didn’t put any remarks on that side.
However, in terms of code quality/the PR in general, I think there is a lot of cleaning work to be done before it can go to production
The Netatmo PR adds 12,900 lines of code, which is unprecedented and rather worrying In comparison, the MQTT PR was 1,000 lines of code all included, and it’s a great PR.
Just skimming through the PR diagonally to see what shocked me, it took me 2 hours ^^ I haven’t even read the code in detail yet.
What I retain:
- There is a lot of « dead » code/configuration that dates back to your early experiments, it needs to be removed. The NPM dependencies, we are very careful in Gladys to be as light as possible, and here there are many unused dependencies.
- The PR touches a lot of things, which is not normal. The PR should touch the Netatmo folder, the Netatmo front-end, and a bit of the dashboard components for the display, but not more. Here it touches the MQTT integration, some internal routes, which is not normal.
- There are eslint rules that are disabled in some files. Certainly, it puts the tests in green, but if there are eslint rules, it’s for a reason. You need to remove these eslint-disable and fix the code.
I think with all my comments you have enough to clear the PR and reduce its size
In any case, thank you again @Terdious and @damalgos for the work done. I give these remarks to improve the quality of the PR and to have a light, performant, and maintainable service in the future. Don’t take these remarks personally, it’s to ensure the quality of Gladys’s code
Hello,
I’ll take a look at it. Indeed, many libraries will be removed, we forgot to remove them, that’s true.
Thank you for the review, I’ll check it out
Hello, I’m taking a few minutes to test:
I ran the following command on my machine:
docker run -d \
--log-opt max-size=10m \
--restart=always \
--privileged \
--network=host \
--name gladys-netatmo \
-e NODE_ENV=production \
-e SERVER_PORT=1080 \
-e TZ=Europe/Paris \
-e SQLITE_FILE_PATH=/var/lib/gladysassistant/gladys-netatmo.db \
-v /var/run/docker.sock:/var/run/docker.sock \
-v /var/lib/gladysassistant:/var/lib/gladysassistant \
-v /dev:/dev \
-v /run/udev:/run/udev:ro damalgos/gladys-netatmo:latest
I see the listening port on 1080 but I don’t think I’m accessing gladys when I type: localhost:1080
Any ideas?
Hello, run a docker ps to list the containers
Doesn’t Kitematic give you the access URL?