nope ^^
to know that I never used gladys 4
Kinematic is no longer supported by Docker. There must be a network communication issue (since Gladys is running properly)
https://docs.docker.com/kitematic/
You need Docker Desktop on Windows
Try 127.0.0.1:1080 to see
I don’t know enough (not at all even) about MacOS to help you more.
If it doesn’t work, try on your Mac’s IP
Yes I first tried to contact the IP of my Mac or 127.0.0.1 ![]()
Too bad, I’ll try another time or not
.
Thanks gentlemen.
Hello, on Mac, the network=host option does not work (since Docker runs in a VM).
The best option is to force port exposure on your local machine by adding the -p 1080:1080 option
https://medium.com/@lailadahi/getting-around-dockers-host-network-limitation-on-mac-9e4e6bfee44b
Oh, I had forgotten that detail. Thanks @cicoub13.
After that, it didn’t change anything ![]()
docker run -d --log-opt max-size=10m --restart=always --privileged --network=host --name gladys-netatmo -e NODE_ENV=production -p 1080:1080 -e SERVER_PORT=1080 -e TZ=Europe/Paris -e SQLITE_FILE_PATH=/var/lib/gladysassistant/gladys-netatmo.db -v /var/run/docker.sock:/var/run/docker.sock -v /var/lib/gladysassistant:/var/lib/gladysassistant -v /dev:/dev -v /run/udev:/run/udev:ro damalgos/gladys-netatmo:latest
Excuse me, I was not very clear in my previous message. We need to remove the network=host mode and add the port. Which gives me:
docker run -d --log-opt max-size=10m --restart=always --privileged --name gladys-netatmo -e NODE_ENV=production -p 1080:1080 -e SERVER_PORT=1080 -e TZ=Europe/Paris -e SQLITE_FILE_PATH=/var/lib/gladysassistant/gladys-netatmo.db -v /var/run/docker.sock:/var/run/docker.sock -v /var/lib/gladysassistant:/var/lib/gladysassistant -v /dev:/dev -v /run/udev:/run/udev:ro damalgos/gladys-netatmo:latest
It did indeed solve my issue, thank you @cicoub13!
Here is my feedback, I can retrieve my thermostat and the linked valves as you can see:
All of this is great.
However,
- I don’t understand why we can’t modify the Setpoint mode from Gladys.
- The scheduling part is still not taken into account?
- After entering my information in the settings, I didn’t know if I should click on « Save » first or on « Connection ».
When we arrive in the Netatmo integration, we arrive on this poor page, which is quite empty and without any real explanation or redirection to the documentation:
When I go to settings, the placeholder is incorrect, you send the object and not the string:
Apart from that, I have nothing to say about your integration
.
@pierre-gilles, however, for Gladys, I’m struggling with this dashboard which, I find, is lifeless (very white and bland) whereas when we add a device in an integration, we have colors (just the battery in the top right I find it pretty). I think there is still work to be done on this side to make this dashboard more attractive and pleasant.
I wish you all a very good evening
.
Hello ![]()
First of all, thank you for your feedback!
That’s great already ![]()
Because it hasn’t been implemented yet, similarly for the schedule. The issue is rather that we want to do something generic for all heating solutions. Indeed, it’s « easy » to do quickly as we could have done for V3, but here we want to do it very cleanly so that any other integration uses the same logic ![]()
Well, yes, it’s true, not necessarily logical, I thought I had removed a button to tell you the truth! We’ll look into removing that ![]()
Very good idea, well seen ![]()
Ah, same, I thought it was good, thank you ![]()
In any case, thank you for your feedback, it’s perfect ![]()
Oh, it seems you have a small issue on your side, @spenceur. Apparently, you don’t have the latest version ![]()
You should use the latest version of Docker ![]()
Oh!
Could you put the command like this so I can do a quick copy-paste in my terminal and I’ll try to get back to you ASAP
Hello just for info, how is your module going? ![]()
Hello @spenceur,
We were supposed to resume work on this last week following last month’s review. However, some issues on my end have delayed things.
Additionally, this weekend, all my MQTT home automation went haywire… I can’t find the problem, but I will resume work on Netatmo tomorrow regardless. We’ll keep you updated.
Good luck with your troubles, I hope it’s not too serious!
Hello!!
Well, with a lot of delay, thank you very much for the review @pierre-gilles.
It was a real pleasure to work on this PR. A lot of things learned. Of course, none of your remarks were taken personally and we know it’s constructive. It touches on a global project and all this is very important for the functioning and future of Gladys. Now following this feedback, I took the time to read everything again. And indeed, it’s a big mess.
On the one hand, it is clear that there is a lack of knowledge on my part of the coders’ world, I think that on this point, you will have to help me with the next reviews.
And on the other hand, I think that at certain stages, some strange things happened (mixing of PR or others) because there are pieces of code that we never even touched.
All this to say that, as seen with @damalgos (it’s his project at the base the dev of this service), the best is to start from scratch and to take it step by step by only outputting for the moment for a first PR the strict necessary (I will put aside the cameras for this first one which is a big piece in itself).
For the record, @pierre-gilles, @AlexTrovato, @VonOx or any other coder who has already done this operation, what would be the best method for you to do this? Is it possible for me, to start from one of my clean repos, to rebuild, and to send everything back to the PR of @damalgos? What will be the visual impact of the changes for the review (to see the modifications in particular)?
Thanks in advance and I will now take this back quickly trying not to lose too much time.
Thanks for taking the time to look at my feedback! ![]()
It’s okay, we all go through that. The main thing is not to get discouraged and to keep moving forward
If you knew how many PRs, after my feedback, the contributor disappears and never comes back (probably out of laziness
) That’s where you see the persevering people ![]()
Good approach in my opinion
If I were you, I would create a new branch from the current master Gladys, and I would gradually add the netatmo back and front, making sure to only add content in the « netatmo » front/back folder. This will allow having a concise PR that only touches netatmo, without side effects on the rest of Gladys. Really try to think of a minimal PR, but that does everything well. The motto of v4 is really « we don’t necessarily do everything from the start, but what we do, we do it well ».
If you have additions for Gladys « core », I would advise you to make very concise separate PRs, look at the PRs of @AlexTrovato or @VonOx on Gladys, it’s precise it touches 2-3 files, nothing more, and for me to merge it’s much simpler. I see right away the features developed and the tests that go with it in the same PR, I don’t have to review 200 files trying to understand which file goes with what.
Also, to talk about code quality, @AlexTrovato has worked a lot on frontend tests with Cypress recently. I will merge that soon, and so I think it would be a plus if you developed this integration with UI tests. This will allow verifying that your PR works well over time. I think we’ll make a post asap to summarize with the Gladys developers how to develop with Cypress.
Thanks for your feedback, we’re going with that then!!
Yes, the last 3 months have been a bit complicated, but in this case it gave me time to read and follow the entire forum and the PRs. I’ve followed all that and indeed it’s much cleaner. I understand the meaning of the small modifications and in the end it’s much faster than what we think to arrive with a big piece, all the more so when we are not professional developers, there are inevitably « wolves » that become very quickly hard to catch up and as you say discouraging as we see the time spent (same for everyone ^^)
On my side, I remain highly motivated and knowing that summer is coming and that I will be quite busy with outdoor activities, I want to take advantage of the remaining time.
Regarding Cypress, yes I had followed the subject and felt it coming, hence my request to @AlexTrovato to organize a call on the subject. After very clearly it scares me, it’s really a new world to learn (for me) but we’re going to try it, I would say if I feel incapable.
In short, let’s get to work, we’ll see what happens!!^^
I think that before making a call, we will merge this, then write a written tutorial, let everyone look on their side, then after that, we will make a call to answer questions ![]()
After that, it’s really not complicated once you understand the principle, it’s even quite satisfying to see the « robot » Cypress quickly browse your UI to test all the behaviors, it’s almost faster than testing yourself.
Hello!!
I’ve been working on the Netatmo service development since the day before yesterday, as discussed, starting from scratch with version 4.3.0 and on a new PR for clarity. I think I’ve finished the server part. All my tests work well locally, but the test crashes on GitHub, apparently due to « JavaScript heap out of memory »:
I thought I had increased this limit in the previous PR of @damalgos, and it worked fine. But since the goal is to start from scratch, I’m asking for your wise advice. Testing different types of cameras (working with ffmpeg) is quite long (more than 300ms), and I don’t see how to reduce this time.
If you could take a look, the test is here and the PR#1175 is here
Thanks in advance!!







