bab85
December 19, 2023, 7:53pm
1
Follow-up to the thread Amélioration des tags :
Good evening everyone,
Following up on the quotes above, I noticed that a tag that is only assigned to scenes that are disabled is deleted.
Is this intentional or accidental?
As I’m still in the learning and testing phase, I have equipment that is used in several scenes, so I regularly enable or disable scenes. But if a tag is no longer present on an active scene, it is deleted. I understand that in steady operation this problem probably doesn’t arise, so if it’s intentional, I’ll live with it (we didn’t have access to the tag until recently ), but if this happens like that without any further reason, I’d submit a feature request .
Psoy
December 20, 2023, 6:55am
2
hello @bab85
Yes, this bug has already been reported, it’s being discussed here:
pour les dev
quelques remarques
[image]
Il faudrait un petit texte pour préciser qu’il faut taper le nom du tag dans la zone « Select » ou remplacer « Select » par quelque chose comme « Entrez le nom du tag ici » car pas évident à trouver la première fois
Un petit bug
j’ai mes scènes
[image]
j’actives les tags
[image]
je coche le filtrage se fait bien
[image]
je décoche mais les scènes ne réapparaissent pas
[image]
il faut cliquer sur plans puis à nouveau sur Scènes p…
But I thought it was fixed with version 4.32
bab85
December 20, 2023, 8:04am
3
Hello @Psoy
Indeed I hadn’t noticed that it had already been mentioned (in fact, in the discussion thread, I hadn’t understood that the tag had been removed).
However, I’m on v4.33 and I can confirm that this behavior is still present.
Yes, it’s intentional A tag only exists in a scene, so if no scene has that tag, it doesn’t exist
bab85
January 6, 2024, 11:05am
5
My best wishes to everyone for this new year.
@pierre-gilles my disappearing tags are indeed associated with scenes, but those scenes are disabled.
Yes indeed, same for me today… that’s not the intended behavior. We’ll see!
Ok, in that case I’d like someone to create a GitHub issue to keep a record of the bug
Hi @pierre-gilles ,
I replied to you, you obviously forgot that the topic has already been raised twice. I had, however, included the reference to that discussion in the issue:
ouvert 01:02PM - 08 Jan 24 UTC
fermé 06:25PM - 19 Apr 24 UTC
Related to the subject: [Add any other context about the problem here.](https://… community.gladysassistant.com/t/suppression-des-tags-des-scenes-desactivees/8642)
**Describe the bug**
When all scenes of a tag are only disabled, the tag is deleted as if no scene contained this tag anymore even though it is just disabled
**To Reproduce**
Steps to reproduce the behavior:
- Go to scenes
- Create a “Test tag scene deactivated” scene
- Add a “Disabled Scenes” tag
- Save and return to the Scenes list menu
- Select the new tag "Deactivated scenes" to find the newly created scene
- Disable scene
- Refresh the page
- Search again for the “Disabled Scenes” tag => It no longer exists
**Expected behavior**
The tag should always exist when at least one scene, disabled or not, has this tag.
Ah sorry, I read a bit too quickly, it’s indeed a bug in that case
1 Like
I looked at this bug, it’s really trivial!
It’s fixed here:
master ← fix-tags-bug
ouvert 06:17PM - 19 Apr 24 UTC
### Pull Request check-list
To ensure your Pull Request can be accepted as fa… st as possible, make sure to review and check all of these items:
- [x] If your changes affects code, did your write the tests?
- [x] Are tests passing? (`npm test` on both front/server)
- [x] Is the linter passing? (`npm run eslint` on both front/server)
- [x] Did you run prettier? (`npm run prettier` on both front/server)
- [x] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community ([french forum](https://community.gladysassistant.com/)/[english forum](https://en-community.gladysassistant.com/)) for testing before merging.
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
### Description of change
Fix https://github.com/GladysAssistant/Gladys/issues/2000
2 Likes