Hi @cicoub13, thanks for the PR! ![]()
@mutmut not exactly
Cyril is proposing a PR, then it needs to be reviewed/tested, and if it’s good it can go to production. We avoid deploying changes without making sure they’re good beforehand!
@pascal_sapin to be sure, I’ll describe what Cyril’s PR does.
It creates 7 new features in the Zigbee2mqtt integration based on the attributes you showed us in this screenshot:
Can you confirm that these new features are correct?
- current_a: Feature « Current » in unit « Ampere »
- current_b : Feature « Current » in unit « Ampere »
- energy_a: Feature « Energy » in unit « Kilowatt-hour »
- energy_b: Feature « Energy » in unit « Kilowatt-hour »
- power_a: Feature « power » in unit « Watt »
- power_b : Feature « power » in unit « Watt »
- power_ab : Feature « power » in unit « Watt »
Since these are features that already exist in Gladys, there’s no need to run a test. If it looks good to you, I’ll merge ![]()
Thanks for the development work, and thanks for your feedback!
