mikael
February 18, 2022, 11:19am
1
When you retrieve the « retrieve the last status » variable for more than 10 device data items from a previous block, only the first 10 are displayed when selected in the « send a message » action.
Moreover, if you try to put others in another subsequent block (and therefore preceding the « send a message » action), you can only see them if you enter the block number.
For this bug, you could create a GitHub issue: Issues · GladysAssistant/Gladys · GitHub ? Thanks
We’ll keep the topic on the forum here for discussion, but for bug tracking, I prefer GitHub!
mikael
February 18, 2022, 11:59am
3
I was sure I would have to do it.
here is the link (I also put the link to this post in the GitHub issue)
I found the bug and fixed it in this PR:
master ← fix-variable-limit-in-scene-message
ouvert 02:40PM - 18 Feb 22 UTC
### Pull Request check-list
To ensure your Pull Request can be accepted as fa… st as possible, make sure to review and check all of these items:
- [ ] If your changes affects code, did your write the tests?
- [x] Are tests passing? (`npm test` on both front/server)
- [x] Is the linter passing? (`npm run eslint` on both front/server)
- [x] Did you run prettier? (`npm run prettier` on both front/server)
- [ ] If you are adding a new features/services, did you run integration comparator? (`npm run compare-translations` on front)
- [ ] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to [the community](https://community.gladysassistant.com/) for testing before merging.
- [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
- [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See [the GitHub repo](https://github.com/GladysAssistant/v4-website) and the [website](https://gladysassistant.com).
- [ ] Did you add fake requests data for the demo mode (`front/src/config/demo.js`) so that the demo website is working without a backend? (if needed) See [https://demo.gladysassistant.com](https://demo.gladysassistant.com).
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
### Description of change
Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!
It’s merged on master, the fastest fix in history
Fixed in Gladys Assistant 4.8:
Hello à tous,
Suite au live, je suis heureux de lancer Gladys Assistant 4.8 officiellement
