Evolution of the Z-Wave JS UI service

Development
1

Hi @Sescandell :slight_smile:

I’ve created this thread to discuss the development of the Z-Wave JS UI service and your PR!

First, thanks for taking this on — what you’ve done is really great.

I’ve left an initial review:

1 Like
2

On my end I tested the PR in real life and it detects devices I have and I can control them in Gladys.

1 Like
3

@Sescandell I just saw that you updated your PR, thanks for the fixes! :slight_smile:

Remember to drop me a quick message here next time, otherwise I won’t know there were changes on GitHub!

I’ve restarted the tests!

@_Will_71 Can you re-test after @Sescandell’s latest changes? :wink: you’ll need to re-create the Z-Wave devices though

1 Like
4

I didn’t mean to be intrusive with the GitHub notifications, the notifications here, all that, all that.

I’ll remember :+1:

1 Like
5

Yes, no problem — I’ll retest over the weekend.

1 Like
6

@Sescandell on the contrary, don’t hesitate :slight_smile:

On GitHub it’s not convenient, every commit generates a notification so the notifications section of my account is unusable (I have thousands of notifications in it :sweat_smile:)

So I prefer the forum to let me know it’s ready! However, once you tell me I’ll check the GitHub messages without any problem

7

I’ve reverted the package-lock.json file for the usb service. Let me know.

8

I retested but things have changed on my side.
The devices are still recognized, but those that were managed by Gladys are no longer recognized.

I’ll try to look into why when I have 5 minutes.

9

It’s normal, the first PR from @Sescandell modified the external_id, I asked him in the revert PR to undo that change and revert to the external_id currently in production.

So if you had already created the Z-Wave devices in your first test, you need to delete them and then recreate them (I requested the change precisely so that the issue you had wouldn’t affect users in production :smiley: no breaking change)

10

I didn’t start from the same installation, so my sensors weren’t created in Gladys.

11

Ah ok, indeed in that case there’s an issue :slight_smile:

12

Hello

Could you provide more info please: device types, logs, what’s not working? etc.

Thanks,

1 Like
13

I’ll try to give you more info later — right now I’m traveling a lot for work so I don’t have much time.
All I can tell you for now is that in your first image I had devices that were recognized (well, only some) ON/OFF switches. I had the status reported in Gladys and I could control them from Gladys.

With the latest change this no longer works: the devices are displayed but with the message that they are not yet managed by Gladys.

No specific logs.

The devices are from the brand Qubino.
I could connect to zwavejs ui tonight to give you more details about the devices.

2 Likes
14

Okay, I made a mistake when I cloned your repo because I no longer have the binary switch handling in the code.
So of course it doesn’t work.

So I confirm that now it’s fine — my devices (binary switch) are working!

1 Like
15

I just did the review on my side, and I tested it for real with my Fibaro door contact sensor: it works perfectly :ok_hand: (Review)

Great job :clap::clap:

I’ve

1 Like
16

I’m not sure about the procedure for the documentation.

I did something, don’t hesitate to tell me if I made a mistake.

1 Like
17

This is a Docusaurus repo (a documentation tool based on Node.js)

You have the instructions in the README to set up an environment!

Don’t hesitate if you want some help :slight_smile:

18

@Sescandell Thanks for the PR on the docs side :slight_smile:

I merged the PR on the Gladys side, it will be included in the next Gladys release! (Probably next week)

3 Likes
19

Let’s get started on a new PR then :slight_smile:

I saw that the door/window sensor has a built-in temperature sensor. I’ll start with that!

2 Likes
20

Excellent, happy to do a new PR!

Don’t hesitate to ask if you need help or any materials :slight_smile:

2 Likes