Hello, I am taking the liberty of creating a specific topic to stop polluting the topic « Gladys 4 Beta is available ».
Is it possible to move the discussions that took place there here @pierre-gilles?
Some small views of the fr translation:
Dashboard View - Edit
I haven’t yet recovered the modifications from @AlexTrovato for the hardcoded text part…
Integrations View - Z-Wave - Setup
I have some doubts about the translation of « Heal » to « Régler »
Well, I’ll stop there for now on the « Integrations » side, I’m not going to show you all of them ^^
No Scene - Edit Scene view for now as we are in progress on the maps view and we have broken the link ^^
Yes! Thanks for this great work @pierre-gilles! Despite the limited testing I’ve done so far, I haven’t found any bugs or issues. And even if it was just « virtual » tests for the AND/OR conditions, it’s really great to finally have this feature.
Yes indeed, sorry, I realized this after my comment!!^^
I wanted to work on the FR translation this week. But I can’t find anyone working on it on the git. Do you know, @pierre-gilles? If not, I would also like to test the front end to check the dimensions. Is there a simple way to activate FR on the production or do I replace the EN file?
Thanks in advance.
Top! Glad you like it, I spent a lot of time on this feature, and it wasn’t easy!!
No one is working on it!
Replace the file in / or replace where it is imported in the app (do a search in the folder), that will be the easiest for now I haven’t coded anything for the switch to work!
Okay! Perfect. I’m at 200 translations out of 720. I need to pull the file on the git or I can do it once finished (I’m not yet comfortable with GitHub - I have no idea how to do it for the moment… ^^).
One question though:
-
For the
devices, I translated it asappareils, does that work for you? -
For the
features, what translation would you prefer? Or do we leavefeatures? Otherwisecaractéristiques?
Peripherals rather?
Features / characteristics, it’s hard to say without the context!
Hehe! I was translating it as « devices » in v3, and I don’t know why, but I saw « appareils » the other day and thought it might be better as it’s shorter and perhaps more commonly used by non-tech-savvy users. But I’m fine with « peripherals » too ^^
Not wrong. That’s why I was considering keeping the term « Features »! I’ll go with « Features » for now, we can just do a mass replace or find/replace if needed.
Personally, I lean more towards devices; peripherals sound too technical, not user-friendly enough.
I agree with you @AlexTrovato. And after testing, peripherals doesn’t fit in the various search bars. Well, I’ll switch everything back to devices, I’ll keep the other file in case you want to test it.
I just finished the front translations. So I realize that in some places, the texts must be hardcoded and do not go through the file (for example, the Dashboard view for the title, the edit button and the buttons of the edit view - also for the texts of the images of the Integration view - finally on the settings view - I continue to check tonight.)
For hardcoded texts, I did a pass, see the PR Add French translation + i18n checker by atrovato · Pull Request #644 · GladysAssistant/Gladys · GitHub
Ok !!
Sorry, these are my first steps in sharing projects in the community. So, we agree that I don’t touch anything on that side, but how can I retrieve your PR to test the translations? Is it possible to retrieve only the modified files during a « git pull »?
We agree that you haven’t done the translations but replaced the hardcoded texts with variables?
Thanks in advance for your answers.
Otherwise, I found it for that, it’s in a separate json, I hadn’t noticed.
In the end, I agree, « Appareil » is probably more concise and clearer for a beginner 
Yes, it’s me who forgot some translations here and there…^^
Ah great!
You can indeed pull from his branch (you have the instructions at the bottom of his PR, GitHub gives you the command lines you just have to copy and paste!)
It’s done @Terdious 
1 Like
@Terdious where are the FR translations? I don’t see your pull request on GitHub.
I can integrate them into my PR, I’ve added a « translation analyzer » to check if everything is translated and that there is no hard-coded text in the code.
Thank you very much @VonOx.
Hello @AlexTrovato,
I left you a comment on github here
I installed your fork yesterday, and transferred my file to it. So I started from scratch and found some hardcoded text:
- https://github.com/atrovato/Gladys/blob/compare-translation-files/front/src/routes/signup/layout.jsx: lines 34, 46, 58, 70 and 82.
- I will continue today or tomorrow.
I also asked you if you wanted me to handle the modifications to be made or if I gave you as I go what I found. The question arises as to how to transfer the files to you afterwards (en.json, fr.json + all the en/fr files of the integrations). We were talking about it yesterday with Pierre-Gilles, it’s maybe a shame to make a fork of a fork for so little.
Let me know what you prefer.
Hi @Terdious, I knew I had seen a comment somewhere about this, but I couldn’t remember where! Thanks.
So if you send me your file, I’ll integrate it into my PR, run the tests, and fix the hardcoded words you found, that’s fine with me.
I’ll send you the test results so you can complete the file
Ok, that works for me, so how do you want me to send it to you once completed?
I saw on the issue that you had another go at it, so I’ll complete the missing elements during the day.
That works for me ^^
Okay, I think I saw it, I can directly send you the file on the issue via Git apparently…^^
You can send me this first version as a private message here, I will reply with the analysis results in private as well to avoid cluttering this discussion thread.
@Terdious, proofreading in progress, I’ll keep you updated
I have a few suggestions that are more « semantic » than pure translation:
The image we want to give of Gladys is « home assistant ». She even has a name… so okay, maximum personification, which is 100% in line with the user-friendly aspect sought.
Therefore, for me, in the « Best Practices », we should:
- Abandon « Gladys instance », « this software » for « Gladys »
- Or even better: use the first person everywhere.
On the home page at the beginning, it’s Gladys who speaks to us: "« First of all, thank you for choosing me. I am Gladys, a home assistant… ». Harmonizing this and keeping this « I » would therefore be more homogeneous and nice.
"« We are unable to get the weather for this house. » → I am unable to get…
Let me know what you think (@pierre-gilles ?)
Progress: line 440