Hello
a silly thing
in this list it’s missing the item — it doesn’t include what would allow activating the heating in eco mode when it’s not necessary, for example
thanks
Hello
a silly thing
in this list it’s missing the item — it doesn’t include what would allow activating the heating in eco mode when it’s not necessary, for example
thanks
I’m coming back to this
Because I don’t know what to do about my heating: I would like a minimum temperature of 16 degrees, but with the scene system that doesn’t have an « else » I don’t see how to do it
I managed to make a neat setup so that the heating is activated from the calendar, but without that condition I’m forced to make the calendar fully filled even though it’s only when there’s nothing
Hi!
At my place, the heating is managed by Gladys.
For the minimum temperature, it’s a simple scene that activates if the temperature is below 17°C with no condition (well, actually I have a ‹ frost protection › mode).
To turn off the boiler, I switch it off if it’s 18°C or more and we’re not in comfort mode.
Trigger: temperature >18°C
Get last state of the heating mode
Continue only if different from comfort mode
Turn off the heating.
All the details are here, in the ‹ Programming › section:
https://community.gladysassistant.com/t/tutoriel-maj-thermostat-fait-maison-et-integration-programmation-dans-gladys
I’ll look tomorrow with a clear head
thanks
I implemented something along those lines
There is a test image if you want to verify the functionality cicoub13/gladys:feat-calendar-does-not-contain
If multiple events occur at the time of the scene, it’s enough that one event does not contain the searched word for the scene to continue.
I didn’t add this option to the trigger (it makes much less sense to me).
So I won’t be able to test because last time
I had to redo everything when I tested an image
I need to set up a second test machine for that
Sorry
Thanks for the PR @cicoub13 ![]()
Quick question, why make that choice and not the opposite?
Wouldn’t we actually want all current events to not contain the word?
That seems more logical for the possible uses of this new option but I could be wrong ![]()
Indeed, don’t put your production at risk for that kind of test ![]()
It makes more sense to me for it to be all events that don’t contain…
Okay, I’ve turned the question inside out and it seems more logical as you say ![]()
Imaginary scenario
Let’s imagine I want not to heat my home when it’s a Tempo Red day — I’m going to set up a scene that heats every day with the following action
Everything works perfectly; on blue/white days, the scene continues because « an event that does not contain red was found ».
On a red day, the scene stops because « no event that does not contain red was found » ![]()
Now, if I add a morning appointment in my « RDV docteur » calendar, the expected behavior is that the scene still stops.
But then
Cool! Can I review your PR then?
For that I would recommend creating a specific calendar, rather than mixing it with other events that could interfere.
PS: Reminder that for Tempo EDF we already have native scene conditions ![]()
No, I haven’t made the changes yet. It kind of breaks the functionality just for this condition. I’m working on it.
It’s coded, tested and pushed but it’s really a strange way of thinking (backwards, I’d say).
I’m afraid a few people will use this feature but be surprised by the result ![]()
I thought you were convinced? ![]()
I left you a review:
It’s fixed. Let me know if you need anything.
Review completed!
Okay, I reviewed my code this morning with a fresh mind and it’s cleaner
Would welcome your feedback
Thanks! As for the findCurrentlyRunningEvent function, it seems much better to me ![]()
I have two small comments otherwise
Taken into account
Thanks for the feedback, I think it’s cool! But it’s really a feature that ties your brain in knots ![]()
For info, the final version looks like this :
Shouldn’t we do a real test of this feature before pushing to prod? Or at least someone who gives us their precise use case and we test it?
@Prof_Techno on your side, what’s the case? What does your calendar look like?
I’m fine with waiting for a real case. I admit I jumped into the code too quickly before fully understanding the requirement (not good)