Same here ^^
Indeed, it’s the same for me, but I prefer that state, because to me it’s more consistent to have the icon crossed out when the door or window is closed. When my Xiaomi contact sensors were managed by the Xiaomi integration, they appeared as above, but when I switched to the Zigbee integration they ended up reversed. I think in Zigbee2MQTT they were configured the other way around.
Ahhh I’m going to get scolded!!!
Are you sure about your move?
I admit that the « slashed shield » icon isn’t exactly clear to me.
But I may have swapped 0/1 false/true.
This ambiguous icon — we’re talking about it here just in case
Hmmm
So I see that if the contact is made, then we have « true » as the value, but Gladys doesn’t talk about « contact » but « opening ».
The notions are therefore reversed.
Contact sensor = checks that it’s closed
Open sensor = checks that it’s open…
Darn. I didn’t see that.
3 Likes
Good evening @ Alex Trovato
At the risk of being booed, seeing the icon crossed out when the door or window is closed is more intuitive (notion of a barrier). Moreover, leaving it like this brings us back to the same logic as the Xiaomi integration. Indeed, showing open or closed would solve the problem. 
It’s true that these icons aren’t very clear; to me it made more sense the other way around, but that could be a long debate I think 
Also, you really need to be sure about the returned value, because if we leave it like this I’ll have to redo all my scenes where I take these sensors into account
!!!
Aha don’t worry it happens, and besides it’s actually a good opportunity to change those not very clear icons, we could switch to a closed / open padlock?
Open:
Closed:
6 Likes
I agree with these icons,
When seeing an open or closed padlock, we have fewer questions, I think
2 Likes
[quote=« _Will_71, post:79, topic:6846 »]
So I’m not sure that @l
FYI, @AlexTrovato made a PR to fix the inverted behavior on the door open sensors!
Since he can’t test it, I’d welcome real-world feedback on this PR! I asked him to make a Docker build for you, which he will post here.
I know
2 Likes
I would test tonight.
Image currently being built.
atrovato/gladys:zigbee2mqtt
It will be available tonight 
3 Likes
@pierre-gilles, @AlexTrovato
I just tested and my open/close sensors have returned to how they were and my scenes are working again! 
Here is an image with my windows/doors closed.
3 Likes
I just merged the PR 
Thanks @AlexTrovato for the fix and @_Will_71 for the tests
1 Like
Patch deployed to production!
3 Likes
I confirm that it’s working again! Thanks @AlexTrovato
So it seems better but I still have the old icons, is that normal ?
I’m referring to this message (I haven’t checked whether this was part of the merge request)
Yes, that’s normal, the fix wasn’t in the frontend as I thought but in the Zigbee2mqtt service. Alex’s PR (pull request) was only there to fix this bug as quickly as possible My comment was just a suggestion.
2 Likes
Last night I started explaining how Gladys works to my partner, with the different tabs I’ve set up, …
I showed her the tab about the open/closed status of windows and doors, explaining the meaning of the shield.
Her immediate reaction: « Wouldn’t an open or closed padlock be better?? Isn’t that more logical? »
I told her that there was some thought being given to this subject.
6 Likes