Afficher l'heure sur le dashboard

[pierre-gilles]

@Lokkye le design de @VonOx est bien mieux pour l’affichage numérique.

Pour l’affichage analogique, pourquoi pas, à voir comment ça rend une fois que tu l’as stylisé, il faut que ça s’intègre bien au reste du dashboard. Je pense par exemple aux couleurs, là le noir et le rouge sont très puissant (c’est un #00000 probablement), il faudra intégrer les couleurs du thème pour que ça se fonde bien dans le thème.

A voir aussi pour que la box ne soit pas trop vide, la date peut servir pour remplir à gauche, exemple:

(Je parle juste de placement hein, pas la couleur )

[VonOx]

@pierre-gilles

Je parle juste de placement hein, pas la couleur

J’aime bien moi

[Lokkye]

Here’s what it looks like with the correct colors and the date :

What do you think ?

[VonOx]

Nice, I like it

[Tlse-vins]

Nice !! It’s clean.

[jerome]

I confirm — if we could have this in the next updates, that would be great!

[pierre-gilles]

[quote="Lokkye, post:

[Lokkye]

@pierre-gilles

Very neat There may be some small finishing touches to do on the placement and size of the date on the left, but otherwise I like it, it’s super clean.

Don’t hesitate to give feedback, I know I’m not very good at design and graphics

@pierre-gilles

Where does the clock come from? It’s not a 200KB lib I hope?

The clock comes from the library: https://www.npmjs.com/package/react-clock
It only weighs 67 kB

[guim31]

Very nice!! I like it

[Psoy]

Good evening
That works for me too, great, thanks

[pierre-gilles]

Hi @Lokkye!

I saw that you updated your PR — do you need a new review?

[Noj]

I was just about to ask if we could have the time on the dashboard.
So I’m looking forward to seeing how it’s going to turn out.

[Lokkye]

Yes, I’m still up for a review

[pierre-gilles]

Review done, the PR is really good for me apart from just one design feedback

The PR was developed in May when the month was a short month name, but now we’re in December,

[Lokkye]

Thank you very much for the review

I’ve reduced the date text size because I hadn’t planned for the « large » dates.

I also made the changes for the unnecessary constants in the backend.

[pierre-gilles]

Great!

Everything’s good for me on the code side, but I noticed something when the digital clock is displayed with seconds: there’s a kind of « glitch » every second because the font being used isn’t monospace (each character doesn’t have a fixed width)

It’s really a small thing but I think it will drive some people crazy aha:

It would be cool to find a monospace font so that this shifting doesn’t happen

I’ll check the theme to see if there’s one…

[pierre-gilles]

I find this in the theme:

--font-family-monospace: Monaco, Consolas, "Liberation Mono", "Courier New",
    monospace;

I’ll do some tests

[pierre-gilles]

If we add the « .text-monospace » class, the theme gives us:

(And the glitch is indeed absent)

See:

What do you think?

I like it

[Tlse-vins]

It’s simple and effective. It’s just what we need.
I’d put it in place.
I like the vintage feel of the typography.

[guim31]

Personally I love this kind of font, so I approve