Ajout d'une requête APIRest Gladys permettant de récupérer les états des features sur une plage

Le code me parait bon, c’est bien plus clair comme ça!

J’ai une question sur les tests que j’ai mise sur Github! :slight_smile:

1 Like

I had tagged you on the PR hoping you’d be able to look at it after the requested changes, but you probably didn’t get around to it.
Do you think you’ll be able to get it into the next release or are there still changes to make?

I’ll be honest, I admit I’m a bit embarrassed by this kind of PR ^^ the feature request has 0 votes, and you’re the only one who asked for this feature.

There are 22 pull requests pending on the repo, and I don’t respond to most of them for lack of time.

How should I prioritize this request? Isn’t it a bit unfair to look at this PR but not the others?

I’m increasingly worried about how I’m using my time as I told you in private… and choices will have to be made.

I know you’re a longtime paying contributor, and I’d like to help you, but if I have to be logical, I normally shouldn’t invest time in this :pensive_face:

I’ll add my two cents.
I understand the purpose of this voting thing: to set priorities.

We have a limited number of votes, and I admit that even if a feature is developed and I get a token I don’t necessarily think to reuse

2 Likes

Hello @pierre-gilles,

I’m starting with this point because it’s the most important!! You really need to stop beating yourself up and putting a weight on your shoulders that doesn’t exist (at least for me). I may be a contributor and I will be more and more. Whether financially (as are 57 others to date and I hope many more soon ^^) or in PRs. This doesn’t give any right to pre-empt your time or anything else. And it mustn’t obligate you to anything. What’s important is the community and the project and this contribution is in that spirit and nothing else. We can all have more personal expectations and work on them at the right time, we can wait!! So from my side that’s always been clear.
That said, it seemed normal to me to be able to ask about progress and such, sorry that you took it badly.

Regarding this PR in particular. We discussed it several times and you yourself told me that it was simple to implement, and the first review had seemed good to you with a few remarks that I addressed. I have no idea where the other PRs stand in terms of timing and progress. But with these elements I thought it was reasonable to find out whether it required a long review and whether we could therefore benefit from it quickly; admittedly it has no votes (which seems logical since it’s something fundamental) but with several posts talking about this topic (notably for Node-RED - but also for any calculations that need to be done) I think it can help a lot of people.

Also I thought that handling small topics like this might interest you (easy to review, little code, simple PR).

No problem waiting if it doesn’t bring anything and no, I’m not a priority because I’m a contributor. Gladys and you deserve to be better known!! :heart_eyes: :star_struck: :wink:

@VonOx I’m not questioning the usefulness of the PR, it will be useful I’m sure!

My main difficulty right now is knowing by what criteria to prioritize my work.

We’re having this problem more and more: my available personal bandwidth is lower than the bandwidth the project demands (responding to messages, answering PRs, writing content, organizing a press launch, maintenance/after-sales support on Gladys Plus, coding a new feature, etc.)

If there’s more incoming throughput than outgoing, it’s mechanical: it accumulates.

And that’s what’s happening more and more, and it won’t get better with the project’s growth (which is a good thing — I’m not complaining here!! :D)

And if it accumulates, there’s only one solution: prioritize, because the « pile » of things to do is a dynamic pile that only fills up.

So inevitably, at every time t when I work on Gladys, I take the whole set of things to do, and I have to find a method to know how to order 1000 items that have no relation to each other.

When I decide whether I want a PR or not, in my head what’s happening isn’t « Do we want this? », in a perfect world yes of course there would be no question.

But what happens is:

"
Is it more of a priority to review this PR
OR that other PR
OR to reply to the email from that journalist who’s writing an article about Gladys
OR to put together the « Gladys at your home » video
OR to reply to XX on the forum
OR to unblock YY who can’t reset their Gladys Plus password
OR to develop Alexa compatibility
OR to write the newsletter
OR…
"

To come back to the example here, would you prefer to have this PR merged, or the Alexa compatibility merged?

No matter if these are not tasks of equal size, it’s a collection of little things that fill my day, so that’s part of the question I ask myself every morning :slight_smile:

@terdious don’t worry I’m not angry at all, and it’s nothing personal!! :smiley: It’s very hard to prioritize, and I just want to be very transparent about how I operate.

1 Like

Even if it’s not necessarily great for you, it’s actually a very good sign. I understand that you want to manage a lot of things and that you have to prioritize. I think you also need to be able to detach yourself from certain elements.

I’m thinking about the forum — maybe appoint some people (even if there are already some) to be a kind of direct point of contact?

A question is posted on the forum / a feature / … It might be useful if you don’t have to look at it, or at least not have to reply and spend time on it. That someone acts as a go-between, escalating problems and important items to you?

That if you need to make a decision, you’re presented with robust information?

Same for editing — maybe someone is available and knows how to do it? Not necessarily needing pure IT skills.

(After all it depends on what you want to do on the project; obviously I don’t want to « impose » anything ^^)

1 Like

In my job I have to manage a production environment continuously; sometimes I have to deal with a full disk / a container that crashed, etc., plus requests from devs like « my dev isn’t working » or « I can’t access such-and-such ». And for the record it’s extremely difficult to prioritize / organize myself.

Where I’m most effective is when I do only one thing. I turn off messaging / emails. Everything, and I focus on my work with my headphones. What I’m getting at is maybe you’re doing too much? :smiley: Some things could be handed over to the community. I think of quite a few devs who do well with their PRs. If it’s not OK for them, it doesn’t pass with you?

In any case, good luck — it’s brave to keep a project like this going! Hopefully many people will continue to subscribe :slight_smile:

3 Likes

I think we all understand, no worries about that.

Know that on my side nothing is a priority (I have lots of ideas and lots of needs, but what Gladys doesn’t do yet my HA (Home Assistant) does)

And above all, do it according to how you feel — a small PR that doesn’t « sell » anything immediately or big integrations, whatever.
0 or 2 releases per month, no big deal, as long as we do

3 Likes

That’s the case for the moderators :slight_smile:

I agree that ultimately, the idea is really that I’m less omnipresent on the forum so I can concentrate where I have real added value (development, project marketing)

aha 100% me too, I love being focused on one thing, headphones on, no social media, emails off, notifications off.

I think so too! I’d really like to see more cooperation on the project, to allow me to be only on the topics where I have expertise to provide / give the project’s vision.

He already helps me a lot!! :slight_smile: And yes, ideally if we could have 2-3 Alexs to help with PR review, that would be great!

1 Like

Hi @pierre-gilles,

I’m sending a little follow-up on this matter after more than a year.
I’ve reopened the PR, updated it and fixed the issues. If you have a bit of time to review, that would be great. Otherwise I’ll try again another day.

Thanks in advance in any case

Good luck.

Thanks for the PR @Terdious, I’ll look into it :slight_smile:

1 Like

Thank you very much for the feedback!! I just read it. I see that most of it is about tests!! That will let me learn… tests are really what I dread.

Thanks for your time, I’m trying to apply myself to solving them.

2 Likes