Feature description
I cannot trigger a scene only between 6:00 PM and 5:00 AM, the test does not allow it.
And unfortunately, adding a second condition is seen as an « AND », so always false.
I suggest adding an « OR » button, as in other condition blocks, specifically in time conditions.
guim31
January 30, 2022, 9:53am
2
I fully agree with the time conditions spanning two days (mostly at night).
Given the number of people asking for this fix, I’ve made time to fix it urgently
I propose this PR, I’m open to feedback:
master ← add-or-condition-check-time-scene
ouvert 09:36AM - 31 Jan 22 UTC
### Pull Request check-list
To ensure your Pull Request can be accepted as fa… st as possible, make sure to review and check all of these items:
- [x] If your changes affects code, did your write the tests?
- [x] Are tests passing? (`npm test` on both front/server)
- [x] Is the linter passing? (`npm run eslint` on both front/server)
- [x] Did you run prettier? (`npm run prettier` on both front/server)
- [x] If you are adding a new features/services, did you run integration comparator? (`npm run compare-translations` on front)
- [x] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to [the community](https://community.gladysassistant.com/) for testing before merging.
- [x] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
- [x] If you are adding a new features/services which needs explanation, did you modify the user documentation? See [the GitHub repo](https://github.com/GladysAssistant/v4-website) and the [website](https://gladysassistant.com).
- [x] Did you add fake requests data for the demo mode (`front/src/config/demo.js`) so that the demo website is working without a backend? (if needed) See [https://demo.gladysassistant.com](https://demo.gladysassistant.com).
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
### Description of change
This let the user use conditional time check when after time is before the before time.
VonOx
January 31, 2022, 4:51pm
4
Like @cicoub13 it works for me.
guim31
January 31, 2022, 5:03pm
5
When you put pressure on… it might end up with protests!!
I can’t say if it works though, I don’t know how to test it (do we need a Gladys instance like beta?)
Thanks a lot for this reactivity anyway!!
VonOx
January 31, 2022, 5:45pm
6
It’s really manual from the source code.
guim31
January 31, 2022, 6:00pm
7
Oh yes okay, then I’ll pass my turn ^^ thanks
The build has passed, the version is available
I’d appreciate feedback on this fix. If it’s good, we’ll close the topic.