cce66
November 9, 2023, 12:25pm
1
Hello
This is a purely aesthetic feature but it seems clearer to me for those who, like me, have a slow brain and aren’t very ‹ with it › .
When creating MQTT devices I find it would be easier to understand to
Hello,
There are two requirements in one request (it’s better to create a request for your « copy » button)
I don’t see the added value of the first
cce66
November 10, 2023, 9:24am
3
Hello @spenceur ,
Well, I find that it highlights and emphasizes the « Gladys to the outside » meaning more in the case I’m proposing! The first one, I find, seems more ambiguous regarding the direction of listening and publishing…
I admit I would do it, but I don’t really know how to do it if you could give me some pointers for that I’d be grateful! It could help me for other cases too!
cce66
November 10, 2023, 4:28pm
5
Thanks @spenceur , but what do I do next? I’m a beginner in this area on GitHub…
Look at this tutorial — you should be able to do it.
Salut à tous,
Pour tous ceux qui veulent aider au développement de Gladys, il manquait jusque-là un tutoriel pour mettre en place un environnement de développement Gladys 4 sous Windows.
La raison est simple: je fonctionne sous MacOS/Linux, et je n’ai aucune expérience sous Windows.
Heureusement, @VonOx nous a fait un super tutoriel pour développer sous Windows avec WSL!
Pour ceux qui sont sous MacOS/Linux:
Merci @VonOx pour ce super tutoriel !
:warning:Attention, ce tutoriel est desti…
cce66
November 10, 2023, 5:17pm
7
Thanks @Tlse-vins , I’ll take a look at that!
It’s impossible to use the copy/paste API on a non-HTTPS site. Possible on Gladys Plus but not locally, so this feature was removed (it existed in the past). We could put it back on Gladys Plus
For the changes to the titles, the change isn’t obvious to me. The text below already explains well what it does, doesn’t it?
cce66
November 30, 2023, 10:43am
9
Too bad about the copy-paste
Yes, but I find the implicit meaning is missing, maybe add the meaning so that it’s instantly clearer?
MQTT topic to publish => MQTT topic to publish to Gladys
MQTT topic to listen to => MQTT topic to listen to from Gladys
As it stands, I often tend to copy the wrong topic
I don’t know if I’m the only one in this case…
OK I understand, no problem making that more explicit
1 Like
@cce66 I’ve left feedback on your PR:
master ← cce66:patch-1
ouvert 11:40PM - 28 Nov 23 UTC
corrections typo et proposition changement libellé sur les appareils MQTT
###… Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
- [ ] If your changes affects code, did your write the tests?
- [ ] Are tests passing? (`npm test` on both front/server)
- [ ] Is the linter passing? (`npm run eslint` on both front/server)
- [ ] Did you run prettier? (`npm run prettier` on both front/server)
- [ ] If you are adding a new features/services, did you run integration comparator? (`npm run compare-translations` on front)
- [ ] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community ([french forum](https://community.gladysassistant.com/)/[english forum](https://en-community.gladysassistant.com/)) for testing before merging.
- [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
- [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See [the GitHub repo](https://github.com/GladysAssistant/v4-website) and the [website](https://gladysassistant.com).
- [ ] Did you add fake requests data for the demo mode (`front/src/config/demo.js`) so that the demo website is working without a backend? (if needed) See [https://demo.gladysassistant.com](https://demo.gladysassistant.com).
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
### Description of change
Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!
@cce66 You made quite a few PRs over the past few weeks, I left feedback on those PRs but without any response from you I don’t know if you saw them?
cce66
December 7, 2023, 1:17pm
13
Ah yes, I saw it then I had a solar panel failure just after and I zoned out… my memory is failing! Ohhhh dear I’ll check now — I’m thinking about it this PM and I’ll look at it tonight with a clear head
cce66
December 8, 2023, 1:54pm
14
@pierre-gilles I made the PRs and fixed one or two extra things — tell me if it’s OK or if I still have something to do (not comfortable with GitHub )
I’ve left feedback on this PR:
master ← cce66:patch-2
ouvert 01:05PM - 08 Dec 23 UTC
### Pull Request check-list
To ensure your Pull Request can be accepted as fa… st as possible, make sure to review and check all of these items:
- [ ] If your changes affects code, did your write the tests?
- [ ] Are tests passing? (`npm test` on both front/server)
- [ ] Is the linter passing? (`npm run eslint` on both front/server)
- [ ] Did you run prettier? (`npm run prettier` on both front/server)
- [ ] If you are adding a new features/services, did you run integration comparator? (`npm run compare-translations` on front)
- [ ] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community ([french forum](https://community.gladysassistant.com/)/[english forum](https://en-community.gladysassistant.com/)) for testing before merging.
- [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
- [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See [the GitHub repo](https://github.com/GladysAssistant/v4-website) and the [website](https://gladysassistant.com).
- [ ] Did you add fake requests data for the demo mode (`front/src/config/demo.js`) so that the demo website is working without a backend? (if needed) See [https://demo.gladysassistant.com](https://demo.gladysassistant.com).
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
### Description of change
Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!
As for the others, which PR are you talking about? Can you put a link here?
cce66
December 8, 2023, 5:25pm
16
Excuse me, no others for the moment, I was only talking about that one!