Hello, just a small suggestion as I was caught out. While adding to the dash, I slipped and clicked on delete. My entire dash was deleted without any warning. I had to reconfigure everything. Can we add a message that warns us of this deletion? I don’t know if others have been caught out too?
Psoy
February 22, 2022, 9:17pm
2
And yes, I’ve had my share too, so I vote
qleg
January 8, 2023, 3:05pm
3
Hello, I just got fooled as well
It’s just the beginning, that’s why.@qleg
Lokkye
January 21, 2023, 8:17pm
5
Small suggestion for the deletion confirmation:
Would this work for you?
If so, here’s the PR:
master ← callemand:validate-delete-dashbord
ouvert 08:17PM - 21 Jan 23 UTC
### Pull Request check-list
To ensure your Pull Request can be accepted as fa… st as possible, make sure to review and check all of these items:
- [x] If your changes affects code, did your write the tests?
- [x] Are tests passing? (`npm test` on both front/server)
- [x] Is the linter passing? (`npm run eslint` on both front/server)
- [x] Did you run prettier? (`npm run prettier` on both front/server)
- [ ] If you are adding a new features/services, did you run integration comparator? (`npm run compare-translations` on front)
- [ ] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to [the community](https://community.gladysassistant.com/) for testing before merging.
- [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
- [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See [the GitHub repo](https://github.com/GladysAssistant/v4-website) and the [website](https://gladysassistant.com).
- [ ] Did you add fake requests data for the demo mode (`front/src/config/demo.js`) so that the demo website is working without a backend? (if needed) See [https://demo.gladysassistant.com](https://demo.gladysassistant.com).
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
### Description of change
Just adding validation before delete dashboard
[quote=« Lokkye, post:5, topic:6979 »]
Lokkye
January 23, 2023, 7:40pm
7
@pierre-gilles : It’s fixed.
I was thinking I could do the same for the scenes. If that’s OK with you, I’ll make another PR.
Thanks!
Yes indeed, go for it! Thanks!
Jluc
January 24, 2023, 10:24am
9
That would be nice; while deleting a duplicated scene, I must have gone too fast and lost both
@Lokkye Thanks for your PR — it has been merged into master!
It will be included in the next Gladys release.
I’m closing this request to free up the votes
: Voted
