User icon dropdown menu

Tlse-vins · February 7, 2023, 1:27pm

Make the dropdown menu that appears when you click your name to go to settings close when you click outside.

Brisou · December 11, 2023, 2:15am

I don’t think this had been addressed, so I sent a PR — here’s the link:

github.com/GladysAssistant/Gladys

feat: Close user-dropdown with click outside

master ← jbrisavoine:user-dropdown-clickoutside

ouvert 02:12AM - 11 Dec 23 UTC

jbrisavoine

+24 -1

### Pull Request check-list To ensure your Pull Request can be accepted as fa…st as possible, make sure to review and check all of these items: - [ ] If your changes affects code, did your write the tests? - [x] Are tests passing? (`npm test` on both front/server) - [x] Is the linter passing? (`npm run eslint` on both front/server) - [x] Did you run prettier? (`npm run prettier` on both front/server) - [x] If you are adding a new features/services, did you run integration comparator? (`npm run compare-translations` on front) - [ ] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community ([french forum](https://community.gladysassistant.com/)/[english forum](https://en-community.gladysassistant.com/)) for testing before merging. - [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code) - [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See [the GitHub repo](https://github.com/GladysAssistant/v4-website) and the [website](https://gladysassistant.com). - [ ] Did you add fake requests data for the demo mode (`front/src/config/demo.js`) so that the demo website is working without a backend? (if needed) See [https://demo.gladysassistant.com](https://demo.gladysassistant.com). NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open. ### Description of change Following the request: https://community.gladysassistant.com/t/menu-deroulant-de-licone-utilisateur/7942 Close the User dropdown Menu on external click (not only on the avatar). Before: https://github.com/GladysAssistant/Gladys/assets/138247436/59dbff9b-3f53-4c30-88ff-54196016af55 After: https://github.com/GladysAssistant/Gladys/assets/138247436/b8bb2ab2-dac6-4973-9dec-436e90d4b213 https://github.com/GladysAssistant/Gladys/assets/138247436/7c8a27c0-a26a-4a07-bed6-16af30619854

Tlse-vins · December 11, 2023, 6:19am

Thanks @Brisou, I came across my request again this weekend; I had forgotten about it.

Brisou · December 11, 2023, 9:11am

You’re welcome @Tlse-vins and I must

pierre-gilles · February 9, 2024, 10:30am

@Brisou I don’t know if you saw my review of your PR last December?

github.com/GladysAssistant/Gladys

feat: Close user-dropdown with click outside

master ← jbrisavoine:user-dropdown-clickoutside

ouvert 02:12AM - 11 Dec 23 UTC

jbrisavoine

+24 -1

### Pull Request check-list To ensure your Pull Request can be accepted as fa…st as possible, make sure to review and check all of these items: - [ ] If your changes affects code, did your write the tests? - [x] Are tests passing? (`npm test` on both front/server) - [x] Is the linter passing? (`npm run eslint` on both front/server) - [x] Did you run prettier? (`npm run prettier` on both front/server) - [x] If you are adding a new features/services, did you run integration comparator? (`npm run compare-translations` on front) - [ ] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community ([french forum](https://community.gladysassistant.com/)/[english forum](https://en-community.gladysassistant.com/)) for testing before merging. - [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code) - [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See [the GitHub repo](https://github.com/GladysAssistant/v4-website) and the [website](https://gladysassistant.com). - [ ] Did you add fake requests data for the demo mode (`front/src/config/demo.js`) so that the demo website is working without a backend? (if needed) See [https://demo.gladysassistant.com](https://demo.gladysassistant.com). NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open. ### Description of change Following the request: https://community.gladysassistant.com/t/menu-deroulant-de-licone-utilisateur/7942 Close the User dropdown Menu on external click (not only on the avatar). Before: https://github.com/GladysAssistant/Gladys/assets/138247436/59dbff9b-3f53-4c30-88ff-54196016af55 After: https://github.com/GladysAssistant/Gladys/assets/138247436/b8bb2ab2-dac6-4973-9dec-436e90d4b213 https://github.com/GladysAssistant/Gladys/assets/138247436/7c8a27c0-a26a-4a07-bed6-16af30619854

Feel free to ask if you have any questions

Brisou · February 15, 2024, 8:54am

Hello,

If I’ve seen it, I’ll take care of it, thanks.

pierre-gilles · January 31, 2025, 4:21pm

I’m following up on this since I haven’t heard anything

My PR:

github.com/GladysAssistant/Gladys

Header: Close dropdown when clicking outside

master ← close-profile-dropdown-when-clicking-outside

ouvert 04:17PM - 31 Jan 25 UTC

Pierre-Gilles

+154 -132

### Pull Request check-list To ensure your Pull Request can be accepted as fa…st as possible, make sure to review and check all of these items: - [x] If your changes affects code, did your write the tests? - [x] Are tests passing? (`npm test` on both front/server) - [x] Is the linter passing? (`npm run eslint` on both front/server) - [x] Did you run prettier? (`npm run prettier` on both front/server) - [x] If you are adding a new features/services, did you run integration comparator? (`npm run compare-translations` on front) - [x] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community ([french forum](https://community.gladysassistant.com/)/[english forum](https://en-community.gladysassistant.com/)) for testing before merging. ### Description of change https://community.gladysassistant.com/t/menu-deroulant-de-licone-utilisateur/7942

https://close-profile-dropdown-when.gladys-plus.pages.dev

cicoub13 · January 31, 2025, 4:27pm

OK for me on mobile

pierre-gilles · February 6, 2025, 7:49am

It’s merged and it’ll be included in the next Gladys release!

pierre-gilles · February 14, 2025, 9:51am

Fixed in Gladys Assistant 4.53.0 :

Topic		Replies	Views
Graphique: Fermer le menu déroulant pour sélectionner la durée quand on clique à côté [Archive] Demande de fonctionnalités feature-request-core , feature-request-ux	4	43	February 14, 2025
[Dashboard] Gérer la mise à jour quand on revient sur l'application [Archive] Demande de fonctionnalités dashboard , feature-request-ux	9	94	February 14, 2025
[Dashboard] Ajouter quelques valeurs dans l'échelle de temps des graphiques [Archive] Demande de fonctionnalités dashboard , feature-request-ux	16	222	February 14, 2025
Fin de nettoyage [Archive] Demande de fonctionnalités feature-request-core , feature-request-ux	3	318	February 14, 2025
Ajout d'une box devices qui ne soit pas dépendante de la pièce ( cross room ) [Archive] Demande de fonctionnalités feature-request-core , dashboard , box-dashboard	24	1530	June 15, 2023

User icon dropdown menu

Related topics