New categories / new types dedicated to EVs

Feature requests
,
41

Well, hoping the conversion code is suitable, it works perfectly. If we change our distance unit « imperial/US » or « SI », we convert the associated distance units.

image
image246×112 4.36 KB

I therefore went back to the base data; I kept the additional data shown above in another file called « Step 2 ».

image
image426×899 22.2 KB
image
image421×894 22.1 KB

I still need to implement the icons, the rest is pushed.
@pierre-gilles, you can take a look at the conversion implementation if you wish.

Regarding the states, what do you think:

Icons version

States

  • At least one door open image / All doors closed image

  • At least one window open image / All windows closed image

Commands => Clickable icon button

  • Unlock (Vehicle locked image / Lock (Vehicle unlocked) image

  • Activate alarm (Alarm deactivated) image / Deactivate (Alarm activated) image

Text version

States

image
image439×116 2.77 KB

or
image
image349×114 2.89 KB

Commands

image
image346×125 3.93 KB
image
image437×126 4.26 KB

42

I would have reversed the icons; that seems more logical to me. You can see whether the door is ‹ closed › or ‹ not closed ›, the window ‹ closed › or ‹ not closed ›. Right?

43

:sweat_smile:
Totally agree @GBoulvin !! I just got mixed up ^^
I’ll edit and add the rest ^^

1 Like
44

My preference, in the end…

image
image438×349 10.8 KB
image
image439×844 23 KB

45

@pierre-gilles,

To make review easier, I split the PRs into several. They are all functional and can therefore be reviewed separately … or almost.

1 Like
46

It may be a minor detail for now, but regarding consumption, we should specify whether it refers to since departure / since the last charge / since the last trip.
Because as it stands we can’t guess.

Great work anyway!!! :grinning_face:

1 Like
47

@guim31,

No, you’re right, it’s not a minor detail because for API data, the assigned types cannot be changed afterwards.

For the first step, it will only concern the values sent by the API; the types are tied, and then it’s up to the API development to specify in the feature name what it represents. Only those that are specific and can be linked to an interface have a specific type. There will then be the possibility to add more general types that can be associated with Custom if you want to perform calculations (via MQTT fake_device), and there it will be up to the user to put the correct names.

In the screenshots I posted, those are fake_device that I used for tests; I may not have reflected the feature names accurately.

1 Like
48

[quote=« Terdious, post:45, topic:9529 »]
1st PR: Addition of the « target_current » feature and its handling identical to temperature to change intensity.
[/

1 Like
49

Great job on the 2nd PR :slight_smile:

I left feedback for you:

[quote=« Terdious, post:45, topic:9529 »]
3rd PR : Added support for conversions

1 Like
50

Fixed … finally a proposal ^^

51

Fixed!!

52

[quote=« pierre-gilles, post:49, topic:9529 »]
Nice work on the 2nd PR :slight_smile:

[quote="T

3 Likes
53

Enjoy yourself :sunglasses:

1 Like
54

Enjoy! :slight_smile: I’ll take a look at all that

1 Like
55

@Terdious

  • For PR #1, I added a small comment, and there’s also a comment from @S-Axel!
  • For PR #2, it looks good to me, but I’d like to run a quick test once PR #1 is merged.
  • For PR #3, same — once everything is merged I’d like to run a full test to make sure it works well, but the code looks good :slight_smile:

Great job! :clap:

Enjoy your vacation, we’ll look at this together when you get back :slight_smile:

3 Likes
56

Thank you for your feedback @S-Axel and @pierre-gilles.
The changes to PR

1 Like
57

@pierre-gilles? Did you get a chance to look? Is anything missing?

58

Hi :slight_smile: I was off at the end of last week because of the long weekend, I’m back on Gladys this morning, I’ll look into it during the day!

1 Like
59

@Terdious The fact that the setpoint intensity only changes in increments of 1, is that practical or not? (I can’t tell what the values are going to be)

1 Like
60

Hi @pierre-gilles,

Yes, generally with current control like that, you don’t change differently than that value on the ampere scale. And honestly I don’t see any other use than for a car or solar batteries to date.

For a vehicle, for example, as a rule we’re on a range of 5 to 32 A in most cases (some apparently go from 1 to 32 A) and in terms of power we’re therefore on increments of 250 W.

1 Like