Retour Gladys V4.0.4 - Dev Color Picker

Terdious · January 9, 2021, 10:29am

Hello,

First of all, it is important to thank @AlexTrovato for his work and for this PR that all color bulb owners have been waiting for.

A quick review of the usage:

1- When you arrive on the Dashboard, the box is initially gray and does not contain the current color. Also, if you change the color, the box takes on the color, but as soon as you refresh, the box turns gray again. Known issue during testing, will a PR be planned?

2- When opening the color-picker, whether on the browser dashboard (Chrome) or on the phone, the window goes all the way down, hiding the room boxes and device features. Is it possible to avoid this automatic sliding phenomenon and only do it if necessary (feature at the bottom of the page = scroll the window up by the height of the color picker only).

Small GIF to visualize points 1 and 2

Apart from that, it is very pleasant to be able to control this directly from Gladys. Looking forward to Temperature and Luminosity ^^

Spoiler? ^^

Edit: The GIF does not work apparently, sorry. I made several attempts, the file uploads well, the link is ![Color-Picker|1x1](upload://ju27NM0m0AJA7nlX87iZWYIFmBK.gif) but nothing appears in the preview. I made several attempts with files from 2 to 4MB but nothing more.

Edit-2: It’s good, thanks @Jean34

Jean34 · January 9, 2021, 10:57am

Host it on casimage or another place for your gif

VonOx · January 9, 2021, 12:12pm

Oh bug the dashboard

Terdious · January 9, 2021, 12:31pm

And yet, there isn’t all the Netatmo equipment yet… It’s going to be unreadable after that! Can’t wait for the multi-Dashboard ^^ In the short term, a search field might be a solution!!

Tlse-vins · January 9, 2021, 5:13pm

I haven’t had your issue number 1, I’ve tried several times but everything works fine on my end.

cicoub13 · January 9, 2021, 6:11pm

For issue 1, I think that depending on the poll interval, the actual value of the bulb has not yet been retrieved when you go to the Dashboard (right after adding the device).
You can try adding the device and wait for the first poll to occur to check?

Terdious · January 9, 2021, 6:14pm

No issues on that front @cicoub13, the tests were conducted a few hours after the addition. Moreover, once the color is selected for the first time, it is stored in the DB as « last_value » in the t_device_feature table. Therefore, even if the poll had not yet occurred, upon page refresh, it should have retained the previously selected color.

Are you experiencing different behavior on your end?

AlexTrovato · January 10, 2021, 6:52pm

Hello, thanks for the feedback.
Which integration service is your device with the color picker on?
What @cicoub13 says isn’t necessarily nonsense.

Terdious · January 10, 2021, 7:19pm

Hello,
All my devices with colorPicker are on Philips Hue.

VonOx · January 10, 2021, 9:55pm

@AlexTrovato I’m in the same situation as @Terdious with Philips hue

Goulby · January 11, 2021, 5:53am

On my end, I’ll test this next week. I have an Aeotec LED Bulb

pierre-gilles · January 11, 2021, 8:41am

For this point, the Philips Hue poll only acts on the binary on/off for now because there was no color until now, it’s a « normal » oversight, the feature needs to be developed

See code:

github.com/GladysAssistant/Gladys

server/services/philips-hue/lib/light/light.poll.js

master


      
          const hueApi = this.hueApisBySerialNumber.get(bridgeSerialNumber);
          if (!hueApi) {
            throw new NotFoundError(`HUE_API_NOT_FOUND`);
          }
          const state = await hueApi.lights.getLightState(lightId);
          
          // if the binary value is different from the value we have, save new state
          const currentBinaryState = state.on ? 1 : 0;
          const binaryFeature = getDeviceFeature(device, DEVICE_FEATURE_CATEGORIES.LIGHT, DEVICE_FEATURE_TYPES.LIGHT.BINARY);
          
          if (binaryFeature && binaryFeature.last_value !== currentBinaryState) {
            logger.debug(`Polling Philips Hue ${lightId}, new binary value = ${currentBinaryState}`);
            this.gladys.event.emit(EVENTS.DEVICE.NEW_STATE, {
              device_feature_external_id: `${LIGHT_EXTERNAL_ID_BASE}:${bridgeSerialNumber}:${lightId}:${DEVICE_FEATURE_TYPES.LIGHT.BINARY}`,
              state: currentBinaryState,
            });
          }
          
          // if the color value is different from the value we have, save new state
          let currentColorState;
          switch (state.colormode) {

After that, outside of the poll, there is still a problem I think!

Topic		Replies	Views
Gestion de la couleur des ampoules RGB depuis le dashboard [Archive] Demande de fonctionnalités	27	2390	January 8, 2021
Philips Hue - Incohérence tableau de bord Configuration	58	1214	May 20, 2024
Philips Hue - Issue with state #1690 Développement	12	565	May 24, 2023
Bandeau de LEDs WIFI (AL-LC01) avec firmware Tasmota, comment l'intégrer? Configuration	18	985	July 9, 2021
Dashboard - état détecteur de mouvement Configuration	28	889	March 4, 2024

Retour Gladys V4.0.4 - Dev Color Picker

Related topics