Reno
September 6, 2020, 12:18pm
1
We’ve discussed this several times on the forum and I think it’s an option missing for color bulb owners.
master ← renaiku:master
ouvert 09:21AM - 30 Nov 19 UTC
### Pull Request check-list
To ensure your Pull Request can be accepted as fa… st as possible, make sure to review and check all of these items:
- [ ] If your changes affects code, did your write the tests?
- [ ] Are tests passing? (`npm test` on both front/server)
- [ ] Is the linter passing? (`npm run eslint` on both front/server)
- [ ] Did you run prettier? (`npm run prettier` on both front/server)
- [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
- [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See [the GitHub repo](https://github.com/GladysAssistant/gladys-4-docs) and the [website](https://documentation.gladysassistant.com).
- [ ] Did you add fake requests data for the demo mode (`front/src/config/demo.json`) so that the demo website is working without a backend? (if needed) See [https://demo.gladysassistant.com](https://demo.gladysassistant.com).
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
### Description of change
Lib used:
* [react color](https://www.npmjs.com/package/react-color) to work on a color component. Creating one matching Gladys uses cases is planned. It's possible with react color.
* [reactcss](https://www.npmjs.com/package/reactcss) to change css with the state instead of changing the style in the JSX part of the code (might not be useful in the end)
* [magic-home](https://www.npmjs.com/package/magic-home) to control the devices.
Whats done:
* EVENTS and CONSTANTS to handle the string value of a device
* [Added `common` in `/front/src/config/i18n/en.json`](https://github.com/renaiku/Gladys/blob/0c387808ed46ce2e8abf1c3589ef16e32e390f44/front/src/config/i18n/en.json#L176)
* UI is WIP

I can’t vote anymore but I’m for it,
I was going to open the topic.
alex
September 7, 2020, 2:30pm
3
Vote limit reached as well but I vote for it too
VonOx
November 8, 2020, 8:55am
4
I’m just attaching a screenshot of what HA does and which I find more practical than the hue app.
What type of model is this?
Check the list of compatible bulbs here:
Salut à tous!
Nous sommes très proche de la release RC, et la page Intégrations du site fait un peu vide.
Ce serait sympa que pour la sortie, tous les périphériques compatible avec Gladys 4 soit dans cette liste
Je comprend que vous n’êtes pas tous à l’aise avec GitHub, j’ai donc créé un document partagé avec un exemple de produit. Vous pouvez remplir ce document avec les produits que vous utilisez dans Gladys 4, et je m’occuperais de transposer cette liste sur le site.
Attent…
VonOx
November 8, 2020, 12:08pm
9
You have a button in the UI to create an issue on GitHub, a developer will take care of it.
(in integrations / Philips Hue)
You can also find the real model in the Philips app
One might be able to look at this library:
I started rapidos yesterday evening. Tomorrow is a holiday, I’ll get on it if there are no other constraints.
Well, in terms of UX, I’m waiting for your feedback, but I have a first draft (note, please disregard the image quality and pixelation)
@AlexTrovato That’s really cool, I like it! Nice work on the UI
Do you really like it?
I did this quickly, I’m not a huge fan, but I’m not sure I can do better without the help of a « UX expert ».
I improve the « transition » effects to make the collapse/expand fluid and I put it on Github if you want to play with it.
I actually think it’s good! There are small details to fix, but apart from that the general idea is not bad.
The fact that the scroll bar pop is not great for example, maybe we should dynamically adjust the maxHeight of the box when the roommate picker is deployed?
Also see the behavior on mobile with touch. But otherwise I really think it’s not bad!
VonOx
November 11, 2020, 9:39am
17
As PG, only the scroll bar looks weird.
Other than that, good job
Like this? (in popover and scroll focus)
You have 2 TV Lamp, if I understand correctly, they are the same.
The first one is for on/off
And the second one is for the RGB
Can’t we put the color rectangle on the same line as the on/off button? And it will be activated or not depending on the bulb (RGB or white)
Here, the dashboard management is done per feature. It should be discussed with @pierre-gilles whether it is reasonable to group the selected features on a device.
I’m thinking about this because for now you only have one light bulb. When you have 10, you will have a very long dashboard if they are all in the same room.
I agree, but it’s a global issue even without colors. We need a light group system in a future version to group light actions.
Hamtaro
November 14, 2020, 1:21pm
23
I liked the smooth effect with the accordion… The popup is so 90s…
VonOx
November 14, 2020, 5:10pm
24
A good old modal ^^
@AlexTrovato it’s not simple after all this story (when you touch the UI anyway it’s always a hassle).
I prefer your second proposal