Add Zigbee2Mqtt ID to device configuration

[Archive] Feature request
,
21

I made the corrections and rebased the PR to be up to date.
However, there is an error with the Cypress tests
image
image

22

Probably a flaky test, I reran the tests!

Thanks for the fixes!

23

Hi @Will_71,

I did a test this morning against my production, and it seems like the view is broken in the case where no URL is set, which will be the case for all existing users.

This PR needs to be backward-compatible with the existing setup, so that if the URL is not set, the list is displayed as before without breaking the view.

Eventually, we could indicate a small message saying that the URL can be added in the settings to display links to devices.

What do you think? :slight_smile:

My review:

24

Yes that’s not a bad idea, I hadn’t thought of that case

25

It seems I don’t get the same result.

image
image849×570 33.4 KB

I didn’t remember this morning, but the goal was to not display the link if the address wasn’t set, and under no circumstances break the view display.

I’ll retest with a copy of my database to see if I can reproduce the issue. I’ll keep you posted as soon as I’ve checked.

26

With a copy of my database, there’s no issue either, my devices are displayed correctly. Just the link is not displayed because the URL is not configured

image
image1311×744 47.3 KB

image
image853×223 14.3 KB

Maybe the problem is because on my side I use an external broker and you use a USB dongle configured in Gladys?

27

Here’s the message I added

image
image1345×241 27 KB

I pushed a fix and added the message. I’m also rebasing with the latest release.
Could you retest on your side and let me know

Edit: I noticed the tests didn’t pass. I’ll look into it later.

28

Thanks for your feedback, I’ll let you know as soon as I’ve been able to test it! :slight_smile:

I had already tested in external mode on my production Zigbee2MQTT, so it’s normally not that. After, I might have just made a bad move :sweat_smile: I’ll take a look!

29

@Will_71 Thanks for adding the banner, I find it much clearer now! :blush:

I ran some more tests and everything works correctly. I think the problem was just on my end.

Thanks again for this development! For me, it’s validated, I’ve merged the PR and it will be included in the next version of Gladys :rocket:

30

This new feature is available in Gladys Assistant 4.80:

Thanks @Will_71 for the development!