Error 404 seems fine to me!
1 Like
It’s in progress!!
However we lose so much space
The performance is completely different with DuckDB:
1 hour = 184 states
moving to 24h = 1560 states
moving to 7 days = 3700 states
moving to 3 months = 37300 states (well, however navigation at that stage becomes problematic) and if multiple devices it’s rough.
I propose:
24h and under: no limit on points
Beyond that: 4000 points / number of features to display
When zooming, recalculate to become progressively more precise
A selection dropdown for display by aggregate (like on Metabase)
1 Like
It’s not inevitable!
Terdious:
24h or less: no limit on points
Beyond that: 4000 points / number of features to display
Why not just set a limit everywhere? 4000 points seems excessive to me though, currently on the dashboard we display 200
Yes! but still with the same limit
Actually you just need to keep exactly the same query as on the dashboard, but request more points, and have the ability to specify a period and not just a duration
Yes, absolutely!
1 Like
Perfect
Okay, I see how it looks with 1000 points.
pierre-gilles:
It’s not inevitable!
Okay, we’ll see that later then ^^
guim31:
Yes, I understood that, but I’m still impatient. Actually, I find that the chart display part mainly needed the ability to show them larger, and this is perfect for me!
Between that and the binary sensors, I’m thrilled with these latest devs!!
PR to choose the number of columns on the dashboard in the Gladys Plus test at https://terdious-add-choice-number-col.pages.dev/ for those interested!!^^
2 Likes
And finally the expanded view of the charts
2 Likes
Hi @Terdious and thanks for all your PRs
I did a series of reviews this morning:
I merged your PR about the number of dynamic columns on the dashboard:
master ← Terdious:add-choice-number-columns-dashboard
ouvert 08:32PM - 03 Jun 24 UTC
### Pull Request check-list
To ensure your Pull Request can be accepted as fa… st as possible, make sure to review and check all of these items:
- ~~If your changes affects code, did your write the tests?~~
- ~~Are tests passing? (`npm test` on both front/server)~~
- [x] Is the linter passing? (`npm run eslint` on both front/server)
- [x] Did you run prettier? (`npm run prettier` on both front/server)
- [x] If you are adding a new features/services, did you run integration comparator? (`npm run compare-translations` on front)
- [x] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community ([french forum](https://community.gladysassistant.com/)/[english forum](https://en-community.gladysassistant.com/)) for testing before merging.
- [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See [the GitHub repo](https://github.com/GladysAssistant/v4-website) and the [website](https://gladysassistant.com).
- [ ] Did you add fake requests data for the demo mode (`front/src/config/demo.js`) so that the demo website is working without a backend? (if needed) See [https://demo.gladysassistant.com](https://demo.gladysassistant.com).
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
### Description of change
Adding the deletion or addition of columns to the dashboard
A quick note on your PR that adjusts the chart sizes:
master ← Terdious:improvement-height-charts
ouvert 01:57PM - 05 Sep 24 UTC
…d on additional features
### Pull Request check-list
To ensure your Pull … Request can be accepted as fast as possible, make sure to review and check all of these items:
- ~~If your changes affects code, did your write the tests?~~
- ~~Are tests passing? (`npm test` on both front/server)~~
- [x] Is the linter passing? (`npm run eslint` on both front/server)
- [x] Did you run prettier? (`npm run prettier` on both front/server)
- ~~If you are adding a new features/services, did you run integration comparator? (`npm run compare-translations` on front)~~
- ~~Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community ([french forum](https://community.gladysassistant.com/)/[english forum](https://en-community.gladysassistant.com/)) for testing before merging.~~
- [x] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
- ~~If you are adding a new features/services which needs explanation, did you modify the user documentation? See [the GitHub repo](https://github.com/GladysAssistant/v4-website) and the [website](https://gladysassistant.com).~~
- ~~Did you add fake requests data for the demo mode (`front/src/config/demo.js`) so that the demo website is working without a backend? (if needed) See [https://demo.gladysassistant.com](https://demo.gladysassistant.com).~~
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
### Description of change
Small PR to increase the height of the charts depending on the number of features selected. Currently the curve is squashed to make room for the legend and contain the size of the box.
For the PR on binary devices, I have a few comments but nothing serious.
master ← Terdious:add-binary-chart
ouvert 11:44AM - 03 Jun 24 UTC
### Pull Request check-list
To ensure your Pull Request can be accepted as fa… st as possible, make sure to review and check all of these items:
- [x] If your changes affects code, did your write the tests?
- [x] Are tests passing? (`npm test` on both front)
- [x] Is the linter passing? (`npm run eslint` on both front)
- [x] Did you run prettier? (`npm run prettier` on both front)
- [x] If you are adding a new features/services, did you run integration comparator? (`npm run compare-translations` on front)
- [x] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community ([french forum](https://community.gladysassistant.com/)/[english forum](https://en-community.gladysassistant.com/)) for testing before merging.
- [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See [the GitHub repo](https://github.com/GladysAssistant/v4-website) and the [website](https://gladysassistant.com).
- [ ] Did you add fake requests data for the demo mode (`front/src/config/demo.js`) so that the demo website is working without a backend? (if needed) See [https://demo.gladysassistant.com](https://demo.gladysassistant.com).
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
### Description of change
Taken from the original PR: #Binary graph #1948
Thanks to @callemand for all the work done
Thanks again for these PRs which will clearly please a lot of people, me first
Don’t hesitate if you have any questions about the feedback
3 Likes
Hi @pierre-gilles , no questions, thanks for the reviews.
4 Likes
zedyxer
October 4, 2024, 9:08am
169
A big thank you for your work, gentlemen ^^
1 Like
@Terdious Thanks for your feedback
I merged the PR for the binary charts! For the other PR, there’s a conflict with the binary charts since it touches the same area. Can you fix the conflict?
Edit: Build in progress for Gladys Assistant 4.46.0. Releases in 4h!
Release Gladys v4.46.0 Production Image #102
3 Likes
Great!!
Conflict resolved and tested.
2 Likes
