This looks great as is, in terms of colors and the UI!
Thanks @Lokkye for all the work.
cce66
September 12, 2023, 7:34pm
42
Hi @Lokkye
Quick question: will this also work for temperature? (but there, red will be required! )
Lokkye
September 14, 2023, 6:01am
43
@pierre-gilles : My bad, I had forgotten to initialize the variables. It’s fixed now.
@cce66 : Once we’re completely in agreement on the humidity, I’ll take care of the temperature.
@Lokkye Very nice job, it’s very clean and it works perfectly
I have a small bit of feedback but it’s really a tiny detail:
For someone who would go up to 100% (which makes little sense, but oh well), the % extends beyond the bar
But otherwise, I find it very intuitive and very clear
1 Like
Me, actually…
And I don’t have a sauna
For a tropical terrarium, 85% to 100% are the ideal values…
1 Like
It’s clear that it’s nicer with this bar than the first proposal that just showed numbers and colors. This is very clear.
1 Like
Lokkye
September 15, 2023, 1:26pm
47
@pierre-gilles : I just made the correction for the « 100% »
2 Likes
@Lokkye Thanks for the feedback, it’s working better !
Small z-index issue though:
Lokkye
September 19, 2023, 6:42am
49
Excellent @Lokkye ! It’s good for me, tested and validated
I’ve just merged the PR, it’ll be included in the next version of Gladys.
2 Likes
Lokkye
September 20, 2023, 8:09pm
52
I will therefore tackle the temperature section if that suits everyone.
5 Likes
Lokkye
September 21, 2023, 12:20pm
53
Here is the result for the temperature:
With the small PR:
master ← callemand:min_max_temp
ouvert 12:19PM - 21 Sep 23 UTC
### Pull Request check-list
To ensure your Pull Request can be accepted as fa… st as possible, make sure to review and check all of these items:
- [x] If your changes affects code, did your write the tests?
- [x] Are tests passing? (`npm test` on both front/server)
- [x] Is the linter passing? (`npm run eslint` on both front/server)
- [x] Did you run prettier? (`npm run prettier` on both front/server)
- [x] If you are adding a new features/services, did you run integration comparator? (`npm run compare-translations` on front)
- [x] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community ([french forum](https://community.gladysassistant.com/)/[english forum](https://en-community.gladysassistant.com/)) for testing before merging.
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
### Description of change
Add a threshold for the room temperature widget
<img width="538" alt="Screenshot 2023-09-21 at 14 15 22" src="https://github.com/GladysAssistant/Gladys/assets/11317212/eb6d616a-72ec-48b1-93d1-4dc2bda6014c">
<img width="543" alt="Screenshot 2023-09-21 at 14 15 11" src="https://github.com/GladysAssistant/Gladys/assets/11317212/cf3a38ad-e184-4a06-b338-ae7504d1afb4">
<img width="546" alt="Screenshot 2023-09-21 at 14 14 49" src="https://github.com/GladysAssistant/Gladys/assets/11317212/d140adf1-1cf6-4742-a0c3-b56ead8d5736">
<img width="539" alt="Screenshot 2023-09-21 at 14 14 26" src="https://github.com/GladysAssistant/Gladys/assets/11317212/bd6d124f-3ce6-4055-8696-6d2b3905cda0">
<img width="675" alt="Screenshot 2023-09-21 at 14 14 18" src="https://github.com/GladysAssistant/Gladys/assets/11317212/6cd8489c-aa63-4f9b-bfb7-8f6d34287a8b">
7 Likes
Great
Can you make the icon yellow when there is no recent value? Use the bg-warning class to be consistent with the latest change on the dashboard
1 Like
Thank you and thank you for all the work on this part
guim31
September 21, 2023, 2:26pm
58
Do you have Bitcoins in your living room ???
1 Like
We need to store them somewhere (in Gladys)
1 Like
Super tidy @Lokkye
The scale might be a bit too high on the positive side, and not low enough on the negative side (0 to 100):
As a result, the default values are bunched up, whereas in our living room the temperature doesn’t go up to 90°C either
I would think we could rather use a scale of -20°C → 50°C (I know temperatures can go below or above that, but nobody will set a comfort temperature to -40, or to 60)
I also think we should handle both units: Celsius or Fahrenheit, and adapt the default levels accordingly? You can keep a single default format constant, but do a conversion if the user is in Fahrenheit?