guim31
Septembre 11, 2023, 6:07
1
Je viens de voir un problème (sur mobile et desktop) dans la création d’une scène.
Voici de quoi illustrer mon propos : Capture vidéo du 2023-09-11 20-02-41 - Embed (ce lien expire dans 48h … avis à @Pierre-Gilles si tu passes par là dans les deux jours !!)
Merci du retour @guim31 ! Tu pourrais créer une issue Github avec la vidéo ?
D’ailleurs, je précise que le forum accepte les .mp4 de petite taille, donc cette vidéo serait largement passée sur le forum
1 « J'aime »
guim31
Septembre 12, 2023, 7:50
3
Je vais créer une issue aujourd’hui pas de problème.
Le truc c’est que la video est en format .webm et j’ai pas songé à la convertir ^^
@guim31 c’est ça dont tu parlais ?
Car j’ai un l’affichage du select… de la box de dessous qui s’affiche devant la liste.
2 « J'aime »
guim31
Novembre 2, 2023, 7:49
8
1 « J'aime »
@pierre-gilles
GladysAssistant:master ← William-De71:scene-trigger-selectDeviceFeature
opened 10:12PM - 21 Nov 23 UTC
### Pull Request check-list
To ensure your Pull Request can be accepted as fa… st as possible, make sure to review and check all of these items:
- [ ] If your changes affects code, did your write the tests?
- [ ] Are tests passing? (`npm test` on both front/server)
- [ ] Is the linter passing? (`npm run eslint` on both front/server)
- [ ] Did you run prettier? (`npm run prettier` on both front/server)
- [ ] If you are adding a new features/services, did you run integration comparator? (`npm run compare-translations` on front)
- [ ] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community ([french forum](https://community.gladysassistant.com/)/[english forum](https://en-community.gladysassistant.com/)) for testing before merging.
- [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
- [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See [the GitHub repo](https://github.com/GladysAssistant/v4-website) and the [website](https://gladysassistant.com).
- [ ] Did you add fake requests data for the demo mode (`front/src/config/demo.js`) so that the demo website is working without a backend? (if needed) See [https://demo.gladysassistant.com](https://demo.gladysassistant.com).
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
### Description of change
Fix z-index issue in selectDeviceFeature on device change in scene trigger
https://github.com/GladysAssistant/Gladys/issues/1923
Bug similaire avec l’action Continuer seulement si dans les scènes
1 « J'aime »
L’issue github
opened 10:42PM - 21 Nov 23 UTC
z-issue in scene action only continue if
EDIT : @pierre-gilles
GladysAssistant:master ← William-De71:scene-action-condition
opened 09:12PM - 22 Nov 23 UTC
### Pull Request check-list
To ensure your Pull Request can be accepted as fa… st as possible, make sure to review and check all of these items:
- [ ] If your changes affects code, did your write the tests?
- [ ] Are tests passing? (`npm test` on both front/server)
- [ ] Is the linter passing? (`npm run eslint` on both front/server)
- [ ] Did you run prettier? (`npm run prettier` on both front/server)
- [ ] If you are adding a new features/services, did you run integration comparator? (`npm run compare-translations` on front)
- [ ] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community ([french forum](https://community.gladysassistant.com/)/[english forum](https://en-community.gladysassistant.com/)) for testing before merging.
- [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
- [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See [the GitHub repo](https://github.com/GladysAssistant/v4-website) and the [website](https://gladysassistant.com).
- [ ] Did you add fake requests data for the demo mode (`front/src/config/demo.js`) so that the demo website is working without a backend? (if needed) See [https://demo.gladysassistant.com](https://demo.gladysassistant.com).
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
### Description of change
Fix z-index issue in only-continue-if selector in scene action
1 « J'aime »
J’ai vu ta review, si tu as tout testé et que ça ne casse rien, je te fais confiance
J’ai mergé sur master !
2 « J'aime »
