Build Gladys v4.0.5

Development
21

Well, I canceled the build, the service dependencies were not installed because the architecture used for the build on the GitHub action does not match with the compatible architectures of the services:

Screenshot 2021-02-03 at 19.38.35
Screenshot 2021-02-03 at 19.38.352146×586 75.8 KB

Apparently, s390x is an IBM architecture…

I looked, @VonOx, the error was also in your builds, but it’s a bit silent because the installation of service dependencies is not blocking to install Gladys…

Maybe we should add a flag when building on CI so that it crashes if the dependencies are not installed successfully, that would be great :sweat_smile:

22

Yes, I had pushed everything that was « buildable » with the base image node:12

Yes, s390 is not common.

I’m not sure if on Circle we stopped the Flow if there was an error in the services.

Is this really a dependency issue or just that the platform is not present in the package.json?

23

No no we didn’t, it was more of a general remark!

No, just the platform not present in package.json, nothing serious

24

Besides, since it’s not Docker that returns the error but npm via qemu/docker, I think it’s impossible to catch.

We would need to catch it with the service installation script and pass the info to the parent process. I don’t know how. :thinking:

25

Actually, this installation process is custom, it’s a script that I coded

We just need to make the script crash (currently it’s a silent fail)

26

In a quick fix, I removed linux/s390x from the build, I don’t think it’s worth investing time to build on IBM architecture :slight_smile:

If someone really needs it, we’ll do more thorough testing and add it, but for now there are some great fixes that need to go to production!

27

I hadn’t even seen your PR :sweat_smile:

28

@VonOx Build released in v4.0.7. Fingers crossed!

29

It’s good, Gladys v4.0.7 is live! Everything seems good on my side :slight_smile:

30

So it should be automatic, so I should be above 4.0.4, right? Because right now I’m on 4.0.4 on my production instance.

31

We are not jumping from 4.0.4 to 4.0.7 (due to testing/fixes on the CI)

32

I thought so, that’s why I asked :slight_smile:

33

I had the same question! Is there a note for the release?

34

@Goulby I’m still waiting a bit before making an official post, until the release spreads a bit, and I get feedback on different architectures.

I will publish a post in Actualités as usual today :slight_smile:

35

Ok thanks! After that, I suppose that by exploring GitHub I can see what has been added

36

You take what is committed since 4.0.4 (January 8)

37

When it comes to versioning, I think we should not hesitate to increment the minor version 4.1.0 when there is one or more new feature(s). This will follow the principle of Semantic Versioning.

38

@cicoub13 I’m hesitant to implement semantic versioning for Gladys, because in fact, there are features in every release, so I would have to make minor releases for each release if I followed it strictly.

39

Or in between, with each new service, right?

40

@Goulby:

@VonOx: let’s see, in this case, it’s better not to use semver :slight_smile: