PR update January 2023

Development
1

Hello everyone @contributors! :folded_hands:

A quick message to take stock of the PRs in progress for 2023 :slight_smile:

I think I’ve gone through the PRs, are there any PRs/Issues waiting for feedback?

I’m trying my best but GitHub’s notifications aren’t very well designed, 90% of the notifications I receive are useless so I don’t use it much ( I receive a notification for every commit in a PR… super useful, and I’ve never managed to disable that )

2

I fixed this update

EDIT: I didn’t know that migration files were tested …

That one is ready too but no user feedback

1 Like
3

The tests don’t seem to be passing though?

Yes, the migrations run in the tests, otherwise the DB wouldn’t be there :smiley:

Ok, can you repost it on the forum maybe?

4

yes that’s logical, but I don’t see how to solve the problem:

20230102171731-update-tasmota-energy-features.js:26:33
  1) "before all" hook: before in "{root}"

  0 passing (6s)
  1 failing

  1) "before all" hook: before in "{root}":
     TypeError: Cannot read properties of null (reading 'id')
      at Object.up (migrations/20230102171731-update-tasmota-energy-features.js:26:33)

I understand the error: the t_service table in the test DB is empty, I created a seeder but it doesn’t change anything.

So what’s the right approach then? Do we catch it and stop the migration file?

5

Why not, but you still need to test this migration, otherwise we’re putting an untested migration out into the wild and it’s critical because if the migration crashes, Gladys won’t start anymore.

6

The tasmota PR is ok @pierre-gilles

I’m following up about the other one

1 Like
7

Good evening,

Regarding the Z-Wave PR, I have already received feedback from Mathieu who pointed out an issue that I fixed.
Since I must be the almost-only user of Z-Wave (42 Z-Wave nodes and 72 Gladys devices), the only thing to really test in a real situation is the setup of the Docker containers, even if we don’t have a Z-Wave device. The 42 nodes are functional (which is not the case for all my Zigbee devices)

Zwavejs2mqtt by rpochet · Pull Request #1619 · GladysAssistant/Gladys · GitHub

1 Like
8

Is it possible to connect to an existing container?

9

Yes, by choosing the ‹ External ZwaveJS UI › option

image
image879×591 37.4 KB

4 Likes
10

I only have one roller shutter module, I’ll test it tonight.

1 Like
11

@pierre-gilles can you refresh Alex’s PR to trigger a new build?

Thanks

12

This, for once, is a very, very good thing for those who had to migrate and switch back to Z-Wave JS UI (zwave js ui) not long ago!

3 Likes
13

Hello everyone!

I got back to Asia on Friday, and I’m diving back into development full throttle tomorrow :slight_smile:

I saw there are quite a few PRs pending; I’ll tackle all of that head-on tomorrow.

If there are any « hot » topics in your opinion, don’t hesitate to tell me here and I’ll take a look.

Basically I’m going to do 4 intensive weeks on Gladys.

I have several goals:

  • Release tomorrow all the improvements developed since Christmas (Scene duplication, etc. Basically everything that’s on master)
  • Have a first version of the Enedis-Linky integration in production for current Gladys Plus users, as a « private alpha »
  • Review all pending PRs
  • On Gladys Plus: restore the annual plan, add new payment methods (I’m thinking of Bancontact (Bancocontact) for our Belgian friends, available on Stripe but I’ve never activated it), consider different offerings: different pricing? 2-year plans like NordVPN does, for example? A plan including a hardware « starter pack » with our partner Domadoo? To think about.
  • Improve the developer documentation
  • Major UX pass across Gladys: do one or two days of development dedicated to UX to implement all the small requests that are trivial but need to be done someday: reorder the dashboard, reorder scenes, etc…
  • See how I can use Gladys Plus revenue to get more growth for the project. Contest? Partnership? Pay a contractor (if the revenue allows)?

It’s ambitious but very motivating!

During these 4 weeks, the more responsive you are, the more I can get done, so don’t hesitate!

Done! The build will be ready in a few minutes :+1: Sorry for the wait. Actually, for this it’s best if @AlexTrovato sets up Cloudflare Pages on your account (it’s free), that way you have the builds directly and don’t need to wait for me to create an « official » build

That’s great! Well spotted :sunglasses:

8 Likes
14

That was all I needed to have a great day :blush::blush::smiling_face_with_sunglasses:

2 Likes
15

Same :heart:
Thanks @pierre-gilles :blush:

1 Like
16

@VonOx any idea why the « legacy tags » fail on the latest Gladys build?

https://github.com/GladysAssistant/Gladys/actions/runs/3926693292/jobs/6712720389

17

For a reason I don’t know, there is no manifest.

I’m reproducing it locally

❯ docker manifest inspect gladysassistant/gladys:latest | jq -r '.manifests | to_entries[] | select(.value.platform.architecture == "arm" and .value.platform.variant == "v6").value | .digest'
no such manifest: docker.io/gladysassistant/gladys:latest
❯ docker manifest inspect gladysassistant/gladys:latest
no such manifest: docker.io/gladysassistant/gladys:latest
❯ docker manifest inspect gladysassistant/gladys:v4
no such manifest: docker.io/gladysassistant/gladys:v4
❯ docker manifest inspect gladysassistant/gladys
no such manifest: docker.io/gladysassistant/gladys:latest

I’ll continue investigating

1 Like
18

I’m reproducing it on my test repo.

I’m attempting a downgrade of buildx (v0.9.1) — it’s the last version that produced a successful build (the latest is v10.0.

1 Like
19

Great, thanks @VonOx!

20

I did quite a few merges this morning :sunglasses: Thanks for your PRs!

Screenshot 2023-01-20 at 11.42.53
Screenshot 2023-01-20 at 11.42.532518×954 303 KB

2 Likes