Thanks for this development @ProtZ, it looks great
For the documentation, you can make a PR on this repo :
The documentation is markdown files in this folder (for the article in English) :
And here for the article in French :
To write the documentation, I recommend taking your screenshots in English then in French in Gladys, then writing the documentation in French, and asking ChatGPT to translate the article for you.
Ok. But I didn’t quite understand from the thread of this discussion whether it was ready to test or whether we needed to wait for changes before being able to test…
I took the time today to test this new integration. Sorry I forgot that I had offered to do it…
I put myself in the following situation to test: in principle, not read the explanations in this post, and stick to what is written on the integration pages. And only read the explanations in this post if necessary
So far I’ve tested the Web integration. I’ll try to test the MQTT integration later in the day…
My suggestions to improve the Web integration (but overall it works very well, congratulations!!!) :
On the Integrations > Nuki page
The « Devices » page displays an interesting explanation when you don’t yet have an MQTT configuration (if I remember correctly, a text that explains there are two ways to connect: either via MQTT or via Nuki Web). But as soon as an MQTT is configured, that explanation no longer appears and you see the two buttons « MQTT Discovery » and « Web Discovery ». I think the explanation should remain visible until an actual device discovery has been performed.
The « Configuration » page is actually specific to the « Web » version. So maybe rename it « Web Configuration »
On the NukiWeb page, an API key is shown first, but I understand that this is not the key you need, and that you have to scroll down a bit on the page to generate an API token. Maybe your configuration page could clarify this in step 3: « … (Note, this is not the OAuth2 key, but rather a token to create specifically) ». And on all pages where you use the term « API Key », perhaps replace it with « API Token »?
When creating the API token on NukiWeb, you can check/uncheck the rights to grant. Do you need all of them? It would be good to indicate the rights that are actually necessary, so as not to grant permissions that are useless.
When the API key is saved in Gladys, it is displayed with asterisks, and the « Save configuration » button is active. I haven’t tried it, but if I click that button again, will it overwrite the real key previously entered (for example ‹ qslkjhqdgiuyzeart ›) with ‹ qsl**********art › and then stop working? I suggest greying out the button as long as nothing new has been entered in the API Key field…
After entering a valid API key, there could be a text prompting to go to the « Web Discovery » page
On the « Web Discovery » page, the text says « Automatic discovery… » but I didn’t immediately understand that you still had to click the « Search » button
On the dashboard, adding the lock with the Device widget is very clear, great. Just one detail: a click on lock/unlock takes a variable amount of time to complete, between « immediate » and several seconds. Maybe there could be an info message asking to wait to avoid accidental repeated clicks?
Okay, well I actually won’t be able to test the MQTT functionality, because I have a 3.0 lock and MQTT is only available on the 3.0 Pro and from 4.0 onward
Could that perhaps be a clarification to add to the initial explanation on the ‹ Devices › page and on the ‹ MQTT Discovery › page?
Thanks for your test @StephaneB with very pertinent remarks!
Normally, in Gladys, the click should be instantaneous, even if the action behind it takes longer to be propagated to the connected device. Is it really the case that you see the interface completely freeze?