@pierre-gilles , here’s the fix
master ← William-De71:volume-fix
ouvert 08:32PM - 10 Apr 24 UTC
### Description of change
Please provide a description of the change here. It… 's always best with screenshots, so don't hesitate to add some!
change the name of siren volume feature due to a problem of displaying tv and music volume
without the fix:

with the fix:

2 Likes
@pierre-gilles , the PR to add icons to the music features
master ← William-De71:music-feature-icon
ouvert 09:06PM - 10 Apr 24 UTC
### Pull Request check-list
To ensure your Pull Request can be accepted as fa… st as possible, make sure to review and check all of these items:
- [ ] If your changes affects code, did your write the tests?
- [ ] Are tests passing? (`npm test` on both front/server)
- [ ] Is the linter passing? (`npm run eslint` on both front/server)
- [ ] Did you run prettier? (`npm run prettier` on both front/server)
- [ ] If you are adding a new features/services, did you run integration comparator? (`npm run compare-translations` on front)
- [ ] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community ([french forum](https://community.gladysassistant.com/)/[english forum](https://en-community.gladysassistant.com/)) for testing before merging.
- [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
- [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See [the GitHub repo](https://github.com/GladysAssistant/v4-website) and the [website](https://gladysassistant.com).
- [ ] Did you add fake requests data for the demo mode (`front/src/config/demo.js`) so that the demo website is working without a backend? (if needed) See [https://demo.gladysassistant.com](https://demo.gladysassistant.com).
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
### Description of change
Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

1 Like
Thanks @_Will_71 for the fix!
The PR looks good to me, what was the issue, roughly?
I’ll deploy this to production on Monday
@pierre-gilles , I simply renamed the volume feature in the file constants.js .
What I need your input on, and which I don’t yet understand, is why this TV volume feature ends up looking for the new component I created instead of the MultiLevelDeviceFeature
Ah yes, indeed, the value must be unique too
It’s fine with me, I’ll merge and deploy this today!
Edit: Gladys Assistant 4.38.4 is currently being built with the fix
Gladys Assistant v4.38.4 is available and fixes the issue
For users who have already added the siren to Gladys, you’ll need to update it in the Gladys Zigbee2mqtt integration, otherwise the volume buttons will no longer work.
This time I did remember to deploy Gladys Plus
Thanks @_Will_71 for the fix!
4 Likes
No need to thank me, I made a mistake by overlooking this so I’m fixing it — it’s normal!
2 Likes
I can only congratulate you
1 Like
dahut
April 16, 2024, 9:23am
31
Thanks again for your quick responses @_Will_71 and @pierre-gilles
Works perfectly
2 Likes