Android TV integration

bertrandda · October 11, 2023, 6:21pm

What do you mean by Google Home remote? Is it via the Google Home app on your phone or via a Google Home speaker?

Ok maybe we should improve the UI so it’s clearer

Are you able to turn it off/on with this Chromecast or is it like your other Google TV, and it doesn’t work?

GBoulvin · October 11, 2023, 6:44pm

In the Google Home app:

I have this:

The circle doesn’t change the volume but if I click on ‹ ouvrir la telecommande ›:

I can change the volume (of the Google TV).

However, via the Chromecast HD:
Power on+off OK
Changing the volume is impossible but that’s a technical limitation because the volume is not controlled via the Chromecast but via IR (the supplied remote is universal)

Edit: wouldn’t there be a way to detect the Chromecasts present on the local network rather than entering the IP address manually?
It’s inconvenient because IPs are dynamic by default for me (and many people…)…

bertrandda · October 11, 2023, 7:29pm

Good idea, I need to see how it’s done in the other integrations.

AlexTrovato · October 12, 2023, 10:42am

For Google Home, I already have a PR to integrate TV devices

github.com/atrovato/Gladys

Google actions television

master ← google-actions-television

ouvert 07:30PM - 14 May 22 UTC

atrovato

+2108 -30

### Pull Request check-list To ensure your Pull Request can be accepted as fa…st as possible, make sure to review and check all of these items: - [ ] If your changes affects code, did your write the tests? - [ ] Are tests passing? (`npm test` on both front/server) - [ ] Is the linter passing? (`npm run eslint` on both front/server) - [ ] Did you run prettier? (`npm run prettier` on both front/server) - [ ] If you are adding a new features/services, did you run integration comparator? (`npm run compare-translations` on front) - [ ] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to [the community](https://community.gladysassistant.com/) for testing before merging. - [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code) - [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See [the GitHub repo](https://github.com/GladysAssistant/v4-website) and the [website](https://gladysassistant.com). - [ ] Did you add fake requests data for the demo mode (`front/src/config/demo.js`) so that the demo website is working without a backend? (if needed) See [https://demo.gladysassistant.com](https://demo.gladysassistant.com). NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open. ### Description of change Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

pierre-gilles · October 12, 2023, 3:41pm

@AlexTrovato is this PR ready for review?

Maybe re-run the tests, Codecov failed on the upload

AlexTrovato · October 12, 2023, 3:43pm

This is a PR on my repo, codecov is acting up on my account.
But yes, the PR is ready — I need to generate an up-to-date test image to have it approved by our seasoned testers

AlexTrovato · October 13, 2023, 5:53am

So I created a PR on the Gladys repo:

github.com/GladysAssistant/Gladys

Google actions television

master ← atrovato:google-actions-television

ouvert 05:51AM - 13 Oct 23 UTC

atrovato

+2103 -27

### Pull Request check-list To ensure your Pull Request can be accepted as fa…st as possible, make sure to review and check all of these items: - [ ] If your changes affects code, did your write the tests? - [ ] Are tests passing? (`npm test` on both front/server) - [ ] Is the linter passing? (`npm run eslint` on both front/server) - [ ] Did you run prettier? (`npm run prettier` on both front/server) - [ ] If you are adding a new features/services, did you run integration comparator? (`npm run compare-translations` on front) - [ ] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community ([french forum](https://community.gladysassistant.com/)/[english forum](https://en-community.gladysassistant.com/)) for testing before merging. - [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code) - [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See [the GitHub repo](https://github.com/GladysAssistant/v4-website) and the [website](https://gladysassistant.com). - [ ] Did you add fake requests data for the demo mode (`front/src/config/demo.js`) so that the demo website is working without a backend? (if needed) See [https://demo.gladysassistant.com](https://demo.gladysassistant.com). NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open. ### Description of change Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

And the test Docker image atrovato/gladys:google-home-tv is being built — it should take about 1 hour from now before it’s ready!

Thanks

GBoulvin · October 13, 2023, 9:12am

Despite several attempts:

Unable to find image 'atrovato:google-home-tv' locally
docker: Error response from daemon: pull access denied for atrovato, repository does not exist or may require 'docker login': denied: requested access to the resource is denied.
See 'docker run --help'.

Is there an issue with the sharing? Or is it just me?

AlexTrovato · October 13, 2023, 10:33am

Indeed, I made a mistake in the image name atrovato/gladys:google-home-tv, I am correcting my other comment.
Sorry for the inconvenience

GBoulvin · October 14, 2023, 8:05am

Hello!
I’m a bit stuck on how I should test @AlexT

AlexTrovato · October 14, 2023, 10:13am

Hi,

indeed, testing Google Home features isn’t the easiest.

First, you’ll have a problem because you won’t be able to test the Android TV integration and the TV functionality of Google Home at the same time, since each development is separate.

Regarding Google Home, today only Gladys Plus allows interacting with Google, and I advise against connecting a test instance to your main Gladys Plus account. You risk creating inconsistent backups.

It is possible to swap your production image for the test image, but I also discourage this procedure for the same risk of inconsistent backups.

(even if normally the risk of inconsistent backups is almost « impossible » with the Google Home test image, you can never be completely safe from a hidden bug)

One possibility would be to install a test Gladys Plus to which you would connect your test instance, but you would also need to configure the entire Google environment…

So it becomes complicated to test.

I think we still need to define a way to make testing with external services easier…

pierre-gilles · October 14, 2023, 2:30pm

I can provide Gladys test accounts if needed!

@AlexTrovato did you test the feature for real or not?

AlexTrovato · October 14, 2023, 2:53pm

Yes, I set up a Gladys Plus at home with all the Google configuration \n\nEDIT: via the Broadlink integration and a real TV.

pierre-gilles · October 14, 2023, 3:01pm

Ok great!!

@GBoulvin if you want a « secondary » Gladys Plus test account so as not to pollute your production, tell me

AlexTrovato · October 14, 2023, 8:17pm

What I find annoying when using the production Gladys Plus is that you’ll still have to « interrupt » production via Google Home by disconnecting from the Gladys service on Google to sign in with your test account, and vice-versa once the test is finished.
The devices will be deleted, and if the user has created triggers from Google Home (or other custom configuration), I don’t know what will happen. The user might lose everything.

pierre-gilles · October 16, 2023, 7:28am

I’m not sure I understand the scenario you’re describing… ^^

pierre-gilles · October 16, 2023, 1:00pm

@AlexTrovato I did a test with the Docker image and a « virtual » MQTT device :

But the device appears as « offline » in Google Home:

Any idea ?

AlexTrovato · October 16, 2023, 2:30pm

Uh no, that’s weird. Unless Gladys is unreachable. Or maybe because there are no values for the features.
Is the other « online » device from the same Gladys instance?

pierre-gilles · October 16, 2023, 2:35pm

Indeed I have never used this TV (virtual).

Are you setting the attribute « online »: true correctly?

Yes

AlexTrovato · October 17, 2023, 2:20pm

The device is « online: true » by default:

github.com/GladysAssistant/Gladys

server/services/google-actions/lib/utils/googleActions.queryDeviceConverter.js

f87a192b4


      
          
          /**
           * @description Converts a Gladys device into a Google Actions device.
           * @param {object} gladysDevice - Gladys device.
           * @returns {object} GoogleActions device.
           * @example
           * queryDeviceConverter(device);
           */
          function queryDeviceConverter(gladysDevice) {
            const device = {
              online: true,
            };
          
            gladysDevice.features.forEach((feature) => {
              const trait = determineTrait(feature);
          
              if (trait) {
                trait.states
                  .filter(
                    (state) =>
                      !state.features || state.features.find((f) => f.category === feature.category && f.type === feature.type),

However, I’ve just re-run some tests, and indeed, it doesn’t work anymore… according to Google’s tests, some required configurations for the TV are missing.

I’m revising my copy…

Topic		Replies	Views
Besoin de vous : gestion de la TV avec Google Développement google-home , feature-integration	6	397	January 24, 2024
[RESOLU] Impossible de créer nouvelle scène avec bouton Xiaomi depuis la MAJ 4.5? Configuration	11	1618	September 14, 2021
Review des PR - J'ai besoin de vous! Développement	73	3508	April 10, 2021
Intégrer Gladys dans GoogleHome [Archive] Demande de fonctionnalités feature-integration	52	5459	October 8, 2021
Présence utilisateur a la maison [Archive] Demande de fonctionnalités	56	4623	February 22, 2021

Android TV integration

Related topics