OpenWeather update on dashboard

djokoss22 · December 31, 2022, 2:18pm

Hello everyone,

Until now, I was using Gladys’ web interface to display my dashboards. And that was fairly rare.
For a few days now, I’ve been using Android tablets all around my home to display my dashboards and control my devices.

I’ve noticed since then that OpenWeather data is not updating, whether via the Gladys app or its web interface.
The state of my devices does update correctly as do the various graphs, etc…

I tried several things like restarting my Raspberry Pi 4, revoking all active Gladys sessions in the settings, disabling/re-enabling the OpenWeather service, trying another OpenWeather API key, but nothing works.
If I display a dashboard, say at 08:00, then at 17:00 the next day the OpenWeather display still shows the 08:00 temperature from the previous day and the forecasts for the hours starting from 08:00 of the previous day. There is no data refresh.

Is anyone else encountering this issue?
Do I need to create a scene so that the OpenWeather data updates?

Thank you in advance for your help/clarification.

spenceur · January 1, 2023, 6:23pm

No issues on my end, I reload the page when I pass in front of a motion sensor, maybe that’s why

pierre-gilles · January 2, 2023, 10:18am

Ok, I just figured out the bug, it’s really dumb! ^^

github.com/GladysAssistant/Gladys

front/src/components/boxs/weather/WeatherBox.jsx

master


      
            </div>
          );
          
          class WeatherBoxComponent extends Component {
            refreshData = () => {
              this.props.getWeather(this.props.box, this.props.x, this.props.y);
            };
            componentDidMount() {
              this.refreshData();
              // refresh weather every interval
              this.interval = setInterval(() => this.refreshData(), BOX_REFRESH_INTERVAL_MS);
            }
          
            componentDidUpdate(previousProps) {
              const houseChanged = get(previousProps, 'box.house') !== get(this.props, 'box.house');
              const advancedWeatherChanged =
                get(previousProps, 'box.modes.advancedWeather') !== get(this.props, 'box.modes.advancedWeather');
              const dailyForecastChanged =
                get(previousProps, 'box.modes.dailyForecast') !== get(this.props, 'box.modes.dailyForecast');
              const hourlyForecastChanged =
                get(previousProps, 'box.modes.hourlyForecast') !== get(this.props, 'box.modes.hourlyForecast');

I created an issue:

pierre-gilles · January 2, 2023, 10:58am

First commit of 2023

Bug fixed here:

github.com/GladysAssistant/Gladys

Fix #1679 : Weather box should refresh data every 30 minutes

master ← fix-weather-refresh-update

ouvert 10:55AM - 02 Jan 23 UTC

Pierre-Gilles

+1 -1

### Pull Request check-list To ensure your Pull Request can be accepted as fa…st as possible, make sure to review and check all of these items: - [x] If your changes affects code, did your write the tests? - [x] Are tests passing? (`npm test` on both front/server) - [x] Is the linter passing? (`npm run eslint` on both front/server) - [x] Did you run prettier? (`npm run prettier` on both front/server) NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open. ### Description of change Fix refresh weather bug

As soon as the tests pass I’ll merge into master

pierre-gilles · January 2, 2023, 11:41am

It’s merged into master! It will be included in the next Gladys release.

Topic		Replies	Views
OpenWeather "Météo" ne fonctionne plus Configuration	45	2128	May 2, 2023
Affichage graphique avec des données erronées Configuration	44	773	November 1, 2022
Nouvelle vidéo : Gladys Assistant chez vous #5, Cyril et son café prêt tous les matins grâce à Gladys! Actualités	37	2492	October 10, 2022
Gladys Assistant v4.3.1 est disponible, avec une nouvelle Open API pour Gladys Plus et autres 🚀 Actualités	39	3732	July 6, 2021
Retour d'expérience Gladys 4 beta Configuration	2	439	April 28, 2020

OpenWeather update on dashboard

Related topics