@Lokkye I left you a review!
1 Like
@pierre-gilles: Thanks for the review. I’m making the changes but I need you to answer my question about the PR 
@Lokkye I replied to you!
@pierre-gilles: Thanks for the reply. I’ve just pushed the new version (with the new table and react-select). Do you need a Docker image?
I’m fixing the tests that are failing on the PR
1 Like
No need, when it’s just UI I just pull and test locally on my Mac
1 Like
I had fun adding the ability to edit a scene’s icon in response to this request: Modification de l’icône des scènes après création
Here is the result :
Thanks!
1 Like
Magnificent @Lokkye !!! 
I’ll give you a review as soon as I can
1 Like
I just tested @Lokkye, it’s really nice and I really like the CSS animation when opening the configuration tab, it looks much better with it 
For « react-select », it’s perfect (remember to remove the other lib from package.json), you might just need to translate the « Create » — I think it’s possible to pass a translation to react-select:
Also, it would be cool if we could filter by tags in the list view:
But otherwise, functionally this new « configuration » block is super cool 
Another note, maybe an alignment issue with the tags in the list view, it looks odd I think:
6 Likes
7 Likes
Thanks for the changes @Lokkye!
I’m having a bit of trouble with the tag selector on the scene list — it jumps around a bit when used:
And on mobile it breaks the design a bit:
I’m not sure this component is suitable for tag filtering — what do you think?
On mobile, for example, don’t hesitate to stack elements when it gets too crowded; for example GitHub in the issues list does it like this:
![Screenshot 2023-10-13 at 19.00.25
I wasn’t happy with the result I had either.
[quote=« pierre-gilles, post:51, topic:7081 »]
I’m not sure this
@pierre-gilles : What do you think about putting the tags on the left like on the integrations screen ?
[quote="L
@pierre-gilles
I was thinking of something like this (I just placed the things without styling) :
It’s widely used on e-commerce websites.
What do you think?
3 Likes
@Lokkye
I like the concept, especially since it enables multi-criteria filtering!
And while I’m thinking about it—and unless this has already been suggested (I couldn’t find it)—is there a plan for an automatic filling of tags in scenes? I think useful tags would be « room » and « device », which would then allow filtering only the scenes related to a specific room or device because when scenes start to become numerous it can get tedious to know which scene contains a device that is behaving unexpectedly. I’ll check with @pierre-gilles whether I should make a request depending on whether it was already in the pipeline or not…
Not bad! Need to consider adding a way to deselect all, and in practice I don’t know how many tags people will have but it needs to remain usable despite the number of tags.
One single drawback is that, as a result, it’s not searchable
Also need to see what we do on mobile?
@cce66 no, that’s not planned and that’s not the development here.
@pierre-gilles : I just pushed the latest changes following the discussion we had, could you take a look and tell me what you think ?
1 Like
I’ll look at that today
Thanks @Lokkye for the PR, the UI looks really cool like this! Simple and effective.
I left you a review, I have a few small comments but nothing serious: