Lokkye
August 1, 2023, 12:35pm
1
I have a Mitsubishi air conditioner and I would like to be able to control it from Gladys.
Lokkye
August 1, 2023, 12:40pm
2
The little PR that does the trick:
master â callemand:melcloud
ouvert 12:32PM - 01 Aug 23 UTC
### Pull Request check-list
To ensure your Pull Request can be accepted as fa⊠st as possible, make sure to review and check all of these items:
- [x] If your changes affects code, did your write the tests?
- [x] Are tests passing? (`npm test` on both front/server)
- [x] Is the linter passing? (`npm run eslint` on both front/server)
- [x] Did you run prettier? (`npm run prettier` on both front/server)
- [x] If you are adding a new features/services, did you run integration comparator? (`npm run compare-translations` on front)
- [x] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to [the community](https://community.gladysassistant.com/) for testing before merging.
- [x] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
### Description of change
The goal of this PR is to add communication between MELCloud and Gladys to be able to control air conditioning provide by Mitsubishi
For the moment only air conditioning is available but we can add Air-To-Water and Energy-Recovery-Ventilation devices later.
<img width="363" alt="Screenshot 2023-08-01 at 14 30 51" src="https://github.com/GladysAssistant/Gladys/assets/11317212/67c95ad1-b201-4848-bb7b-34d894489fbc">
<img width="1244" alt="Screenshot 2023-08-01 at 14 31 19" src="https://github.com/GladysAssistant/Gladys/assets/11317212/0b22f2c8-6c5d-4fcc-b771-a50d6bda97ec">
<img width="404" alt="Screenshot 2023-08-01 at 14 31 59" src="https://github.com/GladysAssistant/Gladys/assets/11317212/4515e855-e328-4bce-84c5-ef12663b67fd">
<img width="1205" alt="Screenshot 2023-08-01 at 14 31 36" src="https://github.com/GladysAssistant/Gladys/assets/11317212/d07b1e8a-6618-4569-8952-f1c26d2cfc3a">
<img width="1240" alt="Screenshot 2023-08-01 at 14 31 32" src="https://github.com/GladysAssistant/Gladys/assets/11317212/998c78b5-f6fe-45f5-843e-db946bcb05ad">
1 Like
guim31
August 2, 2023, 8:25am
3
Could you detail which air conditioner youâre talking about? Because there can be several different systems (split / ducted) and different control technologies.
Lokkye
August 2, 2023, 8:39am
4
Iâm talking about air conditioners like this :
When you add your split units on MELCloud, you have to enter a bunch of info like the serial numbers of your split units and the outdoor units.
Normally, if I understood MELCloudâs « documentation » correctly, all their air conditioners are configurable as long as you can install the Wi-Fi module
1 Like
Hello.
I also have two splits (indoor units) from Mitsubishi (reversible air conditioners) using MelCloud. I am therefore also interested in integrating MELCloud into Gladys to be able to control my air conditioners and create scenarios.
2 Likes
@Lokkye can you make a Docker build of your PR so @Wesley_K can test it on his machine in addition to yours?
Lokkye
August 21, 2023, 1:56pm
7
@pierre-gilles and @Wesley_K : Here is the Docker image that works: delogzway/gladys:melcloud
1 Like
Hello @Lokkye .
Thank you very much. Iâll try to test it as soon as I can. I first need to find a mini PC to install Gladys on.
Quick question â since you have the same split units as I do, I suppose youâve installed a connected thermostat like Netnano to manage full scenarios with your AC (for example, if the room temperature is >= 28 then you set the AC to 26).
Thanks again for the work on the MelCloud integration.
Lokkye
September 4, 2023, 6:23am
9
Hello @Wesley_K
[quote=« Wesley_K, post:8, topic:8274 »]
Quick question since you own the same split units as I do, I suppose you installed a connected thermostat like Netnano to manage full scenarios with your AC (for example, if the room temperature is
1 Like
Before getting feedback from @Wesley_K , I gave you a small technical review @Lokkye
I didnât find anything major, I just noticed that there were a lot of variables referring to the Tuya integration (I guess you based it on the Tuya integration), maybe do a pass over the code with a quick search to replace any mention of the Tuya integration?
My review:
master â callemand:melcloud
ouvert 12:32PM - 01 Aug 23 UTC
### Pull Request check-list
To ensure your Pull Request can be accepted as fa⊠st as possible, make sure to review and check all of these items:
- [x] If your changes affects code, did your write the tests?
- [x] Are tests passing? (`npm test` on both front/server)
- [x] Is the linter passing? (`npm run eslint` on both front/server)
- [x] Did you run prettier? (`npm run prettier` on both front/server)
- [x] If you are adding a new features/services, did you run integration comparator? (`npm run compare-translations` on front)
- [x] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to [the community](https://community.gladysassistant.com/) for testing before merging.
- [x] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
### Description of change
The goal of this PR is to add communication between MELCloud and Gladys to be able to control air conditioning provide by Mitsubishi
For the moment only air conditioning is available but we can add Air-To-Water and Energy-Recovery-Ventilation devices later.
<img width="363" alt="Screenshot 2023-08-01 at 14 30 51" src="https://github.com/GladysAssistant/Gladys/assets/11317212/67c95ad1-b201-4848-bb7b-34d894489fbc">
<img width="1244" alt="Screenshot 2023-08-01 at 14 31 19" src="https://github.com/GladysAssistant/Gladys/assets/11317212/0b22f2c8-6c5d-4fcc-b771-a50d6bda97ec">
<img width="404" alt="Screenshot 2023-08-01 at 14 31 59" src="https://github.com/GladysAssistant/Gladys/assets/11317212/4515e855-e328-4bce-84c5-ef12663b67fd">
<img width="1205" alt="Screenshot 2023-08-01 at 14 31 36" src="https://github.com/GladysAssistant/Gladys/assets/11317212/d07b1e8a-6618-4569-8952-f1c26d2cfc3a">
<img width="1240" alt="Screenshot 2023-08-01 at 14 31 32" src="https://github.com/GladysAssistant/Gladys/assets/11317212/998c78b5-f6fe-45f5-843e-db946bcb05ad">
Lokkye
September 11, 2023, 6:13am
11
@pierre-gilles : Iâve just addressed the feedback on the PR (Yes, I based my code on Tuya to have the same structure across the integrations)
Lâimage Docker est en cours de crĂ©ation
1 Like
@Wesley_K Are you going to test the integration soon or not? No problem if not, just say so and we can organize on our side!
@Lokkye I did a technical review of the PR, everything is fine except for 2 lingering console.log statements, but itâs really a minor detail MELCloud integration (Mitsubishi Electric devices) by callemand · Pull Request #1839 · GladysAssistant/Gladys · GitHub
Since I donât think @Wesley_K is on the forum, as soon as the review is fixed, Iâll merge the PR â weâre not going to wait ages either
1 Like
Excellent, as soon as the tests pass, Iâll merge! Thanks for the quick response!
1 Like
Itâs merged, and it will be included in the next version of Gladys!
2 Likes
Live feature in Gladys Assistant 4.29:
Salut Ă tous !
Nouvelle version de Gladys aujourdâhui avec Gladys Assistant 4.29, une version qui apporte pas mal de nouveautĂ©s
Je vous en parle sur le blog :
NâhĂ©sitez pas Ă fĂ©liciter @Lokkye pour toute ces chouettes contributions rĂ©centes