Hello 
I still have the issue I mentioned about the LAN Manager service, namely this one (which has remained without any resolution response 
.
Hi, I can’t reproduce it, so it’s difficult to fix. You could maybe make a short video or a sequence of screenshots so we can see the exact steps you take.
I’ll send you the video by PM (it contains all my MAC addresses)
Otherwise, you’ll see that I have an error message that pops up, but I have nothing in my logs:
2023-05-14T12:55:45+0200 lan-manager.scan.js:19 (LANManager.scan) LANManager starts scanning devices…
2023-05-14T12:55:50+0200 lan-manager.scan.js:57 (NmapScan.onSuccess) LANManager discovers 18 devices
2023-05-14T12:55:50+0200 lan-manager.stop.js:12 (LANManager.stop) LANManager stops scanning devices
I can reproduce the error message case, but I can’t get duplicates…
So, I added a filter to enforce unique MAC addresses after the scan.
I’m generating a new test image atrovato/gladys:lan-manager, it will be ready within 1 hour.
If you can confirm that it fixes your problem, I’ll put it up for review for integration into Gladys.
Thanks
1 Like
Hello @spenceur,
do you think you can verify that the proposed fixes resolve the issues you reported?
Yes, as soon as I can — I’m not necessarily at home.
I’ll get back to you during the day on Sunday!
And at the moment I’m a bit too lazy to turn on the PC after a day on the computer ^^’
1 Like
Hello, just a quick follow-up, have you had time to test @spenceur?
@spenceur I hope you had a great vacation!
Small follow-up as we’re getting back to this topic 
@spenceur New follow-up I won’t give up!
Me neither
Ouch I missed that
I’ll look this weekend!
1 Like
For your information, I’m generating a more up-to-date image with the fixes.
3 Likes
I’ll retest after I return from my trip around the 14th.
Good evening,
I confirm the duplicate issues after the scan. I had the issue with the SunSpec integration (where I wanted to add discovery of PV inverters). I saw the PR « add filter on unique MAC address after scan » that I merged and the duplicates disappear 
@spenceur still no new tests ?
An updated image has been generated.
@pierre-gilles I think we’re going to merge the changes.
We haven’t had any feedback from @spenceur but @Romuald_Pochet confirms it’s working correctly.
The fixes :
- removal of duplicate devices with the same MAC address
- the end of the scan no longer reports an error
Just in case, an up-to-date image is being built (available within an hour): atrovato/gladys:lan-manager
The PR :
Thanks.
1 Like
Ah well, given Romuald’s feedback I figured it was enough, especially for the proofreading ^^’
Ok I merged! Thanks @AlexTrovato for the PR!
1 Like
Improvement deployed in Gladys Assistant 4.35 :
I’m closing this topic!
3 Likes