Review of PRs - I need your help!

Development
21

For info, I launched a dev build on master with the changes on the Philips Hue + user message propagation in other tabs :slight_smile:

22

I saw this pass by this morning

https://github.com/GladysAssistant/Gladys/pull/1098

Okay, 165 files, but at least 70 are to list compatible devices. So, good luck!!!

23

The sunset sunrise triggers don’t work for me, has anyone tested them in real life?

24

Normally @AlexTrovato had tested I think!

Doesn’t it work at all?

25

lol I had turned off my machine, dawn arrived, but Gladys wasn’t running :confused:

26

I created a very simple scene last night:

Send a message at sunrise.

Nothing in the chat this morning (the location is correct)

27

Oh crap
 my bad it was the PR author who tested in real:

image
image1170×1445 139 KB

28

I’m trying to prepare a test for tonight, hoping to see some logs.

29

I’m doing a test too!

30

No trace for me, the weird thing is that if I manually launch the scene, the message is received.

In the worst case, to test, you need to change the location of the house.

31

I’ve set a scene for tomorrow morning :slight_smile: Answer at 6:20!

32

The longest feature to debug :joy:
Patience is key!

33

lol 1st reply tonight, it will be the surprise at home (with a bonus a « what have you done now? Â» from Madame!!)

34

I had a scene that started at 6:45 PM, sunset time.

35

I confirm sunset is okay, I’m rescheduling sunrise for tomorrow

36

I confirm, sunrise not working, it didn’t work this morning!

@Lokkye any ideas? :slight_smile:

Edit: I’m investigating, and already there’s a timezone issue.

At my place (in GMT+8), the time used is London time, and so at midnight (in my timezone), Gladys calculates the sunrise/sunset at London time, so the day before.

See:

37

Ok, it took me some time to understand, but I think I’m on the right track:

https://github.com/GladysAssistant/Gladys/pull/1103

I’m making progress but it’s not exactly right yet

38

For your information, I have reviewed all the PRs that were pending (according to what I see on GitHub).

It was exhausting :sweat_smile:

If I haven’t reviewed a PR, it’s because I don’t see it, so please post a message on the forum to let me know :slight_smile:

39

For the timezone history, it’s normally fixed and merged on master and built on Docker with the « dev Â» tag.

I have the sunset that will soon rotate at my place. Tomorrow morning I will test the sunrise.

In any case, the logs seem to confirm that it is fixed (I added more verbose logs):

Screenshot 2021-03-22 at 15.56.40
Screenshot 2021-03-22 at 15.56.401350×146 70 KB

40

Sunset ok!

image
image1170×475 81.5 KB

See you tomorrow for sunrise :slight_smile: