Review of PRs - I need your help!

Good night then :grin:

Validated for sunrise!

And at your place?

Yes, it’s good on my end

Hello,

I would like to help with testing the new PRs in Gladys:

  • Is there a dedicated Docker image where you can clone a specific branch?
  • Has anyone made a guide?
  • Any information to share with me?

Thanks for your answers :smiley:

Which OS are you on?

No need to necessarily build a Docker image to test

Raspberry Pi + Docker.

[edit]
I was thinking of running a 2nd container on the Pi, with a different port and DB to evaluate new proposals.
Hence my question if there is already an image of this type, with gladys and git to switch from one branch to another.

I think he wants to know if you’re on Windows or on Mac.

Do you have a PC nearby?

I didn’t see the edit, there’s a dev tag but it’s what’s merged into the master branch and not yet released (the validated PRs)

We don’t create an image for each PR.

So if you want to test a PR, you have to do it manually or build an image.

At worst, I will use the image with the dev tag, install Git on it, and clone the branch I’m interested in.

That has no interest, you will do manual labor in a container.

Yes, I’m well aware of that, but it’s 3 commands (install, pull, and start).

That’s where you’re wrong

Ok you will pull and create the container with the dev image (that’s easy). In this image you will have to:

  • Stop Gladys
  • Uninstall Gladys
  • Install system dependencies
  • Clone the repo
  • Checkout the correct branch
  • Install npm packages
  • Build the front end and copy it to the server folder
  • Launch Gladys

Additionally, if you have Watchtower, as soon as a new dev image is built, you will lose your container as it will be overwritten.

You have the documentation for development environments => Mettre en place un environnement de développement sous Mac/Linux | Gladys Assistant (Windows / Mac and Linux)

Thanks for your recap, it helps me not to forget anything.

I know Docker well and was aware of all the aspects you mentioned. But I still know quite little about the Gladys development environments (even though I have already done quite a bit of NodeJS development).

After these exchanges, I will start again from the Dockerfile Gladys and modify it to be able to build my dev image based on a particular branch and on demand.

It will be simpler to create a « home-made Â» dev container, based on a particular PR when I want/ can test one.

The GitHub CI is designed to build a special branch (on demand)

You just need to define your secrets on your fork

On the Raspberry Pi, it will take too long

The Dockerfile is designed for docker buildx in multi-stage.

Hello everyone!

I think it would be cool to close all PRs that are no longer active. It’s becoming difficult to browse the PR list, and for a new person arriving, it looks like an « abandoned Â» repo. It seems like it’s not well maintained.

What do you think? :slight_smile:

If you have PRs that are not intended to be merged in the short/medium term, could you do a bit of cleaning? Thanks everyone :pray:

For information, I made a build gladysassistant/gladys:dev with all the new features recently merged, and there are a lot of them, including:

  • Node 14
  • Sequelize 6
  • Sunrise/sunset in scenes
  • Brightness selector on the dashboard
  • Node-nlp latest and the new set of phrases
  • Humidity box
  • Update of dependencies
  • Update of the Philips Hue library & new local search
  • and many more!

All recent changes:

I invite you to test and let me know if everything continues to work for you ^^

Hello @pierre-gilles,

Great job with all this! I hope I can test it this weekend!!

Tell me, wouldn’t it be interesting to double this kind of very interesting post about advances, as well as all major updates, in the « International Â» section of the forum, so that this part, which I hope will become increasingly important, can be brought to life and international members can feel integrated into the project?

Could you create a label « Outdated Â» or « Abandoned Â» so we can flag them? Some PRs were made by people who no longer contribute to the project.

Is it possible to integrate this PR?
https://github.com/GladysAssistant/Gladys/pull/552
I had a test Gladys with this service integrated and it worked well for me

I’ll have to rework the subject. What devices do you control with it? TV? Light?