Review of PRs - I need your help!

Development
61

2 projectors and 2 air conditioners

62

Clearly :slight_smile:

Don’t hesitate if you have feedback, I added two new improvements to this build today:

  • The merge of Zigbee2mqtt
  • A quite significant improvement in the performance of Gladys Plus :slight_smile:
63

@Will9 I’ve resumed work on Broadlink, there was a discussion about how to manage features and display. I will therefore simplify and generalize many things (and add the « clim Â» devices).

For the others,

Status of PRs awaiting review/merge:

PRs awaiting changes:

What are the statuses of:

I only took non-draft, non-WIP PRs.

64

Wow great @AlexTrovato :slight_smile: Thanks for the complete review!

65

This is a vulnerability issue in global dependencies, not related to the service:

found 30 vulnerabilities (28 low, 2 high) in 1184 scanned packages
 run `npm audit fix` to fix 29 of them.
 1 vulnerability requires manual review. See the full report for details.
Error: Process completed with exit code 1.

To be seen to make a fix on Master


I would like someone to look to help me properly handle the error not caught by the library :wink:

66

Are you sure? We don’t have this on master anyway, I think rebasing master should fix your error :slight_smile:

67

Indeed, the rebase fixes that :wink:

69

@VonOx are you really preparing for your career change? I took a look at your PR, it’s not bad!!! But I have some feedback. I think it would be nice if you provided the docker (docker-compose) command to launch pi-hole with non-conflicting ports with Gladys, it’s not complicated, but not trivial either.

70

Oh no! :sweat:. I should have said « screw it Â» in high school when they told me there were no job prospects in software (true story) and I really need to update my presentation because I have quite an unusual professional background. (From mechanical designer/concept designer to now PLM consultant/integrator).

I won’t hide the fact that this would have suited me better, but compared to you (the devs), there’s a gap that seems insurmountable to me!

Anyway, back to this PR. As you may have noticed, I need a base, some examples to develop from. I’ve picked from ongoing PRs and existing code to come up with something that works somewhat.

There are things I still don’t master, and it shows, but hey, we learn every day!

Thanks for testing and thanks for the feedback!

71

If you want technical answers to my comments, we can exchange in DM. I’ll tell you what/how to do, why to do it this way and all that
 :wink:

I’m not saying no to a new dev :smiley:

72

Are you developing the Linky service?

73

What makes you say that?

74

It’s a bit old but well. I got my hopes up lol

75

To consume the Enedis API, you need to be a legal entity. This will likely be offered through Gladys Plus.