@guim31 There were 3 developments required for this feature :
I don’t think testers are needed at this stage (the functional part is already validated), what’s left is tech-jargon ping-pong between Alex and me
I’ll keep everyone informed here anyway as soon as it’s ready / or if new testers are needed.
1 Like
guim31
January 2, 2023, 7:02pm
102
Thank you so much @pierre-gilles for all those details!
I think you can tell that I’m impatient
I can’t wait to try out my NUC!
To give an update here
I did a full review of PR #2 two weeks ago, and I had requested a Docker image to test. @AlexTrovato provided me with an image, which I launched today on an instance to run tests.
This PR #2 touches many areas because it’s a fairly large refactor of the code related to background task scheduling in Gladys.
This PR affects Gladys Plus code, so it’s very sensitive in my view because it impacts paying customers and there must be no regressions.
For now I’ve listed all these behaviors to test in real conditions:
@AlexTrovato Could you update your PR so we can provide an image to test here and get feedback? (I’m talking about PR #2 on the common-scheduler)
1 Like
The PR has been updated, the image is being built, it will take about 2 hours from now before it becomes available.
Its name: atrovato/gladys:common-scheduler.
Thanks
1 Like
guim31
February 9, 2023, 8:04pm
105
I’d be happy to test some stuff to take part in these devs… But I imagine you need a Zigbee2mqtt dongle connected to the test machine?
@AlexTrovato I tested the sunset last night, it still works just as well
(I went to check for myself that the sun was actually setting, you never know)
I also got the notification this morning for the sunrise, but I didn’t go check, I was sleeping
For Gladys Plus backups and hourly aggregations, that looks good to me too
Basically, only the login gateway + Amazon Alexa + Google Home are left
Thanks!
Not for this test, we’re not yet at the Zigbee2mqtt backup PR (which has already been tested, by the way)
Here we’re testing the « common-scheduler » PR which implements a new task scheduler in Gladys.
3 Likes
@guim31 Don’t worry about it, I ran all the tests this morning on my end.
Google Home
Alexa
Login Gateway
Nice work @AlexTrovato , I’m merging into master!
Next step, PR No. 3!
3 Likes
PR #3 , with z2m backup, is up to date:
master ← atrovato:z2m-gladys-backup
ouvert 04:36PM - 18 Jun 22 UTC
### Pull Request check-list
To ensure your Pull Request can be accepted as fa… st as possible, make sure to review and check all of these items:
- [x] If your changes affects code, did your write the tests?
- [x] Are tests passing? (`npm test` on both front/server)
- [x] Is the linter passing? (`npm run eslint` on both front/server)
- [x] Did you run prettier? (`npm run prettier` on both front/server)
- [x] If you are adding a new features/services, did you run integration comparator? (`npm run compare-translations` on front)
- [x] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to [the community](https://community.gladysassistant.com/) for testing before merging.
- ~~[ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)~~
- ~~[ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See [the GitHub repo](https://github.com/GladysAssistant/v4-website) and the [website](https://gladysassistant.com).~~
- ~~[ ] Did you add fake requests data for the demo mode (`front/src/config/demo.js`) so that the demo website is working without a backend? (if needed) See [https://demo.gladysassistant.com](https://demo.gladysassistant.com).~~
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
### Description of change
Store default z2m config in DB to be able to reload it with a backup.
+ clean "console.log" logs and code
Fixes #1378
The new image atrovato/gladys:zigbee2mqtt is ready.
I tested it this morning, it seems ok:
DB backup
Restore backup
Auto backup schedule (I’m waiting for 11
2 Likes
guim31
February 10, 2023, 8:29am
110
Damn… I’m impatient!! I’m already itching to switch to my NUC to see the change!!
Great, thanks!
The PR looks good code-wise; keep me posted on this point:
Verdict :
2023-02-10T23:00:00-0700 <info> backup.js:39 (Zigbee2mqttManager.backup) Zigbee2MQTT request for backup
2023-02-10T23:00:13-0700 <info> saveZ2mBackup.js:12 (Zigbee2mqttManager.saveZ2mBackup) Zigbee2mqtt: storing backup...
2023-02-10T23:00:14-0700 <info> saveZ2mBackup.js:24 (Zigbee2mqttManager.saveZ2mBackup) Zigbee2mqtt: backup stored
Everything seems
6 Likes
guim31
March 7, 2023, 2:01pm
113
Does that mean this backup feature will be included in the next Gladys release?
AlexTrovato:
Everything seems ok
Great
Thanks for the development and testing, it’s fine with me!
I’ve just merged into master, it will be included in the next Gladys release
4 Likes
The Zigbee2mqtt backup is available in Gladys Assistant 4.18:
Salut à tous !
Je suis rentré de congés cette semaine, et j’ai dépilé tout ce qui était en attente, et il y a des petites pépites
Tout n’est pas dans cette version ( il y avait beaucoup de PRs ! ), mais ces 2 fonctionnalités étaient à mon sens prête à partir. Le reste arrivera dans une prochaine version
Gestion native des boutons avec pression simple/double/relâche
Désormais, Gladys gère nativement les boutons pressions (type Xiaomi), qui permettent de lancer des actions…
2 Likes