Hello,
In the weather widget, I don’t really understand how today’s weather is displayed.
, which returns forecasts in 3-hour intervals.
However, where you’re right is that currently we don’t display the first interval — it’s strange, I don’t remember if that was intentional.
I made a PR to change that:
master ← fix-openweather-hours-displayed
ouvert 09:34AM - 21 Mar 24 UTC
### Pull Request check-list
To ensure your Pull Request can be accepted as fa… st as possible, make sure to review and check all of these items:
- [ ] If your changes affects code, did your write the tests?
- [ ] Are tests passing? (`npm test` on both front/server)
- [ ] Is the linter passing? (`npm run eslint` on both front/server)
- [ ] Did you run prettier? (`npm run prettier` on both front/server)
- [ ] If you are adding a new features/services, did you run integration comparator? (`npm run compare-translations` on front)
- [ ] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community ([french forum](https://community.gladysassistant.com/)/[english forum](https://en-community.gladysassistant.com/)) for testing before merging.
- [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
- [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See [the GitHub repo](https://github.com/GladysAssistant/v4-website) and the [website](https://gladysassistant.com).
- [ ] Did you add fake requests data for the demo mode (`front/src/config/demo.js`) so that the demo website is working without a backend? (if needed) See [https://demo.gladysassistant.com](https://demo.gladysassistant.com).
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
### Description of change
Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!
In your case you should see the « 10h » slot with this change. (However you won’t see 7h which has already passed and is not available in the free OpenWeather API)
I’ll keep you posted when this change lands in production.
2 Likes
This fix is available in Gladys Assistant 4.38.1:
Salut à tous !
Nouvelle version de Gladys aujourd’hui : Gladys Assistant 4.38.1
I’m closing this thread
1 Like
