Zigbee2mqtt: Docker test image based on Gladys v4

Development
285

Yes, that’s why I wrote internally.

The variable should be defined by default in the Docker image; we don’t need to define it at docker run.
I’m not talking about removing it, it is indeed useful outside of Docker.

The topic is Docker environments only.

286

Indeed, in the Docker image, it would be worth setting it as the default.

After that, for the Zigbee2mqtt topic, it’s better not to hardcode the folder. We should rely on the environment variable so that it’s scalable.

287

What I meant is that this variable defines the location of the base, which is not necessarily bound to the host, but to launch the service containers, this is the necessary information, the bind host (which can be completely different, even if unlikely). Exploiting this variable was a bad idea (on my part).

EDIT: And I do not want to hardcode it either, just retrieve the folder on the host side that was defined by the user during their docker run. That’s the safest option in my opinion.

288

Okay, it’s fixed. I put the getContainerMounts in the core Zigbee2mqtt service by cicoub13 · Pull Request #1098 · GladysAssistant/Gladys · GitHub
and the rest in my service.
In the future, maybe other services will need it.

289

I’m not contributing anything to your project, but I wanted to thank you for all your hard work!!

Having quite a bit of Aqara equipment but no gateway, I’m really eager to be able to use all of it.

Thanks a million times! :folded_hands:

290

Congratulations on all the work done @cicoub13 :clap:

I’m giving you a review today :slight_smile:

291

I just finished my review, and it’s good to go for me, it’s going to master! I just merged it :slight_smile:

A big congratulations to @Reno for starting this PR, to @cicoub13 for finishing it, to @lmilcent and everyone else who contributed to the PR with their tests and feedback.

This is great teamwork that truly represents the vision of open-source: doing together something we wouldn’t be able to do alone :smiley:

Now, the next steps:

  • I just launched a build on the « dev » tag (it’s equivalent to a prod build, just on the dev tag on Docker). It will take about 1 hour to build all platforms: https://github.com/GladysAssistant/Gladys/actions/runs/696876447
  • Once the dev build is ready, we will need to extensively test this build to make sure the next release doesn’t break anything, and especially that the Zigbee2mqtt integration works as expected.
  • If everything is good, I will press the button and we can go for a minor release in my opinion given all the new features we will have in the next release.

I can’t wait!! :slight_smile:

292

It’s great to see we’re almost there!!

Thank you again @Reno for starting all the work, as it was already well advanced and @cicoub13 for all your work! There was still a lot to do or improve, you must have spent a lot of time on it!

I’ll give you feedback during the day as soon as the new image with the dev tag is ready. :smiley: :smiley: :smiley:

293

For information the dev tag has indeed been built :slight_smile:

294

So far so good.

So far all my scenes are working, my Zigbee devices too, everything is great! :+1:

I still have a bug with Bluetooth presence, nothing to do with Zigbee (my nut is detected, a new device is created, but invisible from the scenes?!).

295

I’m on the « normal » version of Gladys (i.e., not the zigbee2mqtt build), will I see the integration appear soon?
I admit I don’t know the meaning of your PR / Build dev / release… so I don’t realize

296

No issues on my side either, everything seems to be in order.

The Z2M part works well with Aqara switches and an Aqara cube, their operation in scenes as well.
I just received a Zigbee LED controller (Gledopto GL-C-008P) I will be able to test if it is integrated and if not the PR request process for its addition :slight_smile:

Well done guys!

The test image named dev is an up-to-date image of Gladys with the latest additions (the latest PR = Pull-Request that have just been validated), it’s an image to test the proper functioning of the Zigbee2Mqtt service with the others, so you will see this integration appear soon (once it has been tested long, wide and crosswise) :wink:

297

Yes, you will see this integration appear on your Gladys instance in the next version of Gladys.

Before going into « production », a service goes through several stages with tests at every step to ensure there are no issues, and that everything works well. This discussion here is really for developers (PR/tag dev, etc.. this is jargon for us), not Gladys users (we are in the « Development » category of the forum).

When a new version of Gladys is released, I post a message in Actualités - Gladys Assistant community on the forum, you will see it pass :slight_smile:

298

Great!

Have you created a Bluetooth topic to discuss it?

299

Thanks for the info :slight_smile: I know this is the techies’ corner, but as I’m eagerly waiting to use my Zigbee devices, I’m following this topic.

I wasn’t necessarily expecting a simplification of all this, I’ll leave you to your technical terms! :+1:

300

@cicoub13 is there a way to cheat in db to connect to an existing mqtt server?

301

I think so :slight_smile: Activate the service, modify the variables in Z2M_MQTT_URL and GLADYS_MQTT_USERNAME/PASSWORD in the t_variable table and that should do it

I don’t provide maintenance :wink:

302

Great news that the Z2M version is going into production :smile:!

Well done, guys, for the work accomplished, can’t wait to test it now :grimacing:

303

For information, Gladys Assistant 4.2 is available and integrates Zigbee2mqtt :rocket:

Once again, well done to everyone for this development!

304

Great, I can now test my key that I just received!!
Thanks to the developers.