Duplication de scènes

[Archive] Feature request
, ,
21

Ok! You must have seen it, but the tests aren’t passing :slight_smile:

Don’t hesitate to ask if you need help with the tests!

22

Thanks for the suggestion but I managed to fix the test that wasn’t working. :slight_smile:
But I don’t know why the « Docker magic » job isn’t working on my PR. :frowning:
Do you have any idea?

23

And now I have a 502 on the Cypress installation :frowning:

24

The joys of CI :slight_smile:

Both errors look like temporary issues — the Cypress download mirror must have been down when you ran your builds. Restart the build (restart failed jobs), and it should pass.

For the Docker magic build, same — I think it’s an issue with the package repo being down. Maybe a GitHub outage itself ^^

25

I know all too well the joy of CI randomly failing :slight_smile:.
It passed for Cypress but not for the Docker magic :frowning:

26

I’m going to update one of my pull requests to see if it builds.

27

Actually all PRs are failing

I think I’ve found the reason

image
image467×122 2.83 KB

The fix ( cc @pierre-gilles )

1 Like
28

[quote="VonOx, post:27, topic:6414

29

Thank you very much @VonOx for the fix.
The PR is ready for review now

30

Thanks @Lokkye, I saw your PR, it works well for me and it’s much better with the icon choice :slight_smile:

I just have a few comments on the translations, a few small changes in the tests and the model’s duplicate function, but really nothing serious — just very small changes!

My review : Duplicate scene by callemand · Pull Request #1670 · GladysAssistant/Gladys · GitHub

Tell me what you think, for me apart from that it can go to production quickly :slight_smile:

2 Likes
31

Thanks for your review. I’ve made the small corrections. :slight_smile:

1 Like
32

Thanks for the fixes, it’s good for me!

Sorry I just saw one last small thing — basically we’re really trying to stop promise chains using .then() in favor of async/await, I spotted a .then that was lingering; if you can just convert it to await that would be perfect :grinning_face_with_smiling_eyes:

After that it’s good for me, I’ll merge!

Edit: we need to add it to the ESLint rules so it’s automatic.

Edit 2: I made a PR to add the ESLint rule (Add promise/prefer-await-to-then eslint rule by Pierre-Gilles · Pull Request #1675 · GladysAssistant/Gladys · GitHub) :grinning_face_with_smiling_eyes:

1 Like
33

It’s fixed. I also prefer async/await :slight_smile:

1 Like
34

Thanks for the fixes, it’s good for me!

I’ve merged into master, it will be included in the next Gladys release :slight_smile:

6 Likes
35

This is going to be really handy!!
Thanks @Lokkye !

3 Likes
36

Yes ! Great…

Thank you for this new feature

37

Hello!

Is this feature already available?

38

Very soon, in the next release, in a handful of days, probably… :wink:

1 Like
39

Not yet, I avoid doing releases when I’m not available afterwards to do maintenance in case of any issues, and I have a very busy start to January both personally and professionally so it didn’t fit the schedule :slight_smile:

I’m leaving again tomorrow for Asia (arriving Friday), I’ll get back into the swing of things next week and I think I’ll release the version then!

3 Likes
40

Available in Gladys Assistant v4.14!

1 Like