Intégration Node-RED pour lancer un container en un clic

[cce66]

@Lokkye
Hats off for this development! I really think it was a necessity for the average user because they will no longer need to perform command-line operations to get Node-RED with Gladys and it will allow anyone to integrate any hardware into Gladys via Node-RED like I did with my IPX800V5 or to cover any need! For example here, I send Gladys the altitude and azimuth of the sun at fixed intervals to control roller shutters!

Now integrating speech recognition (https://hub.docker.com/r/alphacep/kaldi-vosk-server) and Text To Speech (Docker images - TTS 0.22.0 documentation) into Gladys via containers?
Thanks again for this development and I can’t wait for it to be in production!

[Lokkye]

Thanks @pierre-gilles for the thorough test

@pierre-gilles

So, if I’ve already configured Node-RED once, I’m stuck (I think the old password is still in the file). By testing the hash against the password, indeed it’s not the same password. Do you properly delete the folder /var/lib/gladysassistant/node-red if the user decides to trash the Node-RED integration?

Oh darn, I had forgotten. I just committed the change

@pierre-gilles

• « server » → « serveur » in French
• We should standardize the name « Node-RED » in the integration. The official name is « Node-RED », except there are several casings in the UI (Node-red, NodeRed).
• For the documentation link, can you make « node-red » lowercase? There’s casing inconsistency there.

I’ve just fixed everything in the latest commit.

@pierre-gilles

Another more general question: shouldn’t we freeze the Node-RED version? (At least a major or minor version)

You’re right. I also prefer fixing a version; at least we know what’s actually installed.
It’s fixed in the latest commit

The Docker image is being built with all the changes

[pierre-gilles]

Thanks for the changes @Lokkye, I stopped then restarted Node-RED and now it works

Some feedback:

1. There’s still the margin issue on the « Disable » button. Adding a small class « mt-4 » (margin-top 4) on the div « Node-RED service state » makes it look better, I think:

2. The documentation link has a small typo « noder-red » instead of « node-red »

3. Still the little « jump » when disabling the service (same video as in my previous message)

Otherwise everything else is good Nice work!

[Lokkye]

@pierre-gilles

There is still the margin issue on the « Disable » button. With a small class « mt-4 » (margin-top 4) on the « Node-RED service status » div, it looks better I think:

Oops, I forgot, it’s fixed now

@pierre-gilles

The documentation link has a small typo « noder-red » instead of « node-red »

Fixed

@pierre-gilles

Still the little « jump » when disabling the service (same video as in my previous message)

What do you think of this version?

[pierre-gilles]

Thanks for all the changes!

@Lokkye

What do you think of this version?

It’s much better

If everything’s good for you, could you re-run a build and I’ll do a final review?

[Lokkye]

@pierre-gilles: The Docker image build is finished

[qleg]

What happens when you pin a version on the Gladys side with Watchtower? Doesn’t Watchtower update the container to the latest version?

[pierre-gilles]

Great, I’ll test @Lokkye !

@qleg

How does it work when you fix a version on the Gladys side with Watchtower? Watchtower doesn’t update the container to the latest version?

No! Watchtower updates a container if the referenced image is updated; to move from one version to another, you have to use a « floating » tag whose image is overwritten at

[pierre-gilles]

@Lokkye are you sure the build is finished? I pulled, restarted the container, and despite that I still have the old version (no margin, and the button still jumps)

[GBoulvin]

Maybe a stupid question but… Are you sure you refreshed your browser?
I’m asking because I had the same issue last time, despite a full rmi/pull…

[pierre-gilles]

Yes yes, I refreshed, I think the image isn’t up to date or was built on an older version?

[GBoulvin]

That’s how it is on my end, is that okay?

Edit: For me, we should add that the container can take up to 5 minutes to be deployed depending on the machine, the connection, etc…

[pierre-gilles]

Hard to compare, it’s the desktop web behavior I was looking at

[GBoulvin]

Oops, indeed, no change then…

[Lokkye]

Oops, sorry I forgot to push the code
It’s done now, the Docker image has been pushed and I tested in my environment that the Docker image included the changes

[pierre-gilles]

Excellent, it’s been tested and approved on my end functionally! I’ll look at the PR for code quality and I’ll keep you posted.

[pierre-gilles]

Regarding my technical review, I have some feedback:

Docker node red integration

[Psoy]

hello
I just installed the Node-RED test image, everything is going well, I have the correct interface, but when I click on the URL, I cannot access Node-RED.
Do I need to change or recreate the password?
thank you for your help

[Lokkye]

@pierre-gilles: I’ve addressed the feedback on the PR.
@Psoy: Do you not see the Node-RED login page, or are you unable to log in with the provided username/password?

[Psoy]

hello @Lokkye
I can see the page :

I do nothing other than click on the URL, without touching the password, and this is what happens

Connection failed

Firefox cannot establish a connection to the server at 192.168.1.136:1881.

    The site might be temporarily unavailable or overloaded. Try again later;
    If you are unable to browse any sites, check your computer's network connection;
    If your computer or network is protected by a firewall or proxy, make sure that Firefox is allowed to access the Web.