Menu déroulant de l'icone utilisateur

Tlse-vins · Février 7, 2023, 1:27

Faire en sorte que le menu déroulant lorsque vous cliquez sur votre nom pour aller dans les paramètres se ferme si vous cliquez à côté.

Brisou · Décembre 11, 2023, 2:15

Je ne pense pas que ça avait été traité donc PR envoyé, voici le lien :

github.com/GladysAssistant/Gladys

feat: Close user-dropdown with click outside

GladysAssistant:master ← jbrisavoine:user-dropdown-clickoutside

ouvert 02:12AM - 11 Dec 23 UTC

jbrisavoine

+24 -1

### Pull Request check-list To ensure your Pull Request can be accepted as fa…st as possible, make sure to review and check all of these items: - [ ] If your changes affects code, did your write the tests? - [x] Are tests passing? (`npm test` on both front/server) - [x] Is the linter passing? (`npm run eslint` on both front/server) - [x] Did you run prettier? (`npm run prettier` on both front/server) - [x] If you are adding a new features/services, did you run integration comparator? (`npm run compare-translations` on front) - [ ] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community ([french forum](https://community.gladysassistant.com/)/[english forum](https://en-community.gladysassistant.com/)) for testing before merging. - [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code) - [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See [the GitHub repo](https://github.com/GladysAssistant/v4-website) and the [website](https://gladysassistant.com). - [ ] Did you add fake requests data for the demo mode (`front/src/config/demo.js`) so that the demo website is working without a backend? (if needed) See [https://demo.gladysassistant.com](https://demo.gladysassistant.com). NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open. ### Description of change Following the request: https://community.gladysassistant.com/t/menu-deroulant-de-licone-utilisateur/7942 Close the User dropdown Menu on external click (not only on the avatar). Before: https://github.com/GladysAssistant/Gladys/assets/138247436/59dbff9b-3f53-4c30-88ff-54196016af55 After: https://github.com/GladysAssistant/Gladys/assets/138247436/b8bb2ab2-dac6-4973-9dec-436e90d4b213 https://github.com/GladysAssistant/Gladys/assets/138247436/7c8a27c0-a26a-4a07-bed6-16af30619854

Tlse-vins · Décembre 11, 2023, 6:19

Merci @Brisou je suis retombé sur ma demande ce week-ends, je l’avais oublié.

Brisou · Décembre 11, 2023, 9:11

Je t’en prie @Tlse-vins et je t’avoue, je suis tombé dessus par hasard aussi ce weekend

pierre-gilles · Février 9, 2024, 10:30

@Brisou Je ne sais pas si tu avais vu ma review de ta PR en décembre dernier ?

github.com/GladysAssistant/Gladys

feat: Close user-dropdown with click outside

GladysAssistant:master ← jbrisavoine:user-dropdown-clickoutside

opened 02:12AM - 11 Dec 23 UTC

jbrisavoine

+24 -1

### Pull Request check-list To ensure your Pull Request can be accepted as fa…st as possible, make sure to review and check all of these items: - [ ] If your changes affects code, did your write the tests? - [x] Are tests passing? (`npm test` on both front/server) - [x] Is the linter passing? (`npm run eslint` on both front/server) - [x] Did you run prettier? (`npm run prettier` on both front/server) - [x] If you are adding a new features/services, did you run integration comparator? (`npm run compare-translations` on front) - [ ] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community ([french forum](https://community.gladysassistant.com/)/[english forum](https://en-community.gladysassistant.com/)) for testing before merging. - [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code) - [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See [the GitHub repo](https://github.com/GladysAssistant/v4-website) and the [website](https://gladysassistant.com). - [ ] Did you add fake requests data for the demo mode (`front/src/config/demo.js`) so that the demo website is working without a backend? (if needed) See [https://demo.gladysassistant.com](https://demo.gladysassistant.com). NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open. ### Description of change Following the request: https://community.gladysassistant.com/t/menu-deroulant-de-licone-utilisateur/7942 Close the User dropdown Menu on external click (not only on the avatar). Before: https://github.com/GladysAssistant/Gladys/assets/138247436/59dbff9b-3f53-4c30-88ff-54196016af55 After: https://github.com/GladysAssistant/Gladys/assets/138247436/b8bb2ab2-dac6-4973-9dec-436e90d4b213 https://github.com/GladysAssistant/Gladys/assets/138247436/7c8a27c0-a26a-4a07-bed6-16af30619854

N’hésite pas si tu as des questions

Brisou · Février 15, 2024, 8:54

Hello,

Si j’ai vu, je m’en occupe, merci.

pierre-gilles · Janvier 31, 2025, 4:21

J’ai repris le sujet vu que j’ai pas eu de nouvelles depuis

Ma PR :

github.com/GladysAssistant/Gladys

Header: Close dropdown when clicking outside

GladysAssistant:master ← GladysAssistant:close-profile-dropdown-when-clicking-outside

opened 04:17PM - 31 Jan 25 UTC

Pierre-Gilles

+154 -132

### Pull Request check-list To ensure your Pull Request can be accepted as fa…st as possible, make sure to review and check all of these items: - [x] If your changes affects code, did your write the tests? - [x] Are tests passing? (`npm test` on both front/server) - [x] Is the linter passing? (`npm run eslint` on both front/server) - [x] Did you run prettier? (`npm run prettier` on both front/server) - [x] If you are adding a new features/services, did you run integration comparator? (`npm run compare-translations` on front) - [x] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community ([french forum](https://community.gladysassistant.com/)/[english forum](https://en-community.gladysassistant.com/)) for testing before merging. ### Description of change https://community.gladysassistant.com/t/menu-deroulant-de-licone-utilisateur/7942

https://close-profile-dropdown-when.gladys-plus.pages.dev

cicoub13 · Janvier 31, 2025, 4:27

OK pour moi sur mobile

pierre-gilles · Février 6, 2025, 7:48

Un message a été scindé en un nouveau sujet : Graphique: Fermer le menu déroulant pour sélectionner la durée quand on clique à côté

pierre-gilles · Février 6, 2025, 7:49

C’est mergé et ça partira dans la prochaine release de Gladys !

pierre-gilles · Février 14, 2025, 9:51

Corrigé dans Gladys Assistant 4.53.0 :